0054102: Erroneous export WS response can contain an unterminated json content

Openbravo Issue Tracking System - Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0054102

Modules

Openbravo Business API

public

2023-12-12 10:43

2023-12-12 11:06

Reporter

caristu

Assigned To

Triage Platform Conn

Priority

high

Severity

minor

Reproducibility

always

Status

acknowledged

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Regression date

Regression introduced by commit

Regression level

Review Assigned To

Support ticket

OBNetwork customer

Regression introduced in release

Summary

0054102: Erroneous export WS response can contain an unterminated json content

Description

When the export API WS is called and it has a mapping error, the response content is an unterminated JSON.

Note that with issue 0054015 we fixed just the part of responding with an error status. But it would be nice to also avoid returning an incomplete JSON in the response content.

Steps To Reproduce

1) Choose an export API endpoint
2) Force a failure in the mapping used by that endpoint
3) Note that:
3a) Now the response status is error (fixed by 0054015)
3b) The content of the response is an unterminated json similar to this:

{
"data":

Proposed Solution

Catch the mapping error and include the failed item in an "errors" property in the response. Something similar to what is done here[1].

TBD: if we want to stop the export on the first failed item or not.

[1] https://developer.atlassian.com/cloud/jira/platform/rest/v3/api-group-issues/#api-group-issues [^]

Additional Information