Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0054068POS2POSpublic2023-12-01 11:232024-01-24 18:13
ReporterNaroaIriarte 
Assigned ToNaroaIriarte 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0054068: There should exist a sequence number to properly sort the selector filters in the CRM connector
DescriptionThe selector filters should be handled by a sequence number as the main or advanced selectors.
Steps To Reproduce- Login as the White Valley Admin in the backoffice.
- Go to the CRM connector window, and to the filters tab.
- If you create a new filter you can see that there is not sequence number field for the selector filters. There is for main and advanced filters.
- It should exist a sequence number for the selector filters too.
Proposed SolutionAdd a new sequence number field called "Selector filter sequence number" with a display logic based on the check "Selector filter"
Adapt frontend logic to use this new field to sort the filters
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-12-01 11:23NaroaIriarteNew Issue
2023-12-01 11:23NaroaIriarteAssigned To => NaroaIriarte
2023-12-01 11:23NaroaIriarteOBNetwork customer => No
2023-12-01 11:23NaroaIriarteTriggers an Emergency Pack => No
2023-12-01 11:24NaroaIriarteStatusnew => acknowledged
2023-12-01 12:49guilleaerSummaryThere should exist a sequence number to properly control the selector filters in the CRM connector => There should exist a sequence number to properly sort the selector filters in the CRM connector
2023-12-01 12:50guilleaerProposed Solution updated
2023-12-01 12:52NaroaIriarteStatusacknowledged => scheduled
2023-12-05 12:06hgbotMerge Request Status => open
2023-12-05 12:06hgbotNote Added: 0157961
2023-12-07 15:58hgbotNote Added: 0158016
2024-01-08 15:53NaroaIriarteNote Added: 0158946
2024-01-18 17:57hgbotMerge Request Statusopen => approved
2024-01-18 18:04hgbotMerge Request Statusapproved => open
2024-01-24 18:13hgbotMerge Request Statusopen => approved
2024-01-24 18:13hgbotResolutionopen => fixed
2024-01-24 18:13hgbotStatusscheduled => closed
2024-01-24 18:13hgbotFixed in Version => PR24Q2
2024-01-24 18:13hgbotNote Added: 0159727
2024-01-24 18:13hgbotNote Added: 0159728
2024-01-24 18:13hgbotNote Added: 0159729
2024-01-24 18:13hgbotNote Added: 0159730

Notes
(0157961)
hgbot   
2023-12-05 12:06   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1065 [^]
(0158016)
hgbot   
2023-12-07 15:58   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/644 [^]
(0158946)
NaroaIriarte   
2024-01-08 15:53   
To test the main filters' behavior when the main filter sequence number is empty, some tests have been performed. The manual tests can be found in the next document.
It is important that the reviewer tries them too.
https://docs.google.com/document/d/1gODVBlwdPS0THmbW5vbhqkrI0bbnnA8hotpGCxnM79A/edit?usp=sharing [^]
(0159727)
hgbot   
2024-01-24 18:13   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: f486ee3cca476c83425aa7b993a01f7a1c83faf5
Author: Naroa Iriarte <naroa.iriarte@openbravo.com>
Date: 24-01-2024 17:13:31
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/f486ee3cca476c83425aa7b993a01f7a1c83faf5 [^]

fixed ISSUE-54068: New column added to the database and to the CRM tab to handle the sequences number of the main filters

---
A src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateCRMBPFilterConfiguration.class
A src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateCRMBPFilterConfigurationData.class
A src-util/modulescript/src/org/openbravo/modulescript/UpdateCRMBPFilterConfiguration.java
A src-util/modulescript/src/org/openbravo/modulescript/UpdateCRMBPFilterConfiguration_data.xsql
M src-db/database/model/tables/C_EXTBP_CONFIG_FILTER.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
---
(0159728)
hgbot   
2024-01-24 18:13   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1065 [^]
(0159729)
hgbot   
2024-01-24 18:13   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: f439595d4e24fc0b5601e43026694eb05890f6bb
Author: Naroa Iriarte <naroa.iriarte@openbravo.com>
Date: 24-01-2024 17:13:40
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/f439595d4e24fc0b5601e43026694eb05890f6bb [^]

Related to ISSUE-54068: Logic fixed so now tha sequence number for selector...

---
M web-test/integration/external-business-partner/ExternalBusinessPartnerListViewData.test.js
M web/org.openbravo.mobile.core/app/integration/external-business-partner/ExternalBusinessPartnerListViewData.js
---
(0159730)
hgbot   
2024-01-24 18:13   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/644 [^]