Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0054060POS2POSpublic2023-11-30 15:572023-12-22 13:07
Reporteradrianromero 
Assigned Toadrianromero 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0054060: Digital Coupons payment API support
DescriptionThe object of this development is to improve the Payment API in order to provide a new component to manage digital coupons. GIFI requires it to integrate with GlobalPOS

The component will allow us to show:

Introduced/Pending amount

Grid with added digital coupons and the ability to add/remove each digital coupon

Once the development is done. We will provide the technical documentation to GlobalPOS to implement their own middleware and create a connector with our standard Payment API
Steps To ReproduceN/A
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-11-30 15:57adrianromeroNew Issue
2023-11-30 15:57adrianromeroAssigned To => adrianromero
2023-11-30 15:57adrianromeroOBNetwork customer => No
2023-11-30 15:57adrianromeroTriggers an Emergency Pack => No
2023-11-30 17:59hgbotMerge Request Status => open
2023-11-30 17:59hgbotNote Added: 0157880
2023-12-18 18:40hgbotNote Added: 0158314
2023-12-18 18:40hgbotNote Added: 0158315
2023-12-18 18:41hgbotNote Added: 0158316
2023-12-18 18:41hgbotNote Added: 0158317
2023-12-18 18:46hgbotNote Added: 0158318
2023-12-19 12:36hgbotNote Added: 0158347
2023-12-21 08:58hgbotMerge Request Statusopen => approved
2023-12-22 13:07hgbotResolutionopen => fixed
2023-12-22 13:07hgbotStatusnew => closed
2023-12-22 13:07hgbotNote Added: 0158517
2023-12-22 13:07hgbotNote Added: 0158518
2023-12-22 13:07hgbotNote Added: 0158519
2023-12-22 13:07hgbotNote Added: 0158520
2023-12-22 13:07hgbotNote Added: 0158521
2023-12-22 13:07hgbotNote Added: 0158522
2023-12-22 13:07hgbotNote Added: 0158523
2023-12-22 13:07hgbotNote Added: 0158524
2023-12-22 13:07hgbotNote Added: 0158525
2023-12-22 13:07hgbotNote Added: 0158526
2023-12-22 13:07hgbotNote Added: 0158527

Notes
(0157880)
hgbot   
2023-11-30 17:59   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client/-/merge_requests/46 [^]
(0158314)
hgbot   
2023-12-18 18:40   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.payment/-/merge_requests/23 [^]
(0158315)
hgbot   
2023-12-18 18:40   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client/-/merge_requests/49 [^]
(0158316)
hgbot   
2023-12-18 18:41   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1312 [^]
(0158317)
hgbot   
2023-12-18 18:41   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2296 [^]
(0158318)
hgbot   
2023-12-18 18:46   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.poshwmanager.sources/-/merge_requests/100 [^]
(0158347)
hgbot   
2023-12-19 12:36   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client/-/merge_requests/46 [^]
(0158517)
hgbot   
2023-12-22 13:07   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.payment [^]
Changeset: c79f5d9f0b70c14198e317f3e541b3acf5be1b43
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 22-12-2023 13:05:54
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.payment/-/commit/c79f5d9f0b70c14198e317f3e541b3acf5be1b43 [^]

Fixes FR-54060: Implement DigitalCouponDialog component to handle digital coupon payments

It implements the component that is used in the integration for
DigitalCoupons.

---
A web-jspack/org.openbravo.events.payment/src/assets/icons/scanCoupon.svg
A web-jspack/org.openbravo.events.payment/src/components/DigitalCouponDialog/DigitalCouponColumns.config.json
A web-jspack/org.openbravo.events.payment/src/components/DigitalCouponDialog/DigitalCouponDeleteButton/DigitalCouponDeleteButton.jsx
A web-jspack/org.openbravo.events.payment/src/components/DigitalCouponDialog/DigitalCouponDeleteButton/DigitalCouponDeleteButton.scss
A web-jspack/org.openbravo.events.payment/src/components/DigitalCouponDialog/DigitalCouponDeleteButton/index.jsx
A web-jspack/org.openbravo.events.payment/src/components/DigitalCouponDialog/DigitalCouponDialog.jsx
A web-jspack/org.openbravo.events.payment/src/components/DigitalCouponDialog/DigitalCouponDialog.scss
A web-jspack/org.openbravo.events.payment/src/components/DigitalCouponDialog/DigitalCouponGrid.config.json
A web-jspack/org.openbravo.events.payment/src/components/DigitalCouponDialog/__test__/DigitalCouponDialog.test.jsx
A web-jspack/org.openbravo.events.payment/src/components/DigitalCouponDialog/index.jsx
M src-db/database/sourcedata/AD_MESSAGE.xml
M web-jspack/org.openbravo.events.payment/src/assets/style/iconography.scss
M web-jspack/org.openbravo.events.payment/src/ob-init.js
---
(0158519)
hgbot   
2023-12-22 13:07   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.poshwmanager.sources/-/merge_requests/100 [^]
(0158518)
hgbot   
2023-12-22 13:07   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.poshwmanager.sources [^]
Changeset: 107ff94476247900f2ac4cd1ea31dc63f529fb14
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 22-12-2023 13:06:51
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.poshwmanager.sources/-/commit/107ff94476247900f2ac4cd1ea31dc63f529fb14 [^]

Related to FR-54060: Extend the Simulator to support Digital Coupons

Two new flows might be tested through the PaymentDev simulator, by
having a total amount in the ticket of 5.01€ or 5.20€. These new flows
correspond to Digital Coupons.

The Simulator was also extended with a new type of message where it can
handle input of different types and allow responding in different ways
depending on the retrieved message from the client.

---
M project/src/com/openbravo/eventscommon/EventLibrary.java
M project/src/com/openbravo/eventscommon/EventProcess.java
M project/src/com/openbravo/eventscommon/Simulator.java
M project/src/com/openbravo/eventspayment/PaymentDev.java
---
(0158520)
hgbot   
2023-12-22 13:07   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.poshwmanager [^]
Changeset: 720f51249dbca0a878a86b0e12c1b188d535b03a
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 22-12-2023 13:00:44
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.poshwmanager/-/commit/720f51249dbca0a878a86b0e12c1b188d535b03a [^]

Related to FR-54060: Implement digital coupons in the Payments Simulator

---
M bin/poshw.jar
M bin/rev.id
---
(0158521)
hgbot   
2023-12-22 13:07   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.payment/-/merge_requests/23 [^]
(0158522)
hgbot   
2023-12-22 13:07   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client [^]
Changeset: f4a941ceb215887c607153b3ce68b5e9bff5b913
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 22-12-2023 13:05:04
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client/-/commit/f4a941ceb215887c607153b3ce68b5e9bff5b913 [^]

Related to FR-54060: Allow other dispositions of the MessageDataDisplay

---
M web-jspack/org.openbravo.events.client/src/components/MessagesDataDisplay.jsx
M web-jspack/org.openbravo.events.client/src/components/MessagesManager.jsx
---
(0158523)
hgbot   
2023-12-22 13:07   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client/-/merge_requests/49 [^]
(0158524)
hgbot   
2023-12-22 13:07   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 728bf1bf0d6cc7d7954173d18e01033d1f733ebf
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 22-12-2023 13:03:54
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/728bf1bf0d6cc7d7954173d18e01033d1f733ebf [^]

Related to FR-54060: Css incorrect in some parts of ConfirmPaymentProvider dialog

---
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/ConfirmProcessProvider.scss
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/DefaultProcessProvider.scss
---
(0158525)
hgbot   
2023-12-22 13:07   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2296 [^]
(0158526)
hgbot   
2023-12-22 13:07   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: bdeb090bf6300e8a5eb828b994ec774d9efe080d
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 21-12-2023 13:58:37
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/bdeb090bf6300e8a5eb828b994ec774d9efe080d [^]

Related to FR-54060: BarcodeScanner when initialized in other flows doesn't include options prop

Because of this, it was throwing an error when initialized in other
flows, we should null-check the property, as it is allowed for it to be
null.

---
M web-jspack/org.openbravo.core2/src/core/scan/device/BarcodeScanner.js
---
(0158527)
hgbot   
2023-12-22 13:07   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1312 [^]