Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0054057Retail ModulesWeb POSpublic2023-11-30 10:382024-01-03 16:10
Reporterigor_trebol 
Assigned Toigor_trebol 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0054057: VIP Price. Price adjustments per product.
DescriptionImplement Price adjustment functionality for web pos.

https://openbravo.atlassian.net/browse/RM-9782 [^]
Steps To ReproduceN/A
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on feature request 0054192 closed igor_trebol API Change: VIP Prices 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-11-30 10:38igor_trebolNew Issue
2023-11-30 10:38igor_trebolAssigned To => igor_trebol
2023-11-30 10:38igor_trebolTriggers an Emergency Pack => No
2023-12-05 09:16hgbotNote Added: 0157950
2023-12-07 11:01hgbotNote Added: 0158001
2023-12-07 11:06hgbotNote Added: 0158002
2023-12-12 13:41hgbotNote Added: 0158102
2023-12-14 14:42hgbotNote Added: 0158222
2023-12-15 10:29hgbotNote Added: 0158254
2023-12-18 10:42aferrazNote Deleted: 0158001
2023-12-18 10:42aferrazNote Deleted: 0157950
2023-12-19 08:31hgbotNote Added: 0158321
2023-12-19 12:31hgbotNote Added: 0158346
2023-12-19 12:58hgbotNote Added: 0158351
2023-12-19 14:48hgbotNote Added: 0158357
2023-12-21 09:23hgbotNote Added: 0158441
2023-12-21 09:38hgbotNote Added: 0158442
2023-12-21 09:41hgbotNote Added: 0158443
2023-12-28 13:54hgbotNote Added: 0158688
2023-12-28 13:57hgbotNote Added: 0158689
2024-01-02 13:16hgbotNote Added: 0158768
2024-01-03 13:11igor_trebolRelationship addeddepends on 0054192
2024-01-03 13:52hgbotResolutionopen => fixed
2024-01-03 13:52hgbotStatusnew => closed
2024-01-03 13:52hgbotNote Added: 0158802
2024-01-03 13:52hgbotNote Added: 0158803
2024-01-03 13:55hgbotNote Added: 0158805
2024-01-03 13:55hgbotNote Added: 0158806
2024-01-03 13:57hgbotNote Added: 0158807
2024-01-03 13:57hgbotNote Added: 0158808
2024-01-03 14:00hgbotFixed in Version => RR24Q1
2024-01-03 14:00hgbotNote Added: 0158809
2024-01-03 14:00hgbotNote Added: 0158810
2024-01-03 14:02hgbotNote Added: 0158811
2024-01-03 14:02hgbotNote Added: 0158812
2024-01-03 14:04hgbotNote Added: 0158813
2024-01-03 14:04hgbotNote Added: 0158814
2024-01-03 14:07hgbotNote Added: 0158815
2024-01-03 14:07hgbotNote Added: 0158816
2024-01-03 14:09hgbotNote Added: 0158819
2024-01-03 14:09hgbotNote Added: 0158820
2024-01-03 14:11hgbotNote Added: 0158821
2024-01-03 14:11hgbotNote Added: 0158822
2024-01-03 14:14hgbotFixed in VersionRR24Q1 => PR24Q1
2024-01-03 14:14hgbotNote Added: 0158823
2024-01-03 14:14hgbotNote Added: 0158824
2024-01-03 15:38hgbotNote Added: 0158825
2024-01-03 16:09hgbotNote Added: 0158828
2024-01-03 16:10hgbotNote Added: 0158829
2024-01-03 16:10hgbotNote Added: 0158830

Notes
(0158002)
hgbot   
2023-12-07 11:06   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1068 [^]
(0158102)
hgbot   
2023-12-12 13:41   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/130 [^]
(0158222)
hgbot   
2023-12-14 14:42   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.discounts.tests/-/merge_requests/7 [^]
(0158254)
hgbot   
2023-12-15 10:29   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1430 [^]
(0158321)
hgbot   
2023-12-19 08:31   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition/-/merge_requests/30 [^]
(0158346)
hgbot   
2023-12-19 12:31   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts/-/merge_requests/22 [^]
(0158351)
hgbot   
2023-12-19 12:58   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/41 [^]
(0158357)
hgbot   
2023-12-19 14:48   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice/-/merge_requests/9 [^]
(0158441)
hgbot   
2023-12-21 09:23   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/merge_requests/80 [^]
(0158442)
hgbot   
2023-12-21 09:38   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/114 [^]
(0158443)
hgbot   
2023-12-21 09:41   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/merge_requests/80 [^]
(0158688)
hgbot   
2023-12-28 13:54   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/41 [^]
(0158689)
hgbot   
2023-12-28 13:57   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice/-/merge_requests/9 [^]
(0158768)
hgbot   
2024-01-02 13:16   
Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/353 [^]
(0158802)
hgbot   
2024-01-03 13:52   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: 5cca6cea34f28d22b27fccc3291d8378188d2e33
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 03-01-2024 13:50:35
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/5cca6cea34f28d22b27fccc3291d8378188d2e33 [^]

FIXES FR-54057: Added VIP Prices functionality in discounts
MR: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/353 [^]

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I30542_BuyXPayYDiffProd_Lowest.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I30542_BuyXPayYDiffProd_MostExpensive.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I36520_VerifyDiscountWithAssortmentProducts.java
---
(0158803)
hgbot   
2024-01-03 13:52   
Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/353 [^]
(0158805)
hgbot   
2024-01-03 13:55   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts/-/merge_requests/22 [^]
(0158806)
hgbot   
2024-01-03 13:55   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts [^]
Changeset: 3bb0d4894ba044a27ebd5e4d8edc7a11e8edf71f
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 03-01-2024 13:53:21
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts/-/commit/3bb0d4894ba044a27ebd5e4d8edc7a11e8edf71f [^]

FIXES FR-54057: Added VIP Prices functionality in discounts
MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts/-/merge_requests/22 [^]

---
M src/org/openbravo/discounts/engine/DiscountJSExecutor.java
---
(0158807)
hgbot   
2024-01-03 13:57   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition [^]
Changeset: 3226fa7c494d5a800eb348c45b83cd563922c0bb
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 03-01-2024 13:56:37
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition/-/commit/3226fa7c494d5a800eb348c45b83cd563922c0bb [^]

FIXES FR-54057: Added VIP Prices functionality in discounts
MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition/-/merge_requests/30 [^]

---
M src-test/org/openbravo/discounts/propertycondition/DiscountPropertyConditionComparatorsTest.java
M src-test/org/openbravo/discounts/propertycondition/utils/CRMUtils.java
---
(0158808)
hgbot   
2024-01-03 13:57   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition/-/merge_requests/30 [^]
(0158809)
hgbot   
2024-01-03 14:00   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 1feac06002bb060d58e5e442a64ecbfab9ad7ba7
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 03-01-2024 13:59:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/1feac06002bb060d58e5e442a64ecbfab9ad7ba7 [^]

FIXES FR-54057: Added VIP Prices functionality in discounts
MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1430 [^]

---
M src/org/openbravo/retail/posterminal/master/DiscountFilterProductProperties.java
---
(0158810)
hgbot   
2024-01-03 14:00   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1430 [^]
(0158811)
hgbot   
2024-01-03 14:02   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.discounts.tests [^]
Changeset: bae13f043264497f3789ceb289f77c3619d0b19d
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 03-01-2024 14:01:02
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.discounts.tests/-/commit/bae13f043264497f3789ceb289f77c3619d0b19d [^]

FIXES FR-54057: Added VIP Prices functionality in discounts
MR: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.discounts.tests/-/merge_requests/7 [^]

---
M src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
---
(0158812)
hgbot   
2024-01-03 14:02   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.discounts.tests/-/merge_requests/7 [^]
(0158813)
hgbot   
2024-01-03 14:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 4cbfca3883de822d39544548eb3739a88f904374
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 03-01-2024 14:03:50
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/4cbfca3883de822d39544548eb3739a88f904374 [^]

FIXES FR-54057: Added VIP Prices functionality in discounts
MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/130/commits [^]

---
A src-test/org/openbravo/retail/discounts/test/unittests/DiscountPriceAdjustmentEachProductTest.java
M src-test/org/openbravo/retail/discounts/test/base/model/Product.java
M src-test/org/openbravo/retail/discounts/test/base/model/definition/PriceAdjustment.java
M src-test/org/openbravo/retail/discounts/test/integration/PriceAdjusmentAndBuyXGiftY.java
M src-test/org/openbravo/retail/discounts/test/integration/PriceAdjusmentAndBuyXPayYDifferentProducts.java
M src-test/org/openbravo/retail/discounts/test/integration/PriceAdjusmentAndBuyXPayYSameProducts.java
M src-test/org/openbravo/retail/discounts/test/integration/PriceAdjusmentAndUserDefinedAmount.java
M src-test/org/openbravo/retail/discounts/test/integration/PriceAdjustmentAndFixedPercentage.java
M src-test/org/openbravo/retail/discounts/test/unittests/DiscountPriceAdjusmentTest.java
M src-test/org/openbravo/retail/discounts/test/unittests/DiscountsUnitTestSuite.java
M src-test/org/openbravo/retail/discounts/test/unittests/combined/CheckDiscountByTotalTest.java
M src-test/org/openbravo/retail/discounts/test/unittests/combined/I32674_VerifyDiscountOnReloadTicket.java
M src-test/org/openbravo/retail/discounts/test/unittests/combined/I35082_PriceAdjusmentWithALineCandidateForPack.java
M src-test/org/openbravo/retail/discounts/test/unittests/combined/I35637_VerifyPriceAdjWithIsMultiple.java
M src-test/org/openbravo/retail/discounts/test/unittests/combined/I36520_VerifyDiscountWithAssortmentProducts.java
M src-test/org/openbravo/retail/discounts/test/unittests/combined/I47741_VerifyDiscountAfterQtyConsumed.java
M src-test/org/openbravo/retail/discounts/test/unittests/combined/ManualAfterAutomatic_DiscretionaryDiscountAfterAutomatic.java
M src-test/org/openbravo/retail/discounts/test/unittests/combined/ManualAfterAutomatic_DiscretionaryDiscountAfterAutomaticPercent.java
M src/org/openbravo/retail/discounts/event/MOfferEventHandler.java
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/discount-rules.js
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/price-adjustment-discount.js
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/interface/discount-posinterface.js
---
(0158814)
hgbot   
2024-01-03 14:04   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/130 [^]
(0158815)
hgbot   
2024-01-03 14:07   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/114 [^]
(0158816)
hgbot   
2024-01-03 14:07   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata [^]
Changeset: b3c46307d843b59ea40bb2caf643d2e743bd20b8
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 03-01-2024 14:06:41
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/commit/b3c46307d843b59ea40bb2caf643d2e743bd20b8 [^]

FIXES FR-54057: Added VIP Prices functionality in discounts
MR: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/114 [^]

---
M referencedata/sampledata/The_White_Valley_Group/M_OFFER.xml
M referencedata/sampledata/The_White_Valley_Group/M_OFFER_PRODUCT.xml
---
(0158819)
hgbot   
2024-01-03 14:09   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata [^]
Changeset: 9b4309f225400fe6c9c67824a442fcdc4e4dd0b3
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 03-01-2024 14:08:36
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/commit/9b4309f225400fe6c9c67824a442fcdc4e4dd0b3 [^]

FIXES FR-54057: Added VIP Prices functionality in discounts
MR: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/merge_requests/80 [^]

---
M referencedata/sampledata/Retail_Test/M_OFFER.xml
M referencedata/sampledata/Retail_Test/M_OFFER_PRODUCT.xml
---
(0158820)
hgbot   
2024-01-03 14:09   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/merge_requests/80 [^]
(0158821)
hgbot   
2024-01-03 14:11   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata [^]
Changeset: d9399c9038f2bc14eaeb3c6e8618e566415bcce7
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 03-01-2024 14:11:09
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/commit/d9399c9038f2bc14eaeb3c6e8618e566415bcce7 [^]

FIXES FR-54057: Added VIP Prices functionality in discounts
MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/merge_requests/80 [^]

---
M referencedata/sampledata/The_White_Valley_Group/M_OFFER.xml
M referencedata/sampledata/The_White_Valley_Group/M_OFFER_PRODUCT.xml
---
(0158822)
hgbot   
2024-01-03 14:11   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/merge_requests/80 [^]
(0158823)
hgbot   
2024-01-03 14:14   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 5a1c75c431aaa21912856d9aa968fc06ead57546
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 03-01-2024 14:13:01
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/5a1c75c431aaa21912856d9aa968fc06ead57546 [^]

FIXES FR-54057: Added VIP Prices functionality in discounts
MR: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1068 [^]

---
A src/org/openbravo/event/PriceAdjustmentProductEventHandler.java
M src-db/database/model/tables/M_OFFER.xml
M src-db/database/model/tables/M_OFFER_PRODUCT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/erpCommon/businessUtility/PriceAdjustment.java
M src/org/openbravo/event/PriceAdjustmentHandler.java
---
(0158824)
hgbot   
2024-01-03 14:14   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1068 [^]
(0158825)
hgbot   
2024-01-03 15:38   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1091 [^]
(0158828)
hgbot   
2024-01-03 16:09   
Repository: https://gitlab.com/openbravo/ci/backoffice-api [^]
Changeset: f787227bb46540b94910f374abb4f13b9266a284
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 03-01-2024 16:07:35
URL: https://gitlab.com/openbravo/ci/backoffice-api/-/commit/f787227bb46540b94910f374abb4f13b9266a284 [^]

Related to FR-54057: Added VIP Prices functionality in discounts
MR: https://gitlab.com/openbravo/ci/backoffice-api/-/merge_requests/58 [^]

---
M model/src-db/database/model/tables/M_OFFER.xml
M model/src-db/database/model/tables/M_OFFER_PRODUCT.xml
---
(0158829)
hgbot   
2024-01-03 16:10   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1091 [^]
(0158830)
hgbot   
2024-01-03 16:10   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: d6db68a1eedc3bf9e31358a6cfc85a2ef9cdb914
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 03-01-2024 15:38:52
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/d6db68a1eedc3bf9e31358a6cfc85a2ef9cdb914 [^]

Related to ISSUE-54057: Fixed dbconsistency problem

---
M src-db/database/model/tables/M_OFFER.xml
---