Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0054040POS2POSpublic2023-11-28 07:502023-12-29 14:57
Reporterranjith_qualiantech_com 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0054040: Implement Nominal Coupons for OTF Coupon Rules
DescriptionCoupons should be created with customer/crm details when Nominal Coupons is enabled in OTF Coupon Rules
Steps To ReproduceCheck Description
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0054380 closed ranjith_qualiantech_com Retail Modules [PROMO] OTF coupon with CRM : same behavior with Is nominal coupon =Y/N 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-11-28 07:50ranjith_qualiantech_comNew Issue
2023-11-28 07:50ranjith_qualiantech_comAssigned To => ranjith_qualiantech_com
2023-11-28 07:50ranjith_qualiantech_comOBNetwork customer => No
2023-11-28 07:50ranjith_qualiantech_comTriggers an Emergency Pack => No
2023-12-06 11:20ranjith_qualiantech_comStatusnew => scheduled
2023-12-07 06:59hgbotMerge Request Status => open
2023-12-07 06:59hgbotNote Added: 0157986
2023-12-14 12:12hgbotNote Added: 0158202
2023-12-14 17:07hgbotMerge Request Statusopen => approved
2023-12-14 17:55hgbotResolutionopen => fixed
2023-12-14 17:55hgbotStatusscheduled => closed
2023-12-14 17:55hgbotNote Added: 0158233
2023-12-14 17:55hgbotNote Added: 0158234
2023-12-14 17:55hgbotNote Added: 0158235
2023-12-14 17:55hgbotNote Added: 0158236
2023-12-29 06:41ranjith_qualiantech_comNote Added: 0158706
2023-12-29 06:41ranjith_qualiantech_comStatusclosed => new
2023-12-29 06:41ranjith_qualiantech_comResolutionfixed => open
2023-12-29 06:41ranjith_qualiantech_comStatusnew => scheduled
2023-12-29 13:11hgbotNote Added: 0158728
2023-12-29 14:57hgbotResolutionopen => fixed
2023-12-29 14:57hgbotStatusscheduled => closed
2023-12-29 14:57hgbotNote Added: 0158739
2023-12-29 14:57hgbotNote Added: 0158740
2024-01-29 05:55ranjith_qualiantech_comRelationship addedrelated to 0054380

Notes
(0157986)
hgbot   
2023-12-07 06:59   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/35 [^]
(0158202)
hgbot   
2023-12-14 12:12   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/112 [^]
(0158233)
hgbot   
2023-12-14 17:55   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf [^]
Changeset: a8ab6f92e2d9b4b7cd914d254debfbf748488711
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 13-12-2023 17:04:46
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/commit/a8ab6f92e2d9b4b7cd914d254debfbf748488711 [^]

Fixed ISSUE-54040: Added Nominal Coupon option in OTF Coupon rules
* When OTF coupon is generated, coupin will be associated with
  business partner if new flag "Is Nominal Coupon" is enabled

---
M src-db/database/model/tables/OBCPOTF_COUPONRULES.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src/org/openbravo/retail/discounts/coupons/otf/master/CouponrulesProperties.java
M web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/__test__/CreateCoupons.test.js
M web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/actions/utils/CreateCoupons.js
---
(0158234)
hgbot   
2023-12-14 17:55   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/35 [^]
(0158235)
hgbot   
2023-12-14 17:55   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/112 [^]
(0158236)
hgbot   
2023-12-14 17:55   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata [^]
Changeset: da7da6f54e7b171cfd1b1dfcf278d39fe06d34cc
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 14-12-2023 10:35:50
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/commit/da7da6f54e7b171cfd1b1dfcf278d39fe06d34cc [^]

Related to ISSUE-54040: Added sampledata for nominalcoupon column in OTF Rules

---
M referencedata/sampledata/The_White_Valley_Group/OBCPOTF_COUPONRULES.xml
---
(0158706)
ranjith_qualiantech_com   
2023-12-29 06:41   
Coupon should not be generated for anonymous customer
(0158728)
hgbot   
2023-12-29 13:11   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/40 [^]
(0158739)
hgbot   
2023-12-29 14:57   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf [^]
Changeset: 19be015c8cd8bb7f3c9426556ecdd00bff0a6c6a
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 29-12-2023 17:06:39
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/commit/19be015c8cd8bb7f3c9426556ecdd00bff0a6c6a [^]

Fixed ISSUE-54040: Coupons should not be generated for anonymous customer
* If Nominal coupon is configured for rule,
  then Coupon should be generated for anonymous customer

---
M web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/__test__/CreateCoupons.test.js
M web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/__test__/GetRulesApplyToTicket.test.js
M web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/actions/utils/CreateCoupons.js
M web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/actions/utils/GetCouponsThatApplyToTicket.js
---
(0158740)
hgbot   
2023-12-29 14:57   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/40 [^]