Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0054029Openbravo ERPA. Platformpublic2023-11-26 21:392023-12-15 08:32
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeveritycriticalReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0054029: Connection leak when using scheduling process requests based on process groups
DescriptionWhenever a process request based on a process group is scheduled, some database connections will be leaked
Steps To ReproduceIn any OB environment:
- Log in in the backoffice
- Open the Process Group window
- Create a process group (i.e. name it test, create two entries in the subtab, one for the Alert Process and another one for the Log Cleanup process)
- Check the number of non-idle connection by executing this query in the database: select count(*) from pg_stat_activity where state <> 'idle';
- Open the Process Request window
- Create a new process request, based on the group created earlier, by checking the Group flag and selecting the new group.
- Schedule the process request. Notice that each time that process request is scheduled, the number of non-idle database connection increases
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0053777 closed AugustoMauch Background grouping process is not working in HA 
related to defect 0054090 closed alostale connection leak on Tomcat start if a process is missfired 
causes defect 0054081 closed Triage Platform Base Regression: Number of database connection kept open in idle tomcat went up by +10 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-11-26 21:39AugustoMauchNew Issue
2023-11-26 21:39AugustoMauchAssigned To => AugustoMauch
2023-11-26 21:39AugustoMauchOBNetwork customer => No
2023-11-26 21:39AugustoMauchModules => Core
2023-11-26 21:39AugustoMauchTriggers an Emergency Pack => No
2023-11-26 21:39AugustoMauchStatusnew => scheduled
2023-11-26 21:40AugustoMauchRelationship addedrelated to 0053777
2023-11-30 08:05hgbotResolutionopen => fixed
2023-11-30 08:05hgbotStatusscheduled => resolved
2023-11-30 08:05hgbotFixed in Version => PR24Q1
2023-11-30 08:05hgbotNote Added: 0157829
2023-11-30 08:05AugustoMauchStatusresolved => closed
2023-11-30 08:05AugustoMauchFixed in VersionPR24Q1 =>
2023-12-11 09:25alostaleRelationship addedcauses 0054081
2023-12-11 09:58alostaleRelationship addedrelated to 0054090
2023-12-11 10:00hgbotMerge Request Status => open
2023-12-11 10:00hgbotNote Added: 0158031
2023-12-15 08:31hgbotMerge Request Statusopen => approved
2023-12-15 08:32hgbotNote Added: 0158247
2023-12-15 08:32hgbotNote Added: 0158250

Notes
(0157829)
hgbot   
2023-11-30 08:05   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 2432bd6c0d739d88b0068ae4dff44eff1846cef2
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 30-11-2023 07:05:17
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/2432bd6c0d739d88b0068ae4dff44eff1846cef2 [^]

Fixes ISSUE-54029: Connection is properly closed after scheduling grouped process

Now the connection used after a process has been executed is closed properly, by
using DalThreadCleaner.getInstance().cleanWithCommit();

---
M src/org/openbravo/scheduling/ProcessMonitor.java
---
(0158031)
hgbot   
2023-12-11 10:00   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1069 [^]
(0158247)
hgbot   
2023-12-15 08:32   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 53bf50ede6704f25851da724e1e8a9040b1b827c
Author: Asier Lostalé <asier.lostale@openbravo.com>
Date: 15-12-2023 07:31:39
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/53bf50ede6704f25851da724e1e8a9040b1b827c [^]

fixes BUG-54081: one DB connection leaked per each background thread

Each thread in charge of executing background processes leaked a DB connection
which was not returned to the pool on finalization. Commit 2432bd6c0d
(BUG-54029) prevents leaking connections handled by DAL, but it removed the code
in charge of returning non-DAL ConnectionProvider connections.

This code has now been recovered keeping also the one dealing with DAL
connections.

---
M src/org/openbravo/scheduling/ProcessMonitor.java
---
(0158250)
hgbot   
2023-12-15 08:32   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1069 [^]