Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0054016Retail ModulesRetail APIpublic2023-11-23 12:172023-12-07 13:06
Reporterjavietxe 
Assigned Toramprakash 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0054016: Wrong mapping in shipment lines
DescriptionEven for shipment lines the link with the bin is not mandatory nor in the database nor in the backoffice, in the API mapping is set as not nullable. So if it exists this type of records, the API fails.

The bin of the line is set automatically when selecting the product in the dropdown, but it can be deleted.
Steps To Reproduce- Create a Shipment with a shipment line without setting a bin to it (or deleting it if it's automatically set)
--- Go to "Goods Movements" window
--- Create a new record and save it [goodsshipments.jpg]
--- Create a line. Wen selecting a product the bin will be set automatically. Delete it by hand [shipmentline.jpg]
- Through postman, do this call setting the date of the Shipment created
https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/ws/org.openbravo.api.ExportService/ShipmentInOut/goodsReceiptByMovementDate?movementDate=2012-07-24&_page=1&_pageSize=5 [^] [^]

Check that even the response has a JSON and the response code is a 200, the JSON is not complete.

Check also that in the openbravo.logs it exists a stacktrace with the error. In this example:
ERROR org.openbravo.service.web.BaseWebServiceServlet - Value of property bin is null but it does not accept null values
org.openbravo.base.exception.OBException: Value of property bin is null but it does not accept null values
Proposed SolutionSet the field as "accepts null values" or change the column definition if it is really mandatory
Additional Information
TagsNo tags attached.
Relationships
related to defect 0054015 closed Triage Platform Conn Modules API failing but responding 200 
Attached Filespng mapping.png (12,654) 2023-11-23 12:17
https://issues.openbravo.com/file_download.php?file_id=19174&type=bug
png

png goodsshipments.png (102,446) 2023-11-27 11:51
https://issues.openbravo.com/file_download.php?file_id=19185&type=bug
png

png shipmentline.png (120,112) 2023-11-27 11:51
https://issues.openbravo.com/file_download.php?file_id=19186&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2023-11-23 12:17javietxeNew Issue
2023-11-23 12:17javietxeAssigned To => Triage Platform Conn
2023-11-23 12:17javietxeFile Added: mapping.png
2023-11-23 12:17javietxeTriggers an Emergency Pack => No
2023-11-23 12:18javietxeAssigned ToTriage Platform Conn => Triage Omni OMS
2023-11-23 12:24javietxeRelationship addedrelated to 0054015
2023-11-23 12:27javietxeDescription Updatedbug_revision_view_page.php?rev_id=27187#r27187
2023-11-23 12:27javietxeProposed Solution updated
2023-11-23 12:30javietxeSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=27191#r27191
2023-11-27 11:50javietxeSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=27199#r27199
2023-11-27 11:51javietxeFile Added: goodsshipments.png
2023-11-27 11:51javietxeFile Added: shipmentline.png
2023-11-28 08:55hgbotNote Added: 0157729
2023-12-05 09:50hgbotNote Added: 0157952
2023-12-07 12:54hgbotResolutionopen => fixed
2023-12-07 12:54hgbotStatusnew => resolved
2023-12-07 12:54hgbotNote Added: 0158008
2023-12-07 12:57aferrazReview Assigned To => aferraz
2023-12-07 12:57aferrazStatusresolved => closed
2023-12-07 13:06aferrazAssigned ToTriage Omni OMS => ramprakash

Notes
(0157729)
hgbot   
2023-11-28 08:55   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/217 [^]
(0157952)
hgbot   
2023-12-05 09:50   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/217 [^]
(0158008)
hgbot   
2023-12-07 12:54   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^]
Changeset: 4feab7901a81038ed3fc40a483f234b8240436b2
Author: Ram Prakash <ram.prakash@openbravo.com>
Date: 06-12-2023 12:52:37
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/4feab7901a81038ed3fc40a483f234b8240436b2 [^]

Fixes ISSUE-54016: Set the Field storageBin to accepts null values in GS Window

---
M src-db/database/sourcedata/OBEI_PROP_MAP_INSTANCE.xml
---