Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0054004Retail ModulesWeb POSpublic2023-11-22 15:552023-12-07 12:30
Reporterigor_trebol 
Assigned Toigor_trebol 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR24Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0054004: Crash when issuing products with services that change taxes
DescriptionBuy a product with a service attached that changes the tax of the product itself, making it a deposit (have a partial payment and not retrieving the products).

Issue Sales order for that order. The POS will crash when calculating the taxes for the items.

https://openbravo.atlassian.net/browse/RM-9202 [^]
Steps To ReproduceSee description and gif.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-11-22 15:55igor_trebolNew Issue
2023-11-22 15:55igor_trebolAssigned To => igor_trebol
2023-11-22 15:55igor_trebolOBNetwork customer => No
2023-11-22 15:55igor_trebolTriggers an Emergency Pack => No
2023-11-22 15:56igor_trebolStatusnew => scheduled
2023-11-22 15:56igor_trebolDescription Updatedbug_revision_view_page.php?rev_id=27171#r27171
2023-11-27 15:57hgbotMerge Request Status => open
2023-11-27 15:57hgbotNote Added: 0157694
2023-12-07 10:37hgbotMerge Request Statusopen => approved
2023-12-07 12:30hgbotResolutionopen => fixed
2023-12-07 12:30hgbotStatusscheduled => closed
2023-12-07 12:30hgbotFixed in Version => RR24Q1
2023-12-07 12:30hgbotNote Added: 0158006
2023-12-07 12:30hgbotNote Added: 0158007

Notes
(0157694)
hgbot   
2023-11-27 15:57   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1417 [^]
(0158006)
hgbot   
2023-12-07 12:30   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 30c3817ce823cb1313d1f0cb3d6d4e0956bb2ba3
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 07-12-2023 11:30:21
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/30c3817ce823cb1313d1f0cb3d6d4e0956bb2ba3 [^]

Fixes ISSUE-54004: Crash when issuing products with services that change taxes

- When issuing a product with a service that changes said products tax, with a BP that has the delivery mode set as 'After Delivery', POS crashed.
- This was because Services were not being accounted for in the invoices generated after issuing the products.
- The fix adds the service quantity to the invoice.

---
M web-test/model/business-object/ticket/CompleteTicketUtils-GenerateDelivery.test.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/CompleteTicketUtils.js
---
(0158007)
hgbot   
2023-12-07 12:30   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1417 [^]