Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0054003Retail ModulesWeb POSpublic2023-11-22 15:192023-12-14 10:02
Reporterigor_trebol 
Assigned Toigor_trebol 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR24Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0054003: Make deposit invoice taxes use line taxes instead of product ones
DescriptionWhen adding taxes to deposit item lines, force the taxes engine to apply the taxes on the line, not the ones in the product.
Steps To ReproduceN/A
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-11-22 15:19igor_trebolNew Issue
2023-11-22 15:19igor_trebolAssigned To => igor_trebol
2023-11-22 15:19igor_trebolTriggers an Emergency Pack => No
2023-11-22 15:19igor_trebolStatusnew => scheduled
2023-11-22 15:22hgbotNote Added: 0157491
2023-11-22 15:34hgbotNote Added: 0157492
2023-12-14 10:00hgbotResolutionopen => fixed
2023-12-14 10:00hgbotStatusscheduled => closed
2023-12-14 10:00hgbotFixed in Version => RR24Q1
2023-12-14 10:00hgbotNote Added: 0158189
2023-12-14 10:00hgbotNote Added: 0158190
2023-12-14 10:02hgbotNote Added: 0158192
2023-12-14 10:02hgbotNote Added: 0158193

Notes
(0157491)
hgbot   
2023-11-22 15:22   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.depositinvoice/-/merge_requests/40 [^]
(0157492)
hgbot   
2023-11-22 15:34   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1412 [^]
(0158189)
hgbot   
2023-12-14 10:00   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 68555e52955cfbe15168c40ee3e01824c8c526cd
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 13-12-2023 20:06:41
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/68555e52955cfbe15168c40ee3e01824c8c526cd [^]

Fixes ISSUE-54003: Deposit items taxes forced to use line taxes

- When calculating the taxes for a line we added the option to flag a
line to use the taxes that already are set in the line instead.

- Used for org.openbravo.retail.depositinvoice

---
M web/org.openbravo.retail.posterminal/app/model/business-logic/taxes-engine/engine/tax-rules.js
---
(0158190)
hgbot   
2023-12-14 10:00   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1412 [^]
(0158192)
hgbot   
2023-12-14 10:02   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.depositinvoice [^]
Changeset: e2a1f84966f8c8a5de4bce0247a4d25b4ddcbd6d
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 14-12-2023 09:02:03
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.depositinvoice/-/commit/e2a1f84966f8c8a5de4bce0247a4d25b4ddcbd6d [^]

Fixes ISSUE-54003: Deposit items taxes forced to use line taxes

- To force the deposit items to apply the taxes applied to the line instead of the ones for the product (as the deposit item does not have specific taxes) before this commit, they used the tax category of the product.

- This chang flags the line to make it apply the taxes of the line, obtained from the original product line.

---
M web-test/model/business-object/ticket/TicketUtils.test.js
M web/org.openbravo.retail.depositinvoice/app/model/business-object/ticket/TicketUtils.js
---
(0158193)
hgbot   
2023-12-14 10:02   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.depositinvoice/-/merge_requests/40 [^]