0053994: Updating the sources in a terminal may result in duplicated document numbers

Openbravo Issue Tracking System - POS2

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0053994

POS2

Core

public

2023-10-18 23:13

2023-11-22 17:11

Reporter

AugustoMauch

Assigned To

AugustoMauch

Priority

immediate

Severity

critical

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

23Q4.1

Fixed in Version

23Q4.1

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0053994: Updating the sources in a terminal may result in duplicated document numbers

Description

A terminal that was loaded a new version of the POS2 sources is likely to create ticket with duplicated numbers right after the update.

This happens because when sources are updated, the state of the application is reset (see [1] and [2]. Part of the reset state would have contained the document number sequences. If they are not available in the state, the POS will initialize them from the terminal. Since the terminal is not updated on every login but only right after each master data refresh, it could be that the document numbers read from the terminal are outdated, and as a consequence the POS would create tickets with duplicated document numbers.

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/registerServiceWorker.js#L71 [^]
[2] https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/blob/master/web/org.openbravo.mobile.core/app/model/application-state/StatePersistence.js#L361 [^]

Steps To Reproduce

- Open POS in livebuilds: https://livebuilds.openbravo.com/context/retail_pos2_pgsql/web/pos/?terminal=VBS-2 [^]
- Create a few tickets. Check their document number in the backoffice
- Logout in the POS
- Execute this in the debugger console to simulate a source upgrade, then refresh the browser and log in again: OB.UTIL.localStorage.removeItem('stateIsConsistentWithLocalStorage')
- Create some more tickets. Check in the backoffice that the latest tickets were created with document numbers that had already been used.

Proposed Solution

Additional Information