Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053985POS2POSpublic2023-11-21 11:592023-11-22 09:52
ReporterjavierRodriguez 
Assigned TojavierRodriguez 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053985: If a filter which is configured to be prefilter is filled, the application is always calling the master data to take BPs
DescriptionIf prefilters have been evaluated but they don't return any value, CRM is calling the master data to take values.
Steps To ReproduceWith loyalty module and loyalty card filter configured.

- Go to select a bp
- Fill only loyalty card input. Use 88888 (it should not exist any)
- Click on search

KO, all bp has been returned.
Proposed SolutionIf prefilters are evaluated but there is not any value, return empty array and avoid searching them in database.
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 0054012 closed sreehari POS2 Incorrect behavior when searching a customer by Member ID / Card Number 
related to defect 0054229 closed guilleaer Retail Modules Incorrect search results while filtering by Member ID / Loyalty Card Number 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-11-21 11:59javierRodriguezNew Issue
2023-11-21 11:59javierRodriguezAssigned To => javierRodriguez
2023-11-21 11:59javierRodriguezOBNetwork customer => No
2023-11-21 11:59javierRodriguezTriggers an Emergency Pack => No
2023-11-21 12:12hgbotMerge Request Status => open
2023-11-21 12:12hgbotNote Added: 0157413
2023-11-21 12:17hgbotNote Added: 0157414
2023-11-22 09:51hgbotMerge Request Statusopen => approved
2023-11-22 09:52hgbotResolutionopen => fixed
2023-11-22 09:52hgbotStatusnew => closed
2023-11-22 09:52hgbotNote Added: 0157455
2023-11-22 09:52hgbotFixed in Version => 24Q1
2023-11-22 09:52hgbotNote Added: 0157456
2023-11-22 09:52hgbotNote Added: 0157457
2023-11-22 09:52hgbotFixed in Version24Q1 => RR24Q1
2023-11-22 09:52hgbotNote Added: 0157458
2023-12-11 11:20guilleaerRelationship addedhas duplicate 0054012
2023-12-28 17:06ucarrionRelationship addedrelated to 0054229

Notes
(0157413)
hgbot   
2023-11-21 12:12   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/639 [^]
(0157414)
hgbot   
2023-11-21 12:17   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2251 [^]
(0157455)
hgbot   
2023-11-22 09:52   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2251 [^]
(0157456)
hgbot   
2023-11-22 09:52   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 8420c8e796df54d0c4a3fda8064c8ff91af90986
Author: Javier Rodríguez Regueiro <javier.rodriguez@openbravo.com>
Date: 22-11-2023 08:52:40
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/8420c8e796df54d0c4a3fda8064c8ff91af90986 [^]

Fixed ISSUE-53985: Do not search business partner if prefilters were evaluated without any result

---
M web-jspack/org.openbravo.pos2/src/services/crm/OBCRMUtils.js
M web-jspack/org.openbravo.pos2/src/services/crm/__test__/OBCRMUtils.test.js
---
(0157457)
hgbot   
2023-11-22 09:52   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/639 [^]
(0157458)
hgbot   
2023-11-22 09:52   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 27bfc43b039ad86b3218494afaac333273f1041a
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 21-11-2023 12:06:56
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/27bfc43b039ad86b3218494afaac333273f1041a [^]

Fixed ISSUE-53985: Include hasBeenEvaluated and hasPreFilterValues in obPreFilterGenerated filter

---
M web-test/integration/external-business-partner/ExternalBusinessPartnerAPI.test.js
M web/org.openbravo.mobile.core/app/integration/external-business-partner/ExternalBusinessPartnerAPI.js
---