Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053978POS2POSpublic2023-11-20 12:232023-12-12 11:23
Reporterifernandez 
Assigned Toifernandez 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053978: Refactor Fiscalization modules to match the Fiscal API requests
DescriptionThe fiscalization modules should respond to the Fiscal API requests with the same format that the rest of the modules, so some changes need to be done:

The default message for the response type are SUCCESS, ERROR, IGNORED and FAILURE. (FAILURE is for connection errors between components)

The errorCondition property shall be added (error Searchkey for ERROR)

additionalResponse: shall only be an array in the ERROR case, containing the message params, else ''.

messages: shall always be an array.

query: shall always be an array.

Any doubt, refer to https://docs.google.com/document/d/1uNYQmUbuAOyhkAaPW5M7ffc4kH9BS0tqIRXyfDRiEcM/edit [^]
Steps To ReproduceN/A.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on feature request 0053904 closed ifernandez Refacture Fiscal API completeTicket function to allow modifying popup title and ActionCancelled message 
related to defect 0054261 closed ucarrion [Assign Customer] - Error when using Assign Customer aside a Checkout action 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-11-20 12:23ifernandezNew Issue
2023-11-20 12:23ifernandezAssigned To => Retail
2023-11-20 12:23ifernandezOBNetwork customer => No
2023-11-20 12:23ifernandezTriggers an Emergency Pack => No
2023-11-20 12:23ifernandezAssigned ToRetail => ifernandez
2023-11-20 12:26hgbotMerge Request Status => open
2023-11-20 12:26hgbotNote Added: 0157342
2023-11-20 12:31hgbotNote Added: 0157343
2023-11-20 12:33hgbotNote Added: 0157344
2023-11-20 12:34hgbotNote Added: 0157345
2023-12-12 11:22aferrazRelationship addeddepends on 0053904
2023-12-12 11:22hgbotMerge Request Statusopen => approved
2023-12-12 11:23hgbotResolutionopen => fixed
2023-12-12 11:23hgbotStatusnew => closed
2023-12-12 11:23hgbotNote Added: 0158082
2023-12-12 11:23hgbotNote Added: 0158083
2023-12-12 11:23hgbotNote Added: 0158084
2023-12-12 11:23hgbotNote Added: 0158085
2023-12-12 11:23hgbotNote Added: 0158086
2023-12-12 11:23hgbotNote Added: 0158087
2023-12-12 11:23hgbotNote Added: 0158088
2023-12-12 11:23hgbotNote Added: 0158089
2024-01-08 09:11ucarrionRelationship addedrelated to 0054261

Notes
(0157342)
hgbot   
2023-11-20 12:26   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.belgium.securityamount/-/merge_requests/16 [^]
(0157343)
hgbot   
2023-11-20 12:31   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.france.fiscalization/-/merge_requests/3 [^]
(0157344)
hgbot   
2023-11-20 12:33   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.portugal.fiscalization/-/merge_requests/25 [^]
(0157345)
hgbot   
2023-11-20 12:34   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.spain.fiscalization/-/merge_requests/6 [^]
(0158082)
hgbot   
2023-12-12 11:23   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.belgium.securityamount [^]
Changeset: 15cae4d3672fc605c2f3d6a0ec0d77bb48f85dc7
Author: Íñigo Fernández <inigo.fernandez@openbravo.com>
Date: 12-12-2023 10:23:02
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.belgium.securityamount/-/commit/15cae4d3672fc605c2f3d6a0ec0d77bb48f85dc7 [^]

Fixes ISSUE-53978: Refactor Fiscalization modules to match the Fiscal API requests (Belgium)

---
M web/org.openbravo.localization.belgium.securityamount/app/model/business-object/localClientEventFlowHandler/LocalClientEventFlowHandlerForBelgium.js
---
(0158083)
hgbot   
2023-12-12 11:23   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.belgium.securityamount/-/merge_requests/16 [^]
(0158084)
hgbot   
2023-12-12 11:23   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.france.fiscalization [^]
Changeset: 66893e66956223eb42eec969c6e2f9a198172799
Author: Íñigo Fernández <inigo.fernandez@openbravo.com>
Date: 12-12-2023 10:23:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.france.fiscalization/-/commit/66893e66956223eb42eec969c6e2f9a198172799 [^]

Fixes ISSUE-53978: Refactor Fiscalization modules to match the Fiscal API requests (France)

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.localization.france.fiscalization/app/model/business-object/fiscalizationEventHandler/FRFISFiscalizationEventHandler.js
---
(0158085)
hgbot   
2023-12-12 11:23   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.france.fiscalization/-/merge_requests/3 [^]
(0158086)
hgbot   
2023-12-12 11:23   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.portugal.fiscalization [^]
Changeset: 1ebf94d39b18688f8570495818762453ad06bf57
Author: Íñigo Fernández <inigo.fernandez@openbravo.com>
Date: 12-12-2023 10:23:44
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.portugal.fiscalization/-/commit/1ebf94d39b18688f8570495818762453ad06bf57 [^]

Fixes ISSUE-53978: Refactor Fiscalization modules to match the Fiscal API requests (Portugal)

---
M web-test/Utils-isPortugueseTaxId.test.js
M web/org.openbravo.localization.portugal.fiscalization/source/events/PTFISFiscalizationEventHandler.js
---
(0158087)
hgbot   
2023-12-12 11:23   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.portugal.fiscalization/-/merge_requests/25 [^]
(0158088)
hgbot   
2023-12-12 11:23   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.spain.fiscalization [^]
Changeset: bbb6b56ada0a460a2f6e6fdfe59dbdf0eb87bbfc
Author: Íñigo Fernández <inigo.fernandez@openbravo.com>
Date: 12-12-2023 10:23:48
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.spain.fiscalization/-/commit/bbb6b56ada0a460a2f6e6fdfe59dbdf0eb87bbfc [^]

Fixes ISSUE-53978: Refactor Fiscalization modules to match the Fiscal API requests (Spain)

---
M web/org.openbravo.localization.spain.fiscalization/app/model/business-object/fiscalizationEventHandler/ESFISFiscalizationEventHandler.js
---
(0158089)
hgbot   
2023-12-12 11:23   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.spain.fiscalization/-/merge_requests/6 [^]