Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053951POS2POSpublic2023-11-16 06:342023-12-27 19:17
Reporterranjith_qualiantech_com 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053951: Implement product characteristics filter for Coupons OTF
DescriptionImplement product characteristics filter for Coupons OTF
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-11-16 06:34ranjith_qualiantech_comNew Issue
2023-11-16 06:34ranjith_qualiantech_comAssigned To => ranjith_qualiantech_com
2023-11-16 06:34ranjith_qualiantech_comOBNetwork customer => No
2023-11-16 06:34ranjith_qualiantech_comTriggers an Emergency Pack => No
2023-11-16 06:34ranjith_qualiantech_comStatusnew => scheduled
2023-12-05 09:25hgbotMerge Request Status => open
2023-12-05 09:25hgbotNote Added: 0157951
2023-12-14 14:52hgbotNote Added: 0158223
2023-12-14 15:17hgbotNote Added: 0158225
2023-12-19 10:55hgbotMerge Request Statusopen => approved
2023-12-19 10:57hgbotNote Added: 0158331
2023-12-19 10:57hgbotNote Added: 0158332
2023-12-19 10:57hgbotNote Added: 0158333
2023-12-19 10:57hgbotNote Added: 0158334
2023-12-19 10:57hgbotNote Added: 0158335
2023-12-19 10:57hgbotResolutionopen => fixed
2023-12-19 10:57hgbotStatusscheduled => closed
2023-12-19 10:57hgbotNote Added: 0158336
2023-12-19 10:57hgbotNote Added: 0158337
2023-12-27 09:59ranjith_qualiantech_comNote Added: 0158624
2023-12-27 09:59ranjith_qualiantech_comStatusclosed => new
2023-12-27 09:59ranjith_qualiantech_comResolutionfixed => open
2023-12-27 09:59ranjith_qualiantech_comStatusnew => scheduled
2023-12-27 18:21hgbotNote Added: 0158667
2023-12-27 19:17hgbotResolutionopen => fixed
2023-12-27 19:17hgbotStatusscheduled => closed
2023-12-27 19:17hgbotNote Added: 0158668
2023-12-27 19:17hgbotNote Added: 0158669

Notes
(0157951)
hgbot   
2023-12-05 09:25   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/34 [^]
(0158223)
hgbot   
2023-12-14 14:52   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/113 [^]
(0158225)
hgbot   
2023-12-14 15:17   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1078 [^]
(0158331)
hgbot   
2023-12-19 10:57   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: fc260d9aa52e503fe6914d873875681f5881eaca
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 19-12-2023 11:10:21
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/fc260d9aa52e503fe6914d873875681f5881eaca [^]

Related to ISSUE-53951: Added Help for Characteristics columns in Discount window
* Renamed field "Exclude Characteristics" to "Excluded Characteristics" in Discount window
* Renamed tab name from "Include Characteristics" to "Included Characteristics"
  and "Exclude Characteristics" to "Excluded Characteristics" in Discount window

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_TAB.xml
---
(0158332)
hgbot   
2023-12-19 10:57   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/113 [^]
(0158333)
hgbot   
2023-12-19 10:57   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1078 [^]
(0158334)
hgbot   
2023-12-19 10:57   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata [^]
Changeset: 7c55bd61fa7ef290389c7719dc6831b48ac912f4
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 14-12-2023 22:28:41
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/commit/7c55bd61fa7ef290389c7719dc6831b48ac912f4 [^]

Related to ISSUE-53951: Added sampledata for characteristics selection in OTF Rule window

---
M referencedata/sampledata/The_White_Valley_Group/OBCPOTF_COUPONRULES.xml
---
(0158335)
hgbot   
2023-12-19 10:57   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/34 [^]
(0158336)
hgbot   
2023-12-19 10:57   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf [^]
Changeset: f31aefa65533289681ec8dc8bd9877c5b2f55f95
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 19-12-2023 11:10:29
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/commit/f31aefa65533289681ec8dc8bd9877c5b2f55f95 [^]

Fixed ISSUE-53951: Added Characteristics tab for OTF Coupon Rules

---
A src-db/database/model/tables/OBCPOTF_COUPONRULES_CHAR.xml
A src/org/openbravo/retail/discounts/coupons/otf/master/CouponrulesChar.java
A src/org/openbravo/retail/discounts/coupons/otf/master/CouponrulesCharProperties.java
A web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/masterdata/OBCPOTFCouponrulesCharModel.js
M src-db/database/model/tables/OBCPOTF_COUPONRULES.xml
M src-db/database/sourcedata/AD_AUXILIARINPUT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_TAB.xml
M src-db/database/sourcedata/AD_TABLE.xml
M src/org/openbravo/retail/discounts/coupons/otf/master/CouponrulesProperties.java
M web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/__test__/GetRulesApplyToTicket.test.js
M web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/actions/utils/GetCouponsThatApplyToTicket.js
M web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/actions/utils/GetCouponsThatApplyToTicketDBHelper.js
M web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/masterdata/OBCPOTFCouponrulesBPCatModel.js
M web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/masterdata/OBCPOTFCouponrulesCRMConditionModel.js
M web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/masterdata/OBCPOTFCouponrulesOrgModel.js
M web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/masterdata/OBCPOTFCouponrulesProductCatModel.js
M web-jspack/org.openbravo.retail.discounts.coupons.otf/src/ob-init.js
---
(0158337)
hgbot   
2023-12-19 10:57   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf [^]
Changeset: b2883fb5dbff8afdc1b16fd09efd2ebc2544b691
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 19-12-2023 11:12:08
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/commit/b2883fb5dbff8afdc1b16fd09efd2ebc2544b691 [^]

Related to ISSUE-53951: Added Help for Characteristics columns in OTF Rules window

---
M src-db/database/model/tables/OBCPOTF_COUPONRULES_CHAR.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_TAB.xml
---
(0158624)
ranjith_qualiantech_com   
2023-12-27 09:59   
Field "Total Receipt Amount" was present in Discounts window. It should not be displayed, since logic behind is moved to coupons module.
(0158667)
hgbot   
2023-12-27 18:21   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/38 [^]
(0158668)
hgbot   
2023-12-27 19:17   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf [^]
Changeset: e6d1455f04d0e926b96a6e32ee8aa43f9c4e5ea4
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 27-12-2023 21:05:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/commit/e6d1455f04d0e926b96a6e32ee8aa43f9c4e5ea4 [^]

Fixed ISSUE-53951: Updated LinkToParentColumn for Characteristcs rule column
* Removed Total receipt amount field in Discount window as it is moved to coupons module

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
---
(0158669)
hgbot   
2023-12-27 19:17   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/38 [^]