Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053901POS2POSpublic2023-11-09 13:052023-11-30 13:09
Reporterranjith_qualiantech_com 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053901: Variable Amount Coupons should be moved to Coupons module
DescriptionVariable Amount Coupons should be moved to Coupons module.
'Total Receipt Amount' and 'Min Receipt Amount equal to Coupon Amount' should be validated in the coupon amount
Steps To Reproduce--
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0041170 closed umartirena Retail Modules It will be nice to be able to define Variable Amount Coupons to be used only when the ticket amount is greater than coupon amoun 
causes defect 0054075 closed ranjith_qualiantech_com Retail Modules coupon API couponAmount mapped on wrong Field 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-11-09 13:05ranjith_qualiantech_comNew Issue
2023-11-09 13:05ranjith_qualiantech_comAssigned To => ranjith_qualiantech_com
2023-11-09 13:05ranjith_qualiantech_comTriggers an Emergency Pack => No
2023-11-09 13:06ranjith_qualiantech_comStatusnew => scheduled
2023-11-13 17:06ranjith_qualiantech_comRelationship addedrelated to 0041170
2023-11-16 06:17hgbotNote Added: 0157183
2023-11-16 06:17hgbotNote Added: 0157184
2023-11-16 06:21hgbotNote Added: 0157185
2023-11-19 11:00hgbotNote Added: 0157305
2023-11-19 11:00hgbotNote Added: 0157306
2023-11-30 13:08hgbotNote Added: 0157849
2023-11-30 13:08hgbotNote Added: 0157850
2023-11-30 13:08hgbotNote Added: 0157851
2023-11-30 13:08hgbotNote Added: 0157852
2023-11-30 13:08hgbotNote Added: 0157853
2023-11-30 13:08hgbotNote Added: 0157854
2023-11-30 13:08hgbotNote Added: 0157855
2023-11-30 13:08hgbotNote Added: 0157856
2023-11-30 13:08hgbotNote Added: 0157857
2023-11-30 13:09hgbotResolutionopen => fixed
2023-11-30 13:09hgbotStatusscheduled => closed
2023-11-30 13:09hgbotNote Added: 0157858
2023-11-30 13:09hgbotNote Added: 0157859
2023-11-30 13:09hgbotNote Added: 0157860
2023-12-06 09:53ranjith_qualiantech_comRelationship addedcauses 0054075

Notes
(0157183)
hgbot   
2023-11-16 06:17   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/124 [^]
(0157184)
hgbot   
2023-11-16 06:17   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/30 [^]
(0157185)
hgbot   
2023-11-16 06:21   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/merge_requests/29 [^]
(0157305)
hgbot   
2023-11-19 11:00   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/merge_requests/76 [^]
(0157306)
hgbot   
2023-11-19 11:00   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/106 [^]
(0157849)
hgbot   
2023-11-30 13:08   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 412d4c2fa4b3ce2c4de98943a5babcfc9cc55f04
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 28-11-2023 17:58:10
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/412d4c2fa4b3ce2c4de98943a5babcfc9cc55f04 [^]

Related to ISSUE-53901: Renamed column Total Receipt to Total Receipt Amount

---
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
---
(0157850)
hgbot   
2023-11-30 13:08   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/124 [^]
(0157852)
hgbot   
2023-11-30 13:08   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf [^]
Changeset: 57c9d9d0e08962e62716a9c3ebbe4e6f34eac290
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 29-11-2023 16:20:38
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/commit/57c9d9d0e08962e62716a9c3ebbe4e6f34eac290 [^]

Related to ISSUE-53901: Updated module script for change in coupon amount column

---
M build/classes/org/openbravo/retail/discounts/coupons/otf/modulescript/FixDataIssue53901.class
M build/classes/org/openbravo/retail/discounts/coupons/otf/modulescript/FixDataIssue53901Data.class
M src-db/database/sourcedata/AD_FIELD.xml
M src-util/modulescript/src/org/openbravo/retail/discounts/coupons/otf/modulescript/FixDataIssue53901.java
M src-util/modulescript/src/org/openbravo/retail/discounts/coupons/otf/modulescript/FixDataIssue53901_Data.xsql
---
(0157853)
hgbot   
2023-11-30 13:08   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/30 [^]
(0157851)
hgbot   
2023-11-30 13:08   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf [^]
Changeset: 58e881c23d7a147f82697b542581cd8be1065960
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 29-11-2023 14:01:53
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/commit/58e881c23d7a147f82697b542581cd8be1065960 [^]

Related to ISSUE-53901: Moved VariableAmountCupons to Coupons modules
* Moved column data "Total Receipt" to discounts module
* Moved column data "Min. Receipt Amount" to coupons module

---
A build/classes/org/openbravo/retail/discounts/coupons/otf/modulescript/FixDataIssue53901.class
A build/classes/org/openbravo/retail/discounts/coupons/otf/modulescript/FixDataIssue53901Data.class
A src-util/modulescript/src/org/openbravo/retail/discounts/coupons/otf/modulescript/FixDataIssue53901.java
A src-util/modulescript/src/org/openbravo/retail/discounts/coupons/otf/modulescript/FixDataIssue53901_Data.xsql
A src/org/openbravo/retail/discounts/coupons/otf/process/GetDiscountInfo.java
A web/org.openbravo.retail.discounts.coupons.otf/js/events/discountCoupons.js
M src-db/database/model/modifiedTables/M_OFFER.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src/org/openbravo/retail/discounts/coupons/otf/OBCPOTFComponentProvider.java
M src/org/openbravo/retail/discounts/coupons/otf/OTFCouponAvailability.java
M src/org/openbravo/retail/discounts/coupons/otf/OrderLoaderHookOTFCoupons.java
M src/org/openbravo/retail/discounts/coupons/otf/hook/LoadCoupons.java
R src-db/database/sourcedata/M_OFFER_TYPE.xml
R src/org/openbravo/retail/discounts/coupons/otf/VariableAmountCouponDiscountEngineAppComponentProvider.java
R web/org.openbravo.retail.discounts.coupons.otf/app/model/business-logic/discounts-engine/engine/rules/variable-amount-coupons-discount.js
---
(0157854)
hgbot   
2023-11-30 13:08   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata [^]
Changeset: 3eb83b1f851a5874d502eec98e1e217adb6fd9c3
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 30-11-2023 05:12:57
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/commit/3eb83b1f851a5874d502eec98e1e217adb6fd9c3 [^]

Related to ISSUE-53901: Added Sampledata for new column in Coupon module

---
M referencedata/sampledata/Retail_Test/M_OFFER.xml
---
(0157855)
hgbot   
2023-11-30 13:08   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/merge_requests/76 [^]
(0157856)
hgbot   
2023-11-30 13:08   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata [^]
Changeset: 68c6be63af872df1b603d3f026b8d96ef5d0ca54
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 30-11-2023 05:12:59
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/commit/68c6be63af872df1b603d3f026b8d96ef5d0ca54 [^]

Related to ISSUE-53901: Added Sampledata for new column in Coupon module

---
M referencedata/sampledata/The_White_Valley_Group/M_OFFER.xml
---
(0157857)
hgbot   
2023-11-30 13:08   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/106 [^]
(0157858)
hgbot   
2023-11-30 13:09   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons [^]
Changeset: 89f54f7a17c0600197f185726fcead9ccd15befd
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 28-11-2023 17:58:14
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/commit/89f54f7a17c0600197f185726fcead9ccd15befd [^]

Fixed ISSUE-53901: Added "Variable Amount Coupons" Discount Type
* Added field "Min Receipt Amount equal to Coupon Amount" in Discount window

---
A src-db/database/sourcedata/M_OFFER_TYPE.xml
A src/org/openbravo/retail/discounts/coupons/event/OfferEventHandler.java
A web/org.openbravo.retail.discounts.coupons/app/model/business-logic/discounts-engine/engine/rules/variable-amount-coupons-discount.js
M src-db/database/model/modifiedTables/M_OFFER.xml
M src-db/database/model/tables/OBDISCP_COUPON.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/discounts/coupons/CouponAvailability.java
M src/org/openbravo/retail/discounts/coupons/CouponsComponentProvider.java
M src/org/openbravo/retail/discounts/coupons/GetCoupons.java
M web-jspack/org.openbravo.retail.discounts.coupons/src/components/CouponsPanelGrid/AvailableCouponsList/AvailableCouponsList.jsx
M web-jspack/org.openbravo.retail.discounts.coupons/src/components/CouponsPanelGrid/CouponsPanelGrid.jsx
---
(0157859)
hgbot   
2023-11-30 13:09   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons [^]
Changeset: b5dbb12e5d0b566a05ed7e084fd9e27fbb4f5755
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 29-11-2023 16:20:46
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/commit/b5dbb12e5d0b566a05ed7e084fd9e27fbb4f5755 [^]

Related to ISSUE-53901: Renamed amount column to couponamount in coupon table
* Added missing help and description in coupon fields
* Rearranged fields sequenceNo in Coupons tab to look same like "Discount Coupons" window

---
M src-db/database/model/tables/OBDISCP_COUPON.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M web-jspack/org.openbravo.retail.discounts.coupons/src/components/CouponsPanelGrid/CouponsPanelGrid.jsx
---
(0157860)
hgbot   
2023-11-30 13:09   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/merge_requests/29 [^]