Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053883POS2Corepublic2023-11-07 10:032023-11-20 15:40
ReporterAugustoMauch 
Assigned Togonzalo_fernandez 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version24Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053883: Add support for dynamic buttons in MultiTabBaseDialog components
DescriptionAfter discussion one of the first implementations of the base component implemented in [1], it was determined that it would be useful if the components displayed inside the popup can dynamically change the buttons displayed at dialog level.

See for instance in the attached image how the buttons in the dialog vary, even if the selected tab remains the same, depending on how the user interacted with the componented displayed in that step.

[1] https://issues.openbravo.com/view.php?id=53600 [^]
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on feature request 0053600 closed gonzalo_fernandez Implement base component to create dialogs tab-based components that can be included in dialogs: MultiTabBaseDialog 
Attached Filespng DynamicButtonsPopup.png (81,199) 2023-11-07 10:05
https://issues.openbravo.com/file_download.php?file_id=19135&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2023-11-07 10:03AugustoMauchNew Issue
2023-11-07 10:03AugustoMauchAssigned To => Triage Platform Base
2023-11-07 10:03AugustoMauchTriggers an Emergency Pack => No
2023-11-07 10:03AugustoMauchAssigned ToTriage Platform Base => gonzalo_fernandez
2023-11-07 10:03AugustoMauchStatusnew => scheduled
2023-11-07 10:05AugustoMauchFile Added: DynamicButtonsPopup.png
2023-11-07 10:05AugustoMauchRelationship addeddepends on 0053600
2023-11-07 11:50hgbotNote Added: 0156828
2023-11-20 15:39hgbotResolutionopen => fixed
2023-11-20 15:39hgbotStatusscheduled => closed
2023-11-20 15:39hgbotFixed in Version => 24Q1
2023-11-20 15:39hgbotNote Added: 0157353
2023-11-20 15:40hgbotNote Added: 0157354

Notes
(0156828)
hgbot   
2023-11-07 11:50   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1278 [^]
(0157353)
hgbot   
2023-11-20 15:39   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 8fb103d2ae65e49d8603b6e9ae254dedf2fbd74a
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 20-11-2023 15:39:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/8fb103d2ae65e49d8603b6e9ae254dedf2fbd74a [^]

Fixes ISSUE-53883: Adds support for dynamic buttons to MultiTabBaseDialog components

---
A web-jspack/org.openbravo.core2/src/components/MultiTabBaseDialog/MultiTabBaseDialogContext.jsx
A web-jspack/org.openbravo.core2/src/components/ResponsiveToolbar/__test__/ResponsiveToolbar.test.jsx
M web-jspack/org.openbravo.core2/src/components/BaseDialog/BaseDialog.jsx
M web-jspack/org.openbravo.core2/src/components/MultiTabBaseDialog/MultiTabBaseDialog.jsx
M web-jspack/org.openbravo.core2/src/components/MultiTabBaseDialog/__test__/MultiTabBaseDialog.test.jsx
M web-jspack/org.openbravo.core2/src/components/MultiTabBaseDialog/stories/MultiTabBaseDialog.stories.jsx
M web-jspack/org.openbravo.core2/src/components/MultiTabBaseDialog/stories/sampleMultiTabBaseDialog.config.json
M web-jspack/org.openbravo.core2/src/components/ResponsiveToolbar/ResponsiveToolbar.jsx
---
(0157354)
hgbot   
2023-11-20 15:40   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1278 [^]