Openbravo Issue Tracking System - Retail Modules
View Issue Details
0053872Retail ModulesDiscounts and Promotionspublic2023-11-06 16:452024-04-11 09:21
Lcazaux 
Rajesh_18 
normalmajoralways
closedfixed 
5
 
 
No
0053872: [Promos] - Deactivation of several records KO in some cases
It happens quite often that the discount percentage changes during the promotion. For this, a new button was developed which allow the activation or inactivation of several records at the same time in windows Commercial Operation and Discount&Promotions.

Currently, 2 subtabs are KO when using this button --> if some records are activated and we put them inactivated via this button, although they appear as "active = No" in the BO, in the POS the change is not taken into account.

These happens in:
1/ Commercial Operation, for the subtab "Product"
2/ In window Discount&Promo, for the subtab "Organization"

see videos

https://drive.google.com/file/d/1OFe2Lw3L3D0MEtrJF0ttyoOA11z5npWm/view?usp=sharing [^]

https://drive.google.com/file/d/1JyHColnzH_-nuKj58RzsFXwZsMkSje8x/view?usp=sharing [^]
1/ Create an opecom with price exceptions in subtab product
2/ Select some records with price exceptions and with the new button deactive them at the same time.
3/ Go to the POS, do a refresh
4/ See that the opecom still applies to the inactivated products

Same with Discount&promo:
1/ Create a promo with "only those defined" for filter "Organization" and add some organizations in the Organization subtab
2/ Select some records of the organizations in the subtab and with the new button deactive them at the same time.
3/ Go to the POS, do a refresh
4/ See that the promo still applies for elegible products for the Organization that are flagged as "Activate = N"
FASH
has duplicate defect 0055134 closed meriem_azaf Openbravo ERP It is possible to active more terminals that are allowed in the instance. 
Issue History
2023-11-06 16:45LcazauxNew Issue
2023-11-06 16:45LcazauxAssigned To => Retail
2023-11-06 16:45LcazauxTriggers an Emergency Pack => No
2023-11-06 16:45LcazauxTag Attached: FASH
2023-11-06 16:47LcazauxDescription Updatedbug_revision_view_page.php?rev_id=27091#r27091
2023-12-11 12:37Rajesh_18Assigned ToRetail => Rajesh_18
2023-12-11 12:37Rajesh_18Statusnew => scheduled
2023-12-19 10:02hgbotNote Added: 0158323
2023-12-19 10:04hgbotNote Added: 0158324
2024-01-10 14:44hgbotResolutionopen => fixed
2024-01-10 14:44hgbotStatusscheduled => closed
2024-01-10 14:44hgbotFixed in Version => PR24Q2
2024-01-10 14:44hgbotNote Added: 0159052
2024-01-10 14:44hgbotNote Added: 0159053
2024-01-10 14:44hgbotNote Added: 0159054
2024-01-10 14:44hgbotNote Added: 0159055
2024-04-11 09:18meriem_azafStatusclosed => new
2024-04-11 09:18meriem_azafResolutionfixed => open
2024-04-11 09:18meriem_azafFixed in VersionPR24Q2 =>
2024-04-11 09:20meriem_azafStatusnew => scheduled
2024-04-11 09:20meriem_azafStatusscheduled => resolved
2024-04-11 09:20meriem_azafResolutionopen => fixed
2024-04-11 09:21meriem_azafStatusresolved => closed
2024-04-11 10:48ngarciaRelationship addedhas duplicate 0055134

Notes
(0158323)
hgbot   
2023-12-19 10:02   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/merge_requests/64 [^]
(0158324)
hgbot   
2023-12-19 10:04   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1083 [^]
(0159052)
hgbot   
2024-01-10 14:44   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: ca43604951e4b318b53ced51a406cc7a31b9bd61
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 10-01-2024 13:21:35
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/ca43604951e4b318b53ced51a406cc7a31b9bd61 [^]

Fixed ISSUE-53872: Refactored to OBQuery to invoke event handlers

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/EnableOrDisableMultipleRecords.java
---
(0159053)
hgbot   
2024-01-10 14:44   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1083 [^]
(0159054)
hgbot   
2024-01-10 14:44   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations [^]
Changeset: 9d54c928156785ba9d26422f44ac7a20ce018b2a
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 10-01-2024 13:22:21
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/commit/9d54c928156785ba9d26422f44ac7a20ce018b2a [^]

Related to ISSUE-53872: Added event handler to prevent updation of commercial operation
* If Commericial Operation is validated updating active Field is prevented for commercial operation window and its child tab Included stores and product prices.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/commercialoperations/events/ValidatedCommercialOperationEventHandler.java
---
(0159055)
hgbot   
2024-01-10 14:44   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/merge_requests/64 [^]