Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0053863 | Retail Modules | Web POS | public | 2023-11-06 12:36 | 2024-01-22 10:51 |
|
| Reporter | ifernandez | |
| Assigned To | ifernandez | |
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0053863: Some tests fail without org.openbravo.test.mobile.sampledata |
| Description | CI run with:
merged.json
-= 'clone of white-valley'
+= retail.pack white-valley
https://builds.openbravo.com/view/modules/job/mod-simple/85390 [^]
How to re-run
mod-simple
build with params
paste that full json into REPO_REVISIONS
put /usr/lib/jvm/java-11-openjdk-amd64/ into JAVA_HOMe
=> Build
Note: => No email this way, but allows to run 'any json' without pushing it
My notes on (some not all) discount module errors:
merged
-= clone of WV (aka test.mobile.sampledata)
+= pack sampledata
junit of discount module fail
some with missing
[C_ExtBP_Config_Property#612BB567A0FB4A1FABF229F1A2254B66]
that gets shipped with
openbravo/ci/modules/org.openbravo.test.mobile.sampledata/referencedata/sampledata/The_White_Valley_Group/C_EXTBP_CONFIG_PROPERTY.xml
but also
openbravo/ci/modules/org.openbravo.retail.samplebpintegration/referencedata/standard/Sample_Integration_Configuration.xml
this IS PRESENT in this workspace
what about rest of those many junit?
all same?
or more?
also discounts.propertycondition => src-test/**/CRMUtils.java
uses that hardcoded id
also pos2 __mock__ uses that hardcoded id several times
Note:
that job run is still without pos2 (just 'normal sampledata' |
| Steps To Reproduce | N/A. |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | depends on | backport | 0054410 | RR24Q1 | closed | ifernandez | Some tests fail without org.openbravo.test.mobile.sampledata | | related to | defect | 0054298 | | closed | Bimla_vm | Some tests fail without org.openbravo.test.mobile.sampledata |
|
| Attached Files |  merged-shu1-4afe.json (61,115) 2023-11-06 12:36
https://issues.openbravo.com/file_download.php?file_id=19130&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2023-11-06 12:36 | ifernandez | New Issue | |
| 2023-11-06 12:36 | ifernandez | Assigned To | => ifernandez |
| 2023-11-06 12:36 | ifernandez | File Added: merged-shu1-4afe.json | |
| 2023-11-23 14:30 | hgbot | Note Added: 0157566 | |
| 2023-11-23 14:32 | hgbot | Note Added: 0157567 | |
| 2023-11-23 14:33 | hgbot | Note Added: 0157568 | |
| 2024-01-09 18:53 | aferraz | Project | Tools => Retail Modules |
| 2024-01-09 18:54 | aferraz | Triggers an Emergency Pack | => No |
| 2024-01-09 18:54 | aferraz | Category | Others => Web POS |
| 2024-01-10 16:36 | hgbot | Resolution | open => fixed |
| 2024-01-10 16:36 | hgbot | Status | new => closed |
| 2024-01-10 16:36 | hgbot | Fixed in Version | => RR24Q2 |
| 2024-01-10 16:36 | hgbot | Note Added: 0159066 | |
| 2024-01-10 16:36 | hgbot | Note Added: 0159067 | |
| 2024-01-10 16:36 | hgbot | Note Added: 0159068 | |
| 2024-01-10 16:36 | hgbot | Note Added: 0159069 | |
| 2024-01-10 16:36 | hgbot | Note Added: 0159070 | |
| 2024-01-10 16:36 | hgbot | Note Added: 0159071 | |
| 2024-01-10 16:47 | aferraz | Issue cloned | 0054298 |
| 2024-01-10 16:52 | aferraz | Relationship added | related to 0054298 |
| 2024-01-22 10:51 | aferraz | Status | closed => new |
| 2024-01-22 10:51 | aferraz | Resolution | fixed => open |
| 2024-01-22 10:51 | aferraz | Fixed in Version | RR24Q2 => |
| 2024-01-22 10:51 | aferraz | Status | new => scheduled |
| 2024-01-22 10:51 | aferraz | Status | scheduled => resolved |
| 2024-01-22 10:51 | aferraz | Resolution | open => fixed |
| 2024-01-22 10:51 | aferraz | Note Added: 0159576 | |
| 2024-01-22 10:51 | aferraz | Status | resolved => closed |
|
Notes |
|
|
(0157566)
|
|
hgbot
|
|
2023-11-23 14:30
|
|
|
|
|
(0157567)
|
|
hgbot
|
|
2023-11-23 14:32
|
|
|
|
|
(0157568)
|
|
hgbot
|
|
2023-11-23 14:33
|
|
|
|
|
(0159066)
|
|
hgbot
|
|
2024-01-10 16:36
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 063d2b3eb4b695dc79ad8723da95a7f69d029a3c
Author: Íñigo Fernández <inigo.fernandez@openbravo.com>
Date: 10-01-2024 15:36:18
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/063d2b3eb4b695dc79ad8723da95a7f69d029a3c [^]
Fixes ISSUE-53863: Some tests fail without org.openbravo.test.mobile.sampledata
---
M src-test/org/openbravo/retail/discounts/test/base/model/OfferCharacteristic.java
M src-test/org/openbravo/retail/discounts/test/base/model/Product.java
M src-test/org/openbravo/retail/discounts/test/base/model/ProductCharacteristic.java
M src-test/org/openbravo/retail/discounts/test/unittests/DiscountBuyAllXGiftAllYTest.java
M src-test/org/openbravo/retail/discounts/test/unittests/DiscountBuyAllXGiftAnyYTest.java
M src-test/org/openbravo/retail/discounts/test/unittests/DiscountBuyAnyXGiftAllYTest.java
M src-test/org/openbravo/retail/discounts/test/unittests/DiscountBuyAnyXGiftAnyYTest.java
M src-test/org/openbravo/retail/discounts/test/unittests/DiscountPriceAdjusmentTest.java
M src-test/org/openbravo/retail/discounts/test/unittests/combined/I32533_DiscountsByProductCharacteristic.java
M src-test/org/openbravo/retail/discounts/test/unittests/combined/I40666_VerifyTotalDiscountWithNonGroupedProductTest.java
M src-test/org/openbravo/retail/discounts/test/unittests/combined/I43502_DiscountsByProductCharacteristic.java
---
|
|
|
|
(0159067)
|
|
hgbot
|
|
2024-01-10 16:36
|
|
|
|
|
(0159068)
|
|
hgbot
|
|
2024-01-10 16:36
|
|
|
|
|
(0159069)
|
|
hgbot
|
|
2024-01-10 16:36
|
|
|
|
|
(0159070)
|
|
hgbot
|
|
2024-01-10 16:36
|
|
|
|
|
(0159071)
|
|
hgbot
|
|
2024-01-10 16:36
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^]
Changeset: 1c1011f6014981ee1f667a121bacf6a35d0c72ad
Author: Íñigo Fernández <inigo.fernandez@openbravo.com>
Date: 10-01-2024 15:36:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/1c1011f6014981ee1f667a121bacf6a35d0c72ad [^]
Fixes ISSUE-53863: Some tests fail without org.openbravo.test.mobile.sampledata
---
M src-test/org/openbravo/discounts/combo/test/unittests/CheckComboFixPriceDiscountsTest.java
M src-test/org/openbravo/discounts/combo/test/unittests/I34809_WrongCalculationOfComboDependingSequenceTest.java
M src-test/org/openbravo/discounts/combo/test/unittests/I35583_VerifyComboFixPriceTest.java
M src-test/org/openbravo/discounts/combo/test/unittests/I35583_VerifyComboFixPriceTest2.java
M src-test/org/openbravo/discounts/combo/test/unittests/I39513_VerifyMultiComboFixedPriceTest.java
M src-test/org/openbravo/discounts/combo/test/unittests/I39831_VerifyComboFixedPriceDiscountAppliedToProductWithSamePriceTest.java
M src-test/org/openbravo/discounts/combo/test/unittests/I40197_ComboApplyDiscountByHoursTest.java
---
|
|
|
|
|
|
Reopened to create backport for 24Q1 0054410 and closed again. |
|