Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053821POS2Corepublic2023-10-31 15:512023-11-20 11:27
Reportercaristu 
Assigned ToTriage Platform Base 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version24Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053821: Rename reasons infrastructure API to not use reasons but inputs in the names
DescriptionWith feature requests 0053576 the reasons concept has been refactored into the concept of user inputs. We need to adapt some names in the public API of the infrastructure in charge of managing reasons (now inputs) in order to not refer to reasons anymore. We need to:

1) Deprecate "public" methods referencing to reasons
2) Create new "public" methods using inputs instead of reasons and replace the usage of the deprecated methods with the new ones
3) Replace internal references to not mention reasons but inputs
Steps To Reproduce.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on feature request 0053576 closed Triage Platform Base User Action Inputs improvements 
causes defect 0054536 closed Triage Platform Base Wrong icon is displayed for return reasons 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-10-31 15:51caristuNew Issue
2023-10-31 15:51caristuAssigned To => Triage Platform Base
2023-10-31 15:51caristuTriggers an Emergency Pack => No
2023-10-31 15:51caristuIssue generated from0053576
2023-10-31 15:51caristuRelationship addedrelated to 0053576
2023-10-31 15:58caristuRelationship deletedrelated to 0053576
2023-10-31 15:58caristuRelationship addeddepends on 0053576
2023-10-31 16:35meriem_azafStatusnew => scheduled
2023-10-31 16:59hgbotNote Added: 0156562
2023-10-31 17:05hgbotNote Added: 0156563
2023-10-31 17:24hgbotNote Added: 0156571
2023-10-31 17:27hgbotNote Added: 0156573
2023-10-31 17:34hgbotNote Added: 0156576
2023-10-31 17:41hgbotNote Added: 0156577
2023-10-31 17:47hgbotNote Added: 0156578
2023-11-13 10:51hgbotNote Added: 0157077
2023-11-13 10:53hgbotNote Added: 0157078
2023-11-13 10:54hgbotNote Added: 0157079
2023-11-13 10:55hgbotNote Added: 0157080
2023-11-13 10:55hgbotNote Added: 0157081
2023-11-13 10:56hgbotNote Added: 0157082
2023-11-13 10:56hgbotNote Added: 0157083
2023-11-13 10:57hgbotNote Added: 0157084
2023-11-13 10:57hgbotNote Added: 0157085
2023-11-13 11:00hgbotNote Added: 0157086
2023-11-13 11:00hgbotNote Added: 0157087
2023-11-13 11:02hgbotResolutionopen => fixed
2023-11-13 11:02hgbotStatusscheduled => closed
2023-11-13 11:02hgbotNote Added: 0157088
2023-11-13 11:02hgbotFixed in Version => 24Q1
2023-11-13 11:02hgbotNote Added: 0157089
2023-11-20 11:27hgbotNote Added: 0157336
2024-02-01 07:26caristuRelationship addedcauses 0054536

Notes
(0156562)
hgbot   
2023-10-31 16:59   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1271 [^]
(0156563)
hgbot   
2023-10-31 17:05   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2214 [^]
(0156571)
hgbot   
2023-10-31 17:24   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client/-/merge_requests/41 [^]
(0156573)
hgbot   
2023-10-31 17:27   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.taxfree/-/merge_requests/20 [^]
(0156576)
hgbot   
2023-10-31 17:34   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/258 [^]
(0156577)
hgbot   
2023-10-31 17:41   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.asyncpayprovider/-/merge_requests/25 [^]
(0156578)
hgbot   
2023-10-31 17:47   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1401 [^]
(0157077)
hgbot   
2023-11-13 10:51   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1401 [^]
(0157078)
hgbot   
2023-11-13 10:53   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.asyncpayprovider [^]
Changeset: 7253fa5bd0c96746ba722d4703960739af6339b4
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 13-11-2023 10:52:04
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.asyncpayprovider/-/commit/7253fa5bd0c96746ba722d4703960739af6339b4 [^]

Related to ISSUE-53821: Update components to use new User Input API

---
M web-jspack/org.openbravo.retail.asyncpayprovider/src/components/PaymentIntegration/MessagesManager.jsx
---
(0157079)
hgbot   
2023-11-13 10:54   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.asyncpayprovider/-/merge_requests/25 [^]
(0157080)
hgbot   
2023-11-13 10:55   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/258 [^]
(0157081)
hgbot   
2023-11-13 10:55   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^]
Changeset: b671a0c44db7c3cea689209efa96305a66662400
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 13-11-2023 10:54:54
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/b671a0c44db7c3cea689209efa96305a66662400 [^]

Related to ISSUE-53821: Update components to use new User Input API

---
M web-jspack/org.openbravo.pos2.restaurant/src/components/TicketMenuLine/__test__/TicketMenuLine.test.jsx
M web-jspack/org.openbravo.pos2.restaurant/src/components/TicketMenuLine/stories/TicketMenuLine.stories.jsx
M web-jspack/org.openbravo.pos2.restaurant/src/model/user-interface/user-actions/SetLineNote.js
---
(0157082)
hgbot   
2023-11-13 10:56   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.taxfree [^]
Changeset: 2d64674d9bf719749896aecb1fd83a0a3aa58ad9
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 13-11-2023 10:55:40
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.taxfree/-/commit/2d64674d9bf719749896aecb1fd83a0a3aa58ad9 [^]

Related to ISSUE-53821: Update components to use new User Input API

---
M web-jspack/org.openbravo.events.taxfree/src/model/returns/__test__/VerifyReturnsExtension.test.js
---
(0157083)
hgbot   
2023-11-13 10:56   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.taxfree/-/merge_requests/20 [^]
(0157084)
hgbot   
2023-11-13 10:57   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client [^]
Changeset: 724dc225547a66a9e6d76276a79c5b8d71687e27
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 13-11-2023 10:56:54
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client/-/commit/724dc225547a66a9e6d76276a79c5b8d71687e27 [^]

Related to ISSUE-53821: Update components to use new User Input API

---
M web-jspack/org.openbravo.events.client/src/components/MessagesManager.jsx
---
(0157085)
hgbot   
2023-11-13 10:57   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client/-/merge_requests/41 [^]
(0157086)
hgbot   
2023-11-13 11:00   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 6f86fed7c24056222b56a51bba32920273a6530e
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 13-11-2023 11:00:03
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/6f86fed7c24056222b56a51bba32920273a6530e [^]

Related to ISSUE-53821: Update components to use new User Input API

---
A web-jspack/org.openbravo.pos2/src/assets/icons/return-input.svg
A web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePopover/SetLineReturnInputsButton.jsx
A web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePopover/__test__/SetLineReturnInputsButton.test.jsx
A web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLineReturnInput.scss
A web-jspack/org.openbravo.pos2/src/model/ticket/actions/CleanLineInputsAndApprovals.js
A web-jspack/org.openbravo.pos2/src/model/ticket/actions/__test__/CleanLineInputsAndApprovals.test.js
A web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/SetLineReturnInputs.js
A web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/__test__/SetLineReturnInputs.test.js
M src-db/database/sourcedata/AD_MESSAGE.xml
M web-jspack/org.openbravo.pos2/src/assets/style/iconography.scss
M web-jspack/org.openbravo.pos2/src/components/ProofOfPayment/ProofOfPaymentDetails/ProofOfPaymentDetailLine/__test__/ProofOfPaymentDetailLine.test.jsx
M web-jspack/org.openbravo.pos2/src/components/ProofOfPayment/ProofOfPaymentDetails/__test__/ProofOfPaymentDetails.test.jsx
M web-jspack/org.openbravo.pos2/src/components/SelectLines/SelectedLinesGrid/__test__/SelectLines.test.jsx
M web-jspack/org.openbravo.pos2/src/components/SelectLines/SelectedLinesGrid/stories/SelectLines.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketArea/__test__/TicketArea.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketArea/stories/TicketArea.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePopover/TicketLinePopover.config.json
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePopover/__test__/TicketLinePopover.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLine.config.json
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLineReturnInputs.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/__test__/TicketLineReturnInputs.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/__test__/TicketLines.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/__test__/TicketLinesHeader.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/stories/TicketLines.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketPopover/TicketPopover.config.json
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketPopover/__test__/TicketPopover.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketPopover/stories/TicketPopover.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/TicketLineRenderCell/__test__/TicketLineRenderCell.test.jsx
M web-jspack/org.openbravo.pos2/src/components/VerifiedReturns/VerifiedReturnsGrid/TicketLineRenderCellWrapper/__test__/TicketLineRenderCellWrapper.test.jsx
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketExtension.js
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketUtils.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AddServiceProduct.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/CancelPayment.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/DeleteLine.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/EditPrepaymentAmount.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/ReturnLine.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/SellOnCredit.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/SetNoteToLine.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/SplitLines.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/TicketLineUserAction.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/__test__/TicketLineUserAction.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/discounts/AddByTotalPromotionIntoTicket.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/discounts/FeaturedDiscountsApplyAndNext.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/discounts/SetLineDiscounts.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/discounts/__test__/SetLineDiscountsUserAction.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/FinishInitialCount.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/CashManagementNewMovement.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/__test__/CashManagementNewMovement.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/cashup/FinishInitialCount.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/cashup/ValidateCountAndAdvance.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/cashup/__test__/ValidateCountAndAdvance.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/initialCount/SynchronizeStandardInitialCount.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/initialCount/__test__/SynchronizeStandardInitialCount.test.js
M web-jspack/org.openbravo.pos2/src/ob-init.js
---
(0157087)
hgbot   
2023-11-13 11:00   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2214 [^]
(0157088)
hgbot   
2023-11-13 11:02   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1271 [^]
(0157089)
hgbot   
2023-11-13 11:02   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 0fea7423aa321bcbbdc91e0d3cc36c033080e672
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 13-11-2023 11:01:41
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/0fea7423aa321bcbbdc91e0d3cc36c033080e672 [^]

Fixed ISSUE-53821: Update components to use new User Input API

---
A web-jspack/org.openbravo.core2/src/components/InputAndApprovalDialog/InputAndApprovalDialog.scss
A web-jspack/org.openbravo.core2/src/components/InputAndApprovalDialog/InputAndApprovalFormHandler.js
A web-jspack/org.openbravo.core2/src/components/InputAndApprovalDialog/__test__/InputAndApprovalDialog.test.jsx
A web-jspack/org.openbravo.core2/src/components/InputAndApprovalDialog/__test__/InputAndApprovalFormHandler.test.js
A web-jspack/org.openbravo.core2/src/components/InputAndApprovalDialog/stories/InputAndApprovalDialog.stories.jsx
A web-jspack/org.openbravo.core2/src/components/InputAndApprovalDialog/stories/InputAndApprovalDialog.stories.scss
A web-jspack/org.openbravo.core2/src/components/InputAndApprovalDialog/stories/MessageComponent.jsx
A web-jspack/org.openbravo.core2/src/components/InputAndApprovalDialog/stories/MessageComponent.scss
A web-jspack/org.openbravo.core2/src/core/security/requestInputAndApproval.js
M src/org/openbravo/core2/master/UserActionInput.java
M src/org/openbravo/core2/master/UserInput.java
M src/org/openbravo/core2/master/UserInputValue.java
M src/org/openbravo/core2/window/UserActionInputSeqNoCallout.java
M web-jspack/org.openbravo.core2/src/core/Registry.js
M web-jspack/org.openbravo.core2/src/core/terminal/Security.js
M web-jspack/org.openbravo.core2/src/core/user-action/UserAction.js
M web-jspack/org.openbravo.core2/src/core/user-action/__mock__/UserActionFence.js
M web-jspack/org.openbravo.core2/src/core/user-action/__mock__/mockWindowFlowSwitchAction.js
M web-jspack/org.openbravo.core2/src/core/user-action/__mock__/mockWindowSwitchAction.js
M web-jspack/org.openbravo.core2/src/core/user-action/__test__/UserAction.test.js
---
(0157336)
hgbot   
2023-11-20 11:27   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 023ee4554ce06a373f65ac1d6b89d3c6f8887837
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 20-11-2023 11:26:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/023ee4554ce06a373f65ac1d6b89d3c6f8887837 [^]

related to FR-53821: getReasonItems -> getInputItems

---
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/ReturnBlindTicket.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/ReturnVerifiedTicket.js
---