Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053816ModulesExternal Data Integrationpublic2023-10-31 13:322023-11-13 08:35
Reportermalsasua 
Assigned Tocaristu 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Regression date
Regression introduced by commit
Regression level
Review Assigned Tocberner
Support ticket77193
OBNetwork customerGold
Regression introduced in release
Summary0053816: EDL process is duplicating request lines
DescriptionIn EDL process, when there are several item ids by line, the process of one item raises an error, and after that, the export of the items raise another error, the first item ID is added in a new request line, but it is not removed from the original request line.
Steps To Reproduce. install edl example module:
https://gitlab.com/openbravo/demo/org.openbravo.externaldata.integration.examples [^]

. apply patch1 (attached) to force errors in some lines in the Import UOM Asynchronously process: it forces a processing error in one individual item and a general error when executing the OutputDataProcessor.
. execute Import UOM Asynchronously process. The generated EDL request have:
--> One line in error with the item whose processing failed. This is correct.
--> Another line in error (because the OutputDataProcessor failed) with the correctly processed items plus the item whose processing failed. This is wrong, the item whose processing failed should not be present in this line
Proposed Solutionattached possible fix (patch2)
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0052614 closed cberner Openbravo ERP There should be a mechanism to have non-blocking async EDL Requests 
depends on backport 0053908 closed caristu Modules EDL process is duplicating request lines 
Attached Filesdiff patch1.diff (2,192) 2023-11-07 09:01
https://issues.openbravo.com/file_download.php?file_id=19133&type=bug
diff patch2.diff (3,716) 2023-11-07 17:37
https://issues.openbravo.com/file_download.php?file_id=19139&type=bug
Issue History
Date ModifiedUsernameFieldChange
2023-10-31 13:32malsasuaNew Issue
2023-10-31 13:32malsasuaAssigned To => Triage Platform Base
2023-10-31 13:32malsasuaOBNetwork customer => Gold
2023-10-31 13:32malsasuaModules => Core
2023-10-31 13:32malsasuaSupport ticket => 77193
2023-10-31 13:32malsasuaTriggers an Emergency Pack => No
2023-10-31 13:33malsasuaFile Added: patch1.diff
2023-10-31 13:33malsasuaFile Added: patch2.diff
2023-10-31 13:34malsasuaAssigned ToTriage Platform Base => caristu
2023-11-07 08:57caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=27093#r27093
2023-11-07 09:00caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=27094#r27094
2023-11-07 09:00caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=27095#r27095
2023-11-07 09:00caristuFile Deleted: patch1.diff
2023-11-07 09:01caristuFile Added: patch1.diff
2023-11-07 09:01caristuFile Deleted: patch1.diff
2023-11-07 09:01caristuFile Added: patch1.diff
2023-11-07 17:20hgbotMerge Request Status => open
2023-11-07 17:20hgbotNote Added: 0156878
2023-11-07 17:37caristuFile Deleted: patch2.diff
2023-11-07 17:37caristuFile Added: patch2.diff
2023-11-10 08:42caristuProjectOpenbravo ERP => Modules
2023-11-10 08:42caristuCategoryA. Platform => External Data Integration
2023-11-10 08:48caristuProjectModules => Openbravo ERP
2023-11-10 08:49caristuStatusnew => scheduled
2023-11-10 08:49caristuProjectOpenbravo ERP => Modules
2023-11-10 09:11caristuRelationship addedrelated to 0052614
2023-11-10 09:13caristuNote Added: 0157011
2023-11-10 09:13caristuRelationship deletedrelated to 0052614
2023-11-10 09:14caristuRelationship addedrelated to 0052614
2023-11-10 13:06hgbotMerge Request Statusopen => approved
2023-11-13 08:33hgbotNote Added: 0157057
2023-11-13 08:33hgbotNote Added: 0157058
2023-11-13 08:33hgbotNote Added: 0157059
2023-11-13 08:35caristuStatusscheduled => resolved
2023-11-13 08:35caristuResolutionopen => fixed
2023-11-13 08:35caristuReview Assigned To => cberner
2023-11-13 08:35caristuStatusresolved => closed

Notes
(0156878)
hgbot   
2023-11-07 17:20   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/merge_requests/35 [^]
(0157011)
caristu   
2023-11-10 09:13   
Note that the fix contains two commits:

1- One commit to fix some parts of the error management that were not working in the same way as it was before the changes introduced with 0052614. This is the part that can be considered a regression.

2- The specific fix for the issue, which is not a regression but we think it is worth to backport it (it is not very risky) to have it also fixed in 23Q4 release.
(0157057)
hgbot   
2023-11-13 08:33   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration [^]
Changeset: 7843a987cc27904cdf998ca386f074e265011cc1
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 07-11-2023 17:18:03
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/commit/7843a987cc27904cdf998ca386f074e265011cc1 [^]

related to BUG-53816: improve request line process error management

---
M src/org/openbravo/externaldata/integration/process/ProcessRequest.java
---
(0157058)
hgbot   
2023-11-13 08:33   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration [^]
Changeset: 9a4b612edb532d8b4717f65fa1864c68b62fa536
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 07-11-2023 17:26:35
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/commit/9a4b612edb532d8b4717f65fa1864c68b62fa536 [^]

related to BUG-53816: duplicated error items that may appear in different error lines

---
M src/org/openbravo/externaldata/integration/process/ProcessRequest.java
---
(0157059)
hgbot   
2023-11-13 08:33   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/merge_requests/35 [^]