Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0005381Openbravo ERP01. General setuppublic2008-10-02 10:392009-04-21 11:07
Reporterrafaroda 
Assigned ToHennadzi 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionUbuntu 7.10
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0005381: C_CURRENCY_CONVERT uses inactive conversion rates
DescriptionC_CURRENCY_CONVERT function uses inactive conversion rates for converting from one currency to another.
Steps To Reproduce1) Set up a new conversion rate for one currency to the system currency in 'General Setup || Application || Conversion Rates'.
2) Mark it as NOT active.
3) Create a new expense sheet in 'Project & Service Management || Transactions || Expense Sheet'.
4) Create a new expense line in a currency different from the system currency.

Notice that the conversion is done (converted amount is field is filled) even if the conversion is inactive.
Proposed SolutionPatch attached for C_CURRENCY_RATE database function.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0005382 closed Hennadzi C_CURRENCY_CONVERT uses inactive conversion rates 
depends on backport 0005383 closed Hennadzi C_CURRENCY_CONVERT uses inactive conversion rates 
Attached Filesdiff patch-C_CURRENCY_RATE.diff (589) 2008-10-02 10:39
https://issues.openbravo.com/file_download.php?file_id=303&type=bug
Issue History
Date ModifiedUsernameFieldChange
2008-10-02 10:39rafarodaNew Issue
2008-10-02 10:39rafarodaAssigned To => Hennadzi
2008-10-02 10:39rafarodasf_bug_id0 => 2142026
2008-10-02 10:39rafarodaFile Added: patch-C_CURRENCY_RATE.diff
2008-10-02 10:39rafarodaOBNetwork customer => No
2008-10-02 10:39rafarodaRegression testing => No
2008-10-02 10:40rafarodaStatusnew => scheduled
2008-10-02 10:40rafarodafix_in_branch => trunk
2008-10-03 10:50svnbotCheckin
2008-10-03 10:50svnbotNote Added: 0009327
2008-10-03 10:50svnbotStatusscheduled => resolved
2008-10-03 10:50svnbotResolutionopen => fixed
2008-10-03 10:50svnbotsvn_revision => 8190
2008-12-08 17:14psarobeStatusresolved => new
2008-12-08 17:14psarobeResolutionfixed => open
2008-12-08 17:14psarobeNote Added: 0011028
2008-12-08 17:14psarobeStatusnew => scheduled
2008-12-11 16:30svnbotCheckin
2008-12-11 16:30svnbotNote Added: 0011187
2008-12-11 16:30svnbotStatusscheduled => resolved
2008-12-11 16:30svnbotResolutionopen => fixed
2008-12-11 16:30svnbotsvn_revision8190 => 11118
2008-12-14 20:01svnbotCheckin
2008-12-14 20:01svnbotNote Added: 0011321
2008-12-14 20:01svnbotsvn_revision11118 => 11185
2009-04-21 11:07psarobeStatusresolved => closed

Notes
(0009327)
svnbot   
2008-10-03 10:50   
Repository: openbravo
Revision: 8190
Author: hennadzi
Date: 2008-10-03 10:50:33 +0200 (Fri, 03 Oct 2008)

Fixed bug 0005381: C_CURRENCY_CONVERT uses inactive conversion rates

---
U trunk/src-db/database/model/functions/C_CURRENCY_RATE.xml
---

https://dev.openbravo.com/websvn/openbravo/?rev=8190&sc=1 [^]
(0011028)
psarobe   
2008-12-08 17:14   
What it happens now (when the conversion is deactivate) is that the call-out does not work in the example window so it fails when calculating quantity*invoice price
(0011187)
svnbot   
2008-12-11 16:30   
Repository: openbravo
Revision: 11118
Author: hennadzi
Date: 2008-12-11 16:30:15 +0100 (Thu, 11 Dec 2008)

Bug fixed 0005381: C_CURRENCY_CONVERT uses inactive conversion rates

---
U trunk/src/org/openbravo/erpCommon/ad_callouts/SE_Expense_Amount.java
U trunk/src/org/openbravo/erpCommon/ad_callouts/SE_Expense_Product.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=11118&sc=1 [^]
(0011321)
svnbot   
2008-12-14 20:01   
Repository: openbravo
Revision: 11185
Author: rafaroda
Date: 2008-12-14 20:01:08 +0100 (Sun, 14 Dec 2008)

Fixes bug 0005381 Improved messaging when there is no conversion rate.

---
U trunk/src/org/openbravo/erpCommon/ad_callouts/SE_Expense_Amount.java
U trunk/src/org/openbravo/erpCommon/ad_callouts/SE_Expense_Product.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=11185&sc=1 [^]