Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053809Retail ModulesWeb POSpublic2023-10-30 20:392023-12-15 13:16
Reporteraxelmercado 
Assigned Tosreehari 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR24Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerOBPS
Support ticket76807
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053809: Preference 'POS Web Sessions will expire' does not work correctly.
DescriptionWhen the preference 'POS Web Sessions will expire' is set to 'N' so that sessions never expire, it does not work correctly and sessions expire after 60 minutes.
Steps To Reproduce- In Backoffice configure the preferences 'Web POS Sessions will expire' with value 'N' and 'Web POS Sessions Timeout' = 0.
- Login to Web POS and log in.
- Let almost 58 minutes pass and the popup will open informing that the session will expire in 120 seconds.
Proposed SolutionI think we are facing a bug because the conditionality is not doing its job correctly. Let me explain:

(!this.sessionPing && !OB.MobileApp.model.get('permissions').OBPOS_SessionExpiration)

- this.sessionPing when logging in is undefined, so when denied it becomes True.
- OB.MobileApp.model.get('permissions').OBPOS_SessionExpiration is set to value 'N' as you don't want the session to expire (in the wiki and in the documentation about it, it is explained like this). This condition if as it is negated to be True, therefore the value of serverPingMiliseconds is set.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-10-30 20:39axelmercadoNew Issue
2023-10-30 20:39axelmercadoAssigned To => Retail
2023-10-30 20:39axelmercadoOBNetwork customer => OBPS
2023-10-30 20:39axelmercadoSupport ticket => 76807
2023-10-30 20:39axelmercadoTriggers an Emergency Pack => No
2023-10-31 07:18SABARINATH PAssigned ToRetail => SABARINATH P
2023-10-31 07:34SABARINATH PStatusnew => scheduled
2023-11-08 06:10hgbotMerge Request Status => open
2023-11-08 06:10hgbotNote Added: 0156882
2023-11-23 00:43axelmercadoNote Added: 0157513
2023-11-27 09:58hgbotMerge Request Statusopen => approved
2023-11-27 10:01hgbotNote Added: 0157659
2023-11-27 10:01hgbotResolutionopen => fixed
2023-11-27 10:01hgbotStatusscheduled => closed
2023-11-27 10:01hgbotFixed in Version => RR24Q1
2023-11-27 10:01hgbotNote Added: 0157660
2023-11-28 01:06axelmercadoNote Added: 0157711
2023-11-28 01:06axelmercadoStatusclosed => new
2023-11-28 01:06axelmercadoResolutionfixed => open
2023-11-28 01:06axelmercadoFixed in VersionRR24Q1 =>
2023-11-30 12:30hgbotResolutionopen => fixed
2023-11-30 12:30hgbotStatusnew => closed
2023-11-30 12:30hgbotFixed in Version => RR24Q1
2023-11-30 12:30hgbotNote Added: 0157848
2023-11-30 15:17axelmercadoStatusclosed => new
2023-11-30 15:17axelmercadoResolutionfixed => open
2023-11-30 15:17axelmercadoFixed in VersionRR24Q1 =>
2023-12-08 08:19SABARINATH PAssigned ToSABARINATH P => sreehari
2023-12-11 06:44sreehariStatusnew => scheduled
2023-12-13 06:45hgbotNote Added: 0158115
2023-12-15 13:16hgbotResolutionopen => fixed
2023-12-15 13:16hgbotStatusscheduled => closed
2023-12-15 13:16hgbotNote Added: 0158265
2023-12-15 13:16hgbotFixed in Version => RR24Q1
2023-12-15 13:16hgbotNote Added: 0158266

Notes
(0156882)
hgbot   
2023-11-08 06:10   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/634 [^]
(0157513)
axelmercado   
2023-11-23 00:43   
Hi team, any news for this issue?
(0157659)
hgbot   
2023-11-27 10:01   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/634 [^]
(0157660)
hgbot   
2023-11-27 10:01   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: a1b616a2c98cbf4eb5e40ceb11fb07a965571849
Author: Sabarinath <sabarinath.palanisamy.ext@openbravo.com>
Date: 27-11-2023 09:58:08
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/a1b616a2c98cbf4eb5e40ceb11fb07a965571849 [^]

Fixed ISSUE-53809: Handled session expiration on respective with its preference.

---
M web-test/integration/remote-server/BackendServer.test.js
M web/org.openbravo.mobile.core/app/integration/remote-server/BackendServer.js
---
(0157711)
axelmercado   
2023-11-28 01:06   
I'm reopening this issue as it is still not working properly. After about 60-90 minutes of inactivity, the popup still appears and if no actions are taken the session closes. It should not close.
(0157848)
hgbot   
2023-11-30 12:30   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 26379cfca316ae3affc42a1124cb03aa3235b7d1
Author: Aaron Calero <aaron.calero@openbravo.com>
Date: 30-11-2023 12:28:07
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/26379cfca316ae3affc42a1124cb03aa3235b7d1 [^]

Revert "Fixed ISSUE-53809: Handled session expiration on respective with its preference."

This reverts commit a1b616a2c98cbf4eb5e40ceb11fb07a965571849.

---
M web-test/integration/remote-server/BackendServer.test.js
M web/org.openbravo.mobile.core/app/integration/remote-server/BackendServer.js
---
(0158115)
hgbot   
2023-12-13 06:45   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1424 [^]
(0158265)
hgbot   
2023-12-15 13:16   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1424 [^]
(0158266)
hgbot   
2023-12-15 13:16   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: affd102273ac9faf8eac709237534b06b1568aa6
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 15-12-2023 13:14:44
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/affd102273ac9faf8eac709237534b06b1568aa6 [^]

Fixes ISSUE-53809: Changed the Server ping time lesser than logout Popup
*Changed the ping request from enyo api to mobileServiceRequest

---
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---