Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053792Openbravo ERPA. Platformpublic2023-10-27 10:002023-10-31 08:39
Reporteralostale 
Assigned Tocberner 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionPR23Q4Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelPackaging and release
Regression date2023-08-21
Regression introduced in releasemain
Regression introduced by commit    https://gitlab.com/openbravo/product/openbravo/-/commit/03fa452e48c60b06e2f1a70f29a093bbf07004d0 [^]
Triggers an Emergency PackNo
Summary0053792: failed non-blocking EDL requests remain in Initial status
DescriptionWhen an non-blocking EDL request fails to be processed, it remains in Initial status instead of being marked to Error.
Steps To Reproduce1. Configure an External System with HTTP-Backed type pointing to an invalid URL
2. Subscribe that External System to the Web POS Order Creation event
3. Create an Order in POS. The push API event will expectedly fail as not being able to communicate with the external system
4. Check the EDL Request
   EXPECTED: the header and line should be marked as error
   ERROR: they are in initial status
5. Check openbravo.log:
   2023-10-27 09:59:50,235 [ForkJoinPool.commonPool-worker-3] ERROR org.openbravo.externaldata.integration.process.ProcessRequest - Error updating status: Request = 6D48751C7A6C4B79A87064DB7B495718, Request Line = 082E620465E24F32AEA3DA325DA40F9B, Status = Error
java.lang.NullPointerException: null
    at org.openbravo.dal.service.OBDal.checkReadAccess(OBDal.java:745) ~[classes/:?]
    at org.openbravo.dal.service.OBDal.checkReadAccess(OBDal.java:736) ~[classes/:?]
    at org.openbravo.dal.service.OBDal.get(OBDal.java:365) ~[classes/:?]
    at org.openbravo.externaldata.integration.process.ProcessRequest.updateRequestLineAndRequestStatus(ProcessRequest.java:737) ~[classes/:?]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0053784 closed cberner failed non-blocking EDL requests remain in Initial status 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-10-30 08:07alostaleTypedefect => backport
2023-10-30 08:07alostaleTarget Version => PR23Q4
2023-10-31 07:19ivancaceresIssue Monitored: ivancaceres
2023-10-31 08:31hgbotNote Added: 0156517
2023-10-31 08:39hgbotResolutionopen => fixed
2023-10-31 08:39hgbotStatusscheduled => closed
2023-10-31 08:39hgbotNote Added: 0156518
2023-10-31 08:39hgbotNote Added: 0156519

Notes
(0156517)
hgbot   
2023-10-31 08:31   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/merge_requests/34 [^]
(0156518)
hgbot   
2023-10-31 08:39   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration [^]
Changeset: 5b62dce36570baa726fb6d5dca0bec21bd289fb2
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 31-10-2023 08:30:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/commit/5b62dce36570baa726fb6d5dca0bec21bd289fb2 [^]

Fixes ISSUE-53792: failed non-blocking EDL requests remain in Initial status

The requests were kept in initial due to some errors when handling
non-blocking EDLs errors. It was missing to set the proper context.

---
M src/org/openbravo/externaldata/integration/process/EDLImportEntryProcessor.java
M src/org/openbravo/externaldata/integration/process/ProcessRequest.java
---
(0156519)
hgbot   
2023-10-31 08:39   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/merge_requests/34 [^]