Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053784Openbravo ERPA. Platformpublic2023-10-27 10:002023-10-31 08:40
Reporteralostale 
Assigned Tocberner 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression levelPackaging and release
Regression date2023-08-21
Regression introduced in releasemain
Regression introduced by commit    https://gitlab.com/openbravo/product/openbravo/-/commit/03fa452e48c60b06e2f1a70f29a093bbf07004d0 [^]
Triggers an Emergency PackNo
Summary0053784: failed non-blocking EDL requests remain in Initial status
DescriptionWhen an non-blocking EDL request fails to be processed, it remains in Initial status instead of being marked to Error.
Steps To Reproduce1. Configure an External System with HTTP-Backed type pointing to an invalid URL
2. Subscribe that External System to the Web POS Order Creation event
3. Create an Order in POS. The push API event will expectedly fail as not being able to communicate with the external system
4. Check the EDL Request
   EXPECTED: the header and line should be marked as error
   ERROR: they are in initial status
5. Check openbravo.log:
   2023-10-27 09:59:50,235 [ForkJoinPool.commonPool-worker-3] ERROR org.openbravo.externaldata.integration.process.ProcessRequest - Error updating status: Request = 6D48751C7A6C4B79A87064DB7B495718, Request Line = 082E620465E24F32AEA3DA325DA40F9B, Status = Error
java.lang.NullPointerException: null
    at org.openbravo.dal.service.OBDal.checkReadAccess(OBDal.java:745) ~[classes/:?]
    at org.openbravo.dal.service.OBDal.checkReadAccess(OBDal.java:736) ~[classes/:?]
    at org.openbravo.dal.service.OBDal.get(OBDal.java:365) ~[classes/:?]
    at org.openbravo.externaldata.integration.process.ProcessRequest.updateRequestLineAndRequestStatus(ProcessRequest.java:737) ~[classes/:?]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0053792PR23Q4 closed cberner failed non-blocking EDL requests remain in Initial status 
caused by feature request 0052614 closed cberner There should be a mechanism to have non-blocking async EDL Requests 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-10-27 10:00alostaleNew Issue
2023-10-27 10:00alostaleAssigned To => Triage Platform Base
2023-10-27 10:00alostaleOBNetwork customer => No
2023-10-27 10:00alostaleModules => Core
2023-10-27 10:00alostaleTriggers an Emergency Pack => No
2023-10-27 10:11alostaleRegression level => Packaging and release
2023-10-27 10:11alostaleRegression date => 2023-08-21
2023-10-27 10:11alostaleRegression introduced in release => main
2023-10-27 10:11alostaleRegression introduced by commit => https://gitlab.com/openbravo/product/openbravo/-/commit/03fa452e48c60b06e2f1a70f29a093bbf07004d0 [^]
2023-10-27 10:11alostaleRelationship addedcaused by 0052614
2023-10-27 10:43cbernerAssigned ToTriage Platform Base => cberner
2023-10-27 15:50hgbotMerge Request Status => open
2023-10-27 15:50hgbotNote Added: 0156453
2023-10-27 15:52hgbotNote Added: 0156454
2023-10-30 08:07alostaleStatusnew => scheduled
2023-10-31 07:19ivancaceresIssue Monitored: ivancaceres
2023-10-31 08:24hgbotMerge Request Statusopen => approved
2023-10-31 08:24hgbotResolutionopen => fixed
2023-10-31 08:24hgbotNote Added: 0156515
2023-10-31 08:24hgbotStatusscheduled => closed
2023-10-31 08:24hgbotNote Added: 0156516
2023-10-31 08:40hgbotNote Added: 0156520

Notes
(0156453)
hgbot   
2023-10-27 15:50   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/merge_requests/33 [^]
(0156454)
hgbot   
2023-10-27 15:52   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1033 [^]
(0156515)
hgbot   
2023-10-31 08:24   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/merge_requests/33 [^]
(0156516)
hgbot   
2023-10-31 08:24   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration [^]
Changeset: b7826cc30b27afcd0f85cee4164ec8bdf4f0065a
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 31-10-2023 07:24:47
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/commit/b7826cc30b27afcd0f85cee4164ec8bdf4f0065a [^]

Fixes ISSUE-53784: failed non-blocking EDL requests remain in Initial status

The requests were kept in initial due to some errors when handling
non-blocking EDLs errors. It was missing to set the proper context.

---
M src/org/openbravo/externaldata/integration/process/EDLImportEntryProcessor.java
M src/org/openbravo/externaldata/integration/process/ProcessRequest.java
---
(0156520)
hgbot   
2023-10-31 08:40   
Merge request closed: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1033 [^]