Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0053764 | Retail Modules | Web POS | public | 2023-10-26 01:07 | 2023-11-27 12:08 |
|
| Reporter | sofidossant | |
| Assigned To | SABARINATH P | |
| Priority | high | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | pi | |
| Target Version | | Fixed in Version | RR24Q1 | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0053764: Sales delivery error - Return Receipts/Shipments do not allow lines with positive quantities |
| Description | When we deliver a sale, it generates the following error "Return Receipts/Shipments do not allow lines with positive quantities", and it is because the code does not correctly take into account the type of discount that should be used |
| Steps To Reproduce | - Configure a discount type of M_INOUT as default and that is used in return as well.
- Try to deliver an order (1 quantity)
- In the code if we see JAVA GoodsShipmentGenerator (POSTERMINAL), createNewGoodsShipment function, the FIN_Utility.getDocumentType(organization, DOCBASETYPE_MATERIAL_SHIPMENT) function is used but this function does not take into account other than return (a shipment is going to be made)
More information
https://www.youtube.com/watch?v=mo91NUwbfFk&ab_channel=CristianAdrian%7CPracticsBS [^]
|
| Proposed Solution | Solution proposed
--- a/modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/process/GoodsShipmentGenerator.java 2023-10-25 18:01:46.358985000 +0200
+++ b/modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/process/GoodsShipmentGenerator.java 2023-10-25 17:58:18.724292000 +0200
@@ -86,8 +86,9 @@
this.shipment.setOrganization(organization);
this.shipment.setTrxOrganization(salesOrder.getTrxOrganization());
this.shipment.setSalesTransaction(true);
- this.shipment
- .setDocumentType(FIN_Utility.getDocumentType(organization, DOCBASETYPE_MATERIAL_SHIPMENT));
+ this.shipment.setDocumentType(salesOrder.getDocumentType().getDocumentTypeForShipment() != null
+ ? salesOrder.getDocumentType().getDocumentTypeForShipment()
+ : FIN_Utility.getDocumentType(organization, DOCBASETYPE_MATERIAL_SHIPMENT));
this.shipment.setDocumentNo(FIN_Utility.getDocumentNo(this.shipment.getDocumentType(),
this.shipment.getDocumentType().getTable() != null
? "DocumentNo_" + this.shipment.getDocumentType().getTable().getDBTableName()
|
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  GoodsShipmentGenerator.diff (1,117) 2023-10-26 01:07
https://issues.openbravo.com/file_download.php?file_id=19094&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2023-10-26 01:07 | sofidossant | New Issue | |
| 2023-10-26 01:07 | sofidossant | Assigned To | => Retail |
| 2023-10-26 01:07 | sofidossant | File Added: GoodsShipmentGenerator.diff | |
| 2023-10-26 01:07 | sofidossant | Triggers an Emergency Pack | => No |
| 2023-10-26 07:31 | Practics | Issue Monitored: Practics | |
| 2023-11-03 14:12 | SABARINATH P | Assigned To | Retail => SABARINATH P |
| 2023-11-03 14:21 | SABARINATH P | Status | new => acknowledged |
| 2023-11-04 12:45 | SABARINATH P | Status | acknowledged => scheduled |
| 2023-11-17 11:47 | sofidossant | Note Added: 0157275 | |
| 2023-11-21 12:04 | sofidossant | Note Added: 0157412 | |
| 2023-11-23 10:12 | hgbot | Note Added: 0157539 | |
| 2023-11-24 12:17 | sofidossant | Note Added: 0157610 | |
| 2023-11-27 12:08 | hgbot | Resolution | open => fixed |
| 2023-11-27 12:08 | hgbot | Status | scheduled => closed |
| 2023-11-27 12:08 | hgbot | Note Added: 0157666 | |
| 2023-11-27 12:08 | hgbot | Fixed in Version | => RR24Q1 |
| 2023-11-27 12:08 | hgbot | Note Added: 0157667 | |