Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053763Openbravo ERPY. DBSourceManagerpublic2023-10-25 18:022023-11-10 12:06
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR24Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053763: Integrate partial sampledata export properly to dbsourcemanager
DescriptionPOS2 sampledata is a partial sampledata applied on top of the pos1 sampledata White Valley. POS2 restaurant is another sampledata extension on top.

However the code to export such a partial sampledata has never been integrated into the product.

Instead some adhoc outdated / prototype is required to be used for every change of pos2 sampledata. The exact changes done in that prototype are unknown as the sourcecode has been lost (needs to be reverse-engineered from the binary only jar file used).


This leads to:
- Lost time every time such partial sample is being modified.
- Impossible to add sampledata consistency check

Which when missing allows further data problems to accumulate unchecked

Goal is to:
- Reverse engineer that old prototype
- Integrate it properly so it can be used normally
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-10-25 18:02AugustoMauchNew Issue
2023-10-25 18:02AugustoMauchAssigned To => AugustoMauch
2023-10-25 18:02AugustoMauchOBNetwork customer => No
2023-10-25 18:02AugustoMauchModules => Core
2023-10-25 18:02AugustoMauchTriggers an Emergency Pack => No
2023-10-25 18:03AugustoMauchDescription Updatedbug_revision_view_page.php?rev_id=27034#r27034
2023-10-25 23:28AugustoMauchStatusnew => scheduled
2023-10-25 23:32hgbotMerge Request Status => open
2023-10-25 23:32hgbotNote Added: 0156298
2023-10-25 23:35hgbotNote Added: 0156299
2023-11-08 23:52hgbotNote Added: 0156927
2023-11-10 11:19hgbotMerge Request Statusopen => approved
2023-11-10 12:06hgbotNote Added: 0157020
2023-11-10 12:06hgbotNote Added: 0157021
2023-11-10 12:06hgbotResolutionopen => fixed
2023-11-10 12:06hgbotStatusscheduled => closed
2023-11-10 12:06hgbotFixed in Version => PR24Q1
2023-11-10 12:06hgbotNote Added: 0157022
2023-11-10 12:06hgbotNote Added: 0157023
2023-11-10 12:06hgbotNote Added: 0157024
2023-11-10 12:06hgbotNote Added: 0157025

Notes
(0156298)
hgbot   
2023-10-25 23:32   
Merge Request created: https://gitlab.com/openbravo/product/dbsm/-/merge_requests/43 [^]
(0156299)
hgbot   
2023-10-25 23:35   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1028 [^]
(0156927)
hgbot   
2023-11-08 23:52   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata/-/merge_requests/67 [^]
(0157020)
hgbot   
2023-11-10 12:06   
Repository: https://gitlab.com/openbravo/product/dbsm [^]
Changeset: b19298bf4a91f542a942b010f7b28903087deca1
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 25-10-2023 23:32:30
URL: https://gitlab.com/openbravo/product/dbsm/-/commit/b19298bf4a91f542a942b010f7b28903087deca1 [^]

Related to ISSUE-53763: Adds ExportSampledataExtension class

This class extends ExportSampledata to support exporting sample data specifying the name
of the dataset to be exporting, and using the sql where clause defined by the dataset table
instead of the default client filter that ExportSampledata uses

---
A src/org/openbravo/ddlutils/task/ExportSampledataExtension.java
---
(0157021)
hgbot   
2023-11-10 12:06   
Merge request merged: https://gitlab.com/openbravo/product/dbsm/-/merge_requests/43 [^]
(0157022)
hgbot   
2023-11-10 12:06   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1028 [^]
(0157023)
hgbot   
2023-11-10 12:06   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 48dcac283e770fb6632101781aedb4cea3fefa00
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 10-11-2023 11:06:20
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/48dcac283e770fb6632101781aedb4cea3fefa00 [^]

Fixes ISSUE-53763: Adds export.sample.data.extension task

The export.sample.data.extension allows to export incremental sampledata, also known as sampledata extensions.

Example of use, to export POS2 sampledata:
ant export.sample.data.extension -DdataSetName="POS2 SampleData" -Dclient="The White Valley Group" -Dmodule=org.openbravo.pos2.sampledata

---
M build.xml
M src-db/database/build.xml
M src-db/database/lib/dbsourcemanager.jar
---
(0157024)
hgbot   
2023-11-10 12:06   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata [^]
Changeset: 216cd35f35122b717a52a57a87e86a62cb2a9301
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 10-11-2023 11:06:23
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata/-/commit/216cd35f35122b717a52a57a87e86a62cb2a9301 [^]

Related to ISSUE-53763: Updates AD_DATASET_TABLE to include all exported entries, data is not ordered by ID

Sampledata is now exported using the updated export.sample.data.extension process that exports records sorting them by their ID,
making exported files more consistent.

Also the AD_DATASET_TABLE has been updated to reflect the records that were being exported, so that now when reexporting the sampledata,
only the updated entries should be included in the list of changes

---
M referencedata/sampledata/The_White_Valley_Group/AD_IMAGE.xml
M referencedata/sampledata/The_White_Valley_Group/C_EXTBP_CONFIG_PROPERTY.xml
M referencedata/sampledata/The_White_Valley_Group/FIN_FINACC_PAYMENTMETHOD.xml
M referencedata/sampledata/The_White_Valley_Group/FIN_FINANCIAL_ACCOUNT.xml
M referencedata/sampledata/The_White_Valley_Group/M_PRODUCT.xml
M referencedata/sampledata/The_White_Valley_Group/M_PRODUCTPRICE.xml
M referencedata/sampledata/The_White_Valley_Group/M_PRODUCT_ACCT.xml
M referencedata/sampledata/The_White_Valley_Group/M_STORAGE_DETAIL.xml
M referencedata/sampledata/The_White_Valley_Group/OBC2_USER_ACTION_ACCESS.xml
M referencedata/sampledata/The_White_Valley_Group/OBC2_USER_ACTION_INPUT.xml
M referencedata/sampledata/The_White_Valley_Group/OBC2_USER_INPUT.xml
M referencedata/sampledata/The_White_Valley_Group/OBC2_USER_INPUT_VALUE.xml
M referencedata/sampledata/The_White_Valley_Group/OBPOS2_CROSS_STORE.xml
M referencedata/sampledata/The_White_Valley_Group/OBPOS2_KEYMAP.xml
M referencedata/sampledata/The_White_Valley_Group/OBPOS2_KEYMAP_CATEGORY.xml
M referencedata/sampledata/The_White_Valley_Group/OBPOS2_KEYMAP_CAT_BTN_POS.xml
M referencedata/sampledata/The_White_Valley_Group/OBPOS2_KEYMAP_CAT_LAYOUT.xml
M referencedata/sampledata/The_White_Valley_Group/OBPOS2_KEYMAP_CAT_PRODCAT.xml
M referencedata/sampledata/The_White_Valley_Group/OBPOS2_KEYMAP_PRODUCT.xml
M referencedata/sampledata/The_White_Valley_Group/OBPOS2_KEYMAP_PROD_BTN_APP.xml
M referencedata/sampledata/The_White_Valley_Group/OBPOS2_KEYMAP_PROD_BTN_POS.xml
M referencedata/sampledata/The_White_Valley_Group/OBPOS2_KEYMAP_PROD_LAYOUT.xml
M referencedata/sampledata/The_White_Valley_Group/OBPOS2_KEYMAP_PROD_LYT_DEF.xml
M referencedata/sampledata/The_White_Valley_Group/OBPOS2_KM_CAT_PRODCAT_EXCL.xml
M referencedata/sampledata/The_White_Valley_Group/OBPOS2_ORG_SCHEMA.xml
M referencedata/sampledata/The_White_Valley_Group/OBPOS2_PICKUPP.xml
M referencedata/sampledata/The_White_Valley_Group/OBPOS2_PICKUPPTYPE.xml
M referencedata/sampledata/The_White_Valley_Group/OBPOS_APPLICATIONS.xml
M referencedata/sampledata/The_White_Valley_Group/OBPOS_APP_PAYMENT.xml
M referencedata/sampledata/The_White_Valley_Group/OBPOS_APP_PAYMENT_TYPE.xml
M referencedata/sampledata/The_White_Valley_Group/OBPOS_CURRENCY_PANEL.xml
M referencedata/sampledata/The_White_Valley_Group/OBPOS_HARDWAREURL.xml
M referencedata/sampledata/The_White_Valley_Group/OBPOS_TERMINALTYPE.xml
M referencedata/sampledata/The_White_Valley_Group/OBRETCO_ORG_SPECIALSCHEDULE.xml
M referencedata/sampledata/The_White_Valley_Group/OBRETCO_PROL_PRODUCT.xml
M src-db/database/sourcedata/AD_DATASET_TABLE.xml
---
(0157025)
hgbot   
2023-11-10 12:06   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata/-/merge_requests/67 [^]