Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053736Openbravo ERPA. Platformpublic2023-10-20 12:282024-08-12 09:16
Reporteragusti_gallego 
Assigned Toagusti_gallego 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053736: Including a wrong date when importing inventories doesn't trigger an error
DescriptionWhen importing inventories through the API, including a malformed date in the "date" field doesn't trigger an error. Instead, it parses the date anyway and includes it anyway in the document.

https://openbravo.atlassian.net/browse/RM-9009 [^]
Steps To Reproduce- Prepare an inventory to import and include a wrong date (for instance, 202-10-20) in the "date" field.
- Import the inventory.
- See that the date of the created inventory is "0202-10-20".
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-10-20 12:28agusti_gallegoNew Issue
2023-10-20 12:28agusti_gallegoAssigned To => agusti_gallego
2023-10-20 12:28agusti_gallegoModules => Core
2023-10-20 12:28agusti_gallegoTriggers an Emergency Pack => No
2023-10-20 12:31hgbotNote Added: 0156120
2023-10-20 15:04agusti_gallegoDescription Updatedbug_revision_view_page.php?rev_id=27016#r27016
2023-10-23 13:28hgbotNote Added: 0156169
2023-10-25 17:32hgbotNote Added: 0156292
2023-10-25 18:12hgbotNote Added: 0156293
2023-10-26 09:35hgbotNote Added: 0156314
2023-10-31 11:41hgbotNote Added: 0156540
2023-11-02 11:39hgbotNote Added: 0156606
2023-11-02 11:39hgbotNote Added: 0156607
2023-11-02 11:40hgbotNote Added: 0156610
2023-11-02 11:40hgbotNote Added: 0156611
2023-11-03 09:16hgbotNote Added: 0156660
2023-11-03 09:16hgbotNote Added: 0156661
2023-11-03 09:17hgbotResolutionopen => fixed
2023-11-03 09:17hgbotStatusnew => closed
2023-11-03 09:17hgbotNote Added: 0156662
2023-11-03 09:17hgbotNote Added: 0156663
2023-11-08 10:21hgbotNote Added: 0156904
2023-12-29 11:24hgbotNote Added: 0158720
2024-01-03 12:17hgbotNote Added: 0158790
2024-08-12 09:16hgbotNote Added: 0167947

Notes
(0156120)
hgbot   
2023-10-20 12:31   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/199 [^]
(0156169)
hgbot   
2023-10-23 13:28   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.external.integration/-/merge_requests/36 [^]
(0156292)
hgbot   
2023-10-25 17:32   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/199 [^]
(0156293)
hgbot   
2023-10-25 18:12   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/200 [^]
(0156314)
hgbot   
2023-10-26 09:35   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.service.external.integration.tests/-/merge_requests/21 [^]
(0156540)
hgbot   
2023-10-31 11:41   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/merge_requests/53 [^]
(0156606)
hgbot   
2023-11-02 11:39   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.external.integration [^]
Changeset: 6907ee63fcb65685fb7be3b2859793452f02f5a5
Author: Agustí Gállego <agusti.gallego@openbravo.com>
Date: 02-11-2023 10:39:11
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.external.integration/-/commit/6907ee63fcb65685fb7be3b2859793452f02f5a5 [^]

Related to BUG-53736: mapping was not failing if date was not in the expected format

---
M src/org/openbravo/service/external/integration/mapping/DateDirectPropertyMapping.java
M src/org/openbravo/service/external/integration/mapping/DateTimeDirectPropertyMapping.java
---
(0156607)
hgbot   
2023-11-02 11:39   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.external.integration/-/merge_requests/36 [^]
(0156610)
hgbot   
2023-11-02 11:40   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.service.external.integration.tests [^]
Changeset: a95616fba516c91905e1f519fe4fc9b4fa7ea77d
Author: Agustí Gállego <agusti.gallego@openbravo.com>
Date: 02-11-2023 10:40:28
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.service.external.integration.tests/-/commit/a95616fba516c91905e1f519fe4fc9b4fa7ea77d [^]

Related to BUG-53736: Add test case

---
M src-test/org/openbravo/service/external/integration/test/_import/GoodsShipmentImportTest.java
---
(0156611)
hgbot   
2023-11-02 11:40   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.service.external.integration.tests/-/merge_requests/21 [^]
(0156660)
hgbot   
2023-11-03 09:16   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests [^]
Changeset: 79ad7fc734195c61ec28a93eb15f36e3fe1d6cb7
Author: Agustí Gállego <agusti.gallego@openbravo.com>
Date: 31-10-2023 15:42:02
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/commit/79ad7fc734195c61ec28a93eb15f36e3fe1d6cb7 [^]

Related to ISSUE-53736: Added test case for malformed dates

---
A src-test/data/importer/InventoryMalformedDate.json
M src-test/org/openbravo/api/tests/importer/ImportInventory.java
---
(0156661)
hgbot   
2023-11-03 09:16   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/merge_requests/53 [^]
(0156662)
hgbot   
2023-11-03 09:17   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^]
Changeset: 8fe321f4fcc27139aa2f104ed8686e9387d86370
Author: Agustí Gállego <agusti.gallego@openbravo.com>
Date: 02-11-2023 17:31:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/8fe321f4fcc27139aa2f104ed8686e9387d86370 [^]

Fixes ISSUE-53736: Changing Date to LocalDate to avoid parsing malformed dates.

---
M src/org/openbravo/api/mappings/inventory/ImportInventoryJavaPropertyMappingHandler.java
---
(0156663)
hgbot   
2023-11-03 09:17   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/200 [^]
(0156904)
hgbot   
2023-11-08 10:21   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/210 [^]
(0158720)
hgbot   
2023-12-29 11:24   
Repository: https://gitlab.com/openbravo/customers/saboraespana/snapshots [^]
Changeset: f98474406b506ec64bc49a092df94c9c882bc380
Author: Kepa Choperena <kepa.choperena@openbravo.com>
Date: 29-12-2023 11:24:05
URL: https://gitlab.com/openbravo/customers/saboraespana/snapshots/-/commit/f98474406b506ec64bc49a092df94c9c882bc380 [^]

Updated Snapshot_Dev. Included ISSUE-53736 & ISSUE-49291.

https://issues.openbravo.com/view.php?id=53736. [^]
https://issues.openbravo.com/view.php?id=53564 [^]

---
M Snapshot_Dev
---
(0158790)
hgbot   
2024-01-03 12:17   
Repository: https://gitlab.com/openbravo/customers/saboraespana/snapshots [^]
Changeset: 763ec4269bb04deb00d973d20904e253a2c554d3
Author: Kepa Choperena <kepa.choperena@openbravo.com>
Date: 03-01-2024 12:17:35
URL: https://gitlab.com/openbravo/customers/saboraespana/snapshots/-/commit/763ec4269bb04deb00d973d20904e253a2c554d3 [^]

Revert "Updated Snapshot_Dev. Included ISSUE-53736 & ISSUE-49291."

This reverts commit f98474406b506ec64bc49a092df94c9c882bc380.

---
M Snapshot_Dev
---
(0167947)
hgbot   
2024-08-12 09:16   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/210 [^]