Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053709POS2POSpublic2023-10-19 05:492023-10-23 07:00
Reporterjorgewederago 
Assigned Tojorgewederago 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053709: Scanning while having coupons installed is raising non required error messages
DescriptionIn a environment with POS2 installed if coupons is installed. Whenever a code is scanned and it is not a product, an error saying that the coupon is invalid is raised.
Steps To Reproduce1.-Have an environment with coupons installed
2.-Scan any code that it is not related to a product
3.-An error saying that the coupon is not valid will be shown
Proposed SolutionCoupons scanning handler should raise errors only when needed
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-10-19 05:49jorgewederagoNew Issue
2023-10-19 05:49jorgewederagoAssigned To => Retail
2023-10-19 05:49jorgewederagoOBNetwork customer => Gold
2023-10-19 05:49jorgewederagoTriggers an Emergency Pack => No
2023-10-19 05:50jorgewederagoStatusnew => scheduled
2023-10-19 05:50jorgewederagoAssigned ToRetail => jorgewederago
2023-10-19 06:10hgbotMerge Request Status => open
2023-10-19 06:10hgbotNote Added: 0156028
2023-10-23 07:00hgbotMerge Request Statusopen => approved
2023-10-23 07:00hgbotResolutionopen => fixed
2023-10-23 07:00hgbotStatusscheduled => closed
2023-10-23 07:00hgbotNote Added: 0156141
2023-10-23 07:00hgbotNote Added: 0156142

Notes
(0156028)
hgbot   
2023-10-19 06:10   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/merge_requests/24 [^]
(0156141)
hgbot   
2023-10-23 07:00   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons [^]
Changeset: e6a7e4feef1b0c75ef763c07db4fef723e39c4b6
Author: Jorge Wederago <jorge.wederago@openbravo.com>
Date: 19-10-2023 12:52:53
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/commit/e6a7e4feef1b0c75ef763c07db4fef723e39c4b6 [^]

Fixed ISSUE-53709: Scanning while having coupons installed is raising non required error messages

---
M web-jspack/org.openbravo.retail.discounts.coupons/src/model/ticket/actions/SearchAndAddCouponToTicketActionPreparation.js
M web-jspack/org.openbravo.retail.discounts.coupons/src/model/ticket/coupons/user-actions/AddCoupon.js
M web-jspack/org.openbravo.retail.discounts.coupons/src/services/scan/handlers/CouponScanEventHandler.js
M web/org.openbravo.retail.discounts.coupons/app/model/business-object/ticket/TicketCouponUtils.js
---
(0156142)
hgbot   
2023-10-23 07:00   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/merge_requests/24 [^]