Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053682POS2POSpublic2023-10-17 16:122023-12-01 08:55
Reporterigor_trebol 
Assigned Toigor_trebol 
PrioritynormalSeveritymajorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053682: REACT Delivery Modes at Line Level and Portrait
Descriptionhttps://openbravo.atlassian.net/browse/RM-5832 [^]
Steps To Reproducen/a
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-10-17 16:12igor_trebolNew Issue
2023-10-17 16:12igor_trebolAssigned To => igor_trebol
2023-10-17 16:12igor_trebolTriggers an Emergency Pack => No
2023-10-17 16:12igor_trebolStatusnew => scheduled
2023-10-17 16:14hgbotNote Added: 0155960
2023-11-03 10:46hgbotNote Added: 0156672
2023-11-24 12:23hgbotNote Added: 0157611
2023-11-27 15:26hgbotResolutionopen => fixed
2023-11-27 15:26hgbotStatusscheduled => closed
2023-11-27 15:26hgbotNote Added: 0157684
2023-11-27 15:26hgbotNote Added: 0157685
2023-11-27 15:29hgbotFixed in Version => 24Q1
2023-11-27 15:29hgbotNote Added: 0157686
2023-11-27 15:29hgbotNote Added: 0157687
2023-11-27 15:32hgbotFixed in Version24Q1 => RR24Q1
2023-11-27 15:32hgbotNote Added: 0157688
2023-11-27 15:32hgbotNote Added: 0157689
2023-11-30 08:42hgbotNote Added: 0157830
2023-12-01 08:55hgbotNote Added: 0157888
2023-12-01 08:55hgbotNote Added: 0157889

Notes
(0155960)
hgbot   
2023-10-17 16:14   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2181 [^]
(0156672)
hgbot   
2023-11-03 10:46   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/260 [^]
(0157611)
hgbot   
2023-11-24 12:23   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1415 [^]
(0157684)
hgbot   
2023-11-27 15:26   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^]
Changeset: 21eea1c1180cb518062c5c2bbe1ebefb0279778c
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 27-11-2023 15:24:15
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/21eea1c1180cb518062c5c2bbe1ebefb0279778c [^]

Fixes FR-53682: REACT Delivery Modes at Line Level and Portrait'

MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/260 [^]

---
M web-jspack/org.openbravo.pos2.restaurant/src/components/TicketMenuLine/__test__/TicketMenuLine.test.jsx
M web-jspack/org.openbravo.pos2.restaurant/src/components/TicketMenuLine/stories/TicketMenuLine.stories.jsx
---
(0157685)
hgbot   
2023-11-27 15:26   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/260 [^]
(0157686)
hgbot   
2023-11-27 15:29   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 322885cea722e7166d91d235c6e8a990509e798c
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 27-11-2023 15:28:29
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/322885cea722e7166d91d235c6e8a990509e798c [^]

Fixes FR-53682: REACT Delivery Modes at Line Level and Portrait'

MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2181 [^]

---
A web-jspack/org.openbravo.pos2/src-test/cypress/e2e/Features/deliveryModeLines.spec.js
A web-jspack/org.openbravo.pos2/src-test/cypress/fixtures/e2eFixtures/DeliveryModeLines.json
A web-jspack/org.openbravo.pos2/src-test/cypress/functions/deliveryModeLines.js
A web-jspack/org.openbravo.pos2/src/components/Ticket/TicketDeliveryModeDetail/TicketDeliveryModeDetail.jsx
A web-jspack/org.openbravo.pos2/src/components/Ticket/TicketDeliveryModeDetail/__test__/TicketDeliveryModeDetail.test.jsx
A web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLineDeliveryMode/TicketLineDeliveryModeButton/TicketLineDeliveryModeButton.jsx
A web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLineDeliveryMode/TicketLineDeliveryModeButton/TicketLineDeliveryModeButton.test.jsx
A web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLineDeliveryMode/TicketLineDeliveryModePopover/TicketLineDeliveryModePopover.jsx
A web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLineDeliveryMode/TicketLineDeliveryModePopover/TicketLineDeliveryModePopover.scss
A web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLineDeliveryMode/TicketLineDeliveryModePopover/TicketLineDeliveryModePopover.test.jsx
A web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLineDeliveryMode.jsx
A web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLineDeliveryMode.scss
A web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/__test__/TicketLineDeliveryMode.test.jsx
A web-jspack/org.openbravo.pos2/src/model/ticket/actions/SetLineDeliveryMode.js
A web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/SetLineDeliveryMode.js
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/OBC2_USER_ACTION.xml
M web-jspack/org.openbravo.pos2/src-test/cypress/functions/index.js
M web-jspack/org.openbravo.pos2/src-test/cypress/runAllSpecs/runFeaturesSpecsPOS2.spec.js
M web-jspack/org.openbravo.pos2/src/components/ProofOfPayment/ProofOfPaymentDetails/ProofOfPaymentDetailLine/__test__/ProofOfPaymentDetailLine.test.jsx
M web-jspack/org.openbravo.pos2/src/components/ProofOfPayment/ProofOfPaymentDetails/__test__/ProofOfPaymentDetails.test.jsx
M web-jspack/org.openbravo.pos2/src/components/SelectLines/SelectedLinesGrid/__test__/SelectLines.test.jsx
M web-jspack/org.openbravo.pos2/src/components/SelectLines/SelectedLinesGrid/stories/SelectLines.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketArea/__test__/TicketArea.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketArea/stories/TicketArea.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePopover/TicketLinePopover.config.json
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePopover/TicketLinePopover.scss
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePopover/__test__/TicketLinePopover.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLine.config.json
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/__test__/TicketLines.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/__test__/TicketLinesHeader.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/stories/TicketLines.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketPopover/__test__/TicketPopover.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketPropertiesPopover/TicketPropertiesPopoverDeliveryButton.jsx
M web-jspack/org.openbravo.pos2/src/components/TicketLineRenderCell/__test__/TicketLineRenderCell.test.jsx
M web-jspack/org.openbravo.pos2/src/components/VerifiedReturns/VerifiedReturnsGrid/TicketLineRenderCellWrapper/__test__/TicketLineRenderCellWrapper.test.jsx
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketExtension.js
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketUtils.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/TicketUtils.test.js
M web-jspack/org.openbravo.pos2/src/ob-init.js
---
(0157687)
hgbot   
2023-11-27 15:29   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2181 [^]
(0157688)
hgbot   
2023-11-27 15:32   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 30e4b69897a7a915d4610910d536739235daed61
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 27-11-2023 15:31:37
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/30e4b69897a7a915d4610910d536739235daed61 [^]

Fixes FR-53682: REACT Delivery Modes at Line Level and Portrait'

MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1415 [^]

---
M web-test/model/business-object/ticket/TicketUtils.test.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/TicketUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/SetDeliveryMode.js
---
(0157689)
hgbot   
2023-11-27 15:32   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1415 [^]
(0157830)
hgbot   
2023-11-30 08:42   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2265 [^]
(0157888)
hgbot   
2023-12-01 08:55   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2265 [^]
(0157889)
hgbot   
2023-12-01 08:55   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: d74a4208e53b7d9d014e19edda45250605229585
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 01-12-2023 07:55:04
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/d74a4208e53b7d9d014e19edda45250605229585 [^]

Related to ISSUE-53682: Solved problem in service lines.

- When clicking on service lines, the Delivery Modes button showed an
error. This commit checks that the line does not generate that error by
checking both the line's delivery mode or if it is an array.

---
M web-jspack/org.openbravo.pos2/src-test/cypress/e2e/Features/deliveryModeLines.spec.js
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLineDeliveryMode/TicketLineDeliveryModeButton/TicketLineDeliveryModeButton.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLineDeliveryMode/TicketLineDeliveryModeButton/TicketLineDeliveryModeButton.test.jsx
---