Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053681POS2POSpublic2023-10-17 15:572023-12-11 11:02
Reportermigueldejuana 
Assigned Tojarmendariz 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version24Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053681: useIsOverflow is not working when overflow disappear
DescriptionWhen we resize the window, useIsOverflow returns the overflow value. It seems that it is not working properly when overflow dissapear (making bigger the screen).
See the attached gif and steps to reproduce for more detail.
Steps To Reproduce- Login in POS2
- Add any product and press Pay button
- Check that the Payment Title has 2 buttons (Generate PoP From and Split Check)
- Reduce the width of the browser till we see 3 dots button instead of "Generate PoP From" button
- Move back the browser to the previous size (make it wider) and see that "Generate PoP From" is not shown again
Proposed SolutionReview all usage of useIsOverflow (ResponsiveToolbar, PaymentCurrencySelector...) and fix the problem.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0051943 closed AugustoMauch Responsive Toolbar render every time Form updates 
Attached Filesgif resizeResponsiveToolbar.gif (3,675,668) 2023-10-17 15:57
https://issues.openbravo.com/file_download.php?file_id=19038&type=bug
Issue History
Date ModifiedUsernameFieldChange
2023-10-17 15:57migueldejuanaNew Issue
2023-10-17 15:57migueldejuanaAssigned To => Triage Platform Base
2023-10-17 15:57migueldejuanaFile Added: resizeResponsiveToolbar.gif
2023-10-17 15:57migueldejuanaOBNetwork customer => No
2023-10-17 15:57migueldejuanaTriggers an Emergency Pack => No
2023-11-10 09:51AugustoMauchAssigned ToTriage Platform Base => AugustoMauch
2023-11-10 09:51AugustoMauchAssigned ToAugustoMauch => ablasco
2023-11-10 09:52cbernerSummaryuseIsOverflow is not wirking when overflow disappear => useIsOverflow is not working when overflow disappear
2023-11-22 17:55AugustoMauchAssigned Toablasco => jarmendariz
2023-11-23 12:57hgbotMerge Request Status => open
2023-11-23 12:57hgbotNote Added: 0157555
2023-11-23 12:58jarmendarizRelationship addedrelated to 0051943
2023-11-27 07:48hgbotNote Added: 0157649
2023-11-28 09:15hgbotMerge Request Statusopen => approved
2023-12-11 09:01AugustoMauchStatusnew => scheduled
2023-12-11 11:02hgbotNote Added: 0158033
2023-12-11 11:02hgbotNote Added: 0158035
2023-12-11 11:02hgbotResolutionopen => fixed
2023-12-11 11:02hgbotStatusscheduled => closed
2023-12-11 11:02hgbotNote Added: 0158036
2023-12-11 11:02hgbotFixed in Version => 24Q1
2023-12-11 11:02hgbotNote Added: 0158037

Notes
(0157555)
hgbot   
2023-11-23 12:57   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1293 [^]
(0157649)
hgbot   
2023-11-27 07:48   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2262 [^]
(0158033)
hgbot   
2023-12-11 11:02   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: b0460695ad2b289670dd84d5568a61e14ae35814
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 11-12-2023 11:01:32
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/b0460695ad2b289670dd84d5568a61e14ae35814 [^]

Related to ISSUE-53681: Created test case that tests responsive toolbar behavior using the pay Window

---
A web-jspack/org.openbravo.pos2/src-test/cypress/e2e/Features/responsiveToolbar.spec.js
---
(0158035)
hgbot   
2023-12-11 11:02   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2262 [^]
(0158036)
hgbot   
2023-12-11 11:02   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1293 [^]
(0158037)
hgbot   
2023-12-11 11:02   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 273d9f7d1d3840923ac64f482b1889ec4c7058bc
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 11-12-2023 10:58:37
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/273d9f7d1d3840923ac64f482b1889ec4c7058bc [^]

Fixed ISSUE-53681: Responsive toolbar is not properly redistributed on window resize

---
M web-jspack/org.openbravo.core2/src/components/ResponsiveToolbar/ResponsiveToolbar.jsx
---