Openbravo Issue Tracking System - POS2 |
View Issue Details |
|
ID | Project | Category | View Status | Date Submitted | Last Update |
0053674 | POS2 | POS | public | 2023-10-17 10:22 | 2024-10-21 07:51 |
|
Reporter | andre_montenegro | |
Assigned To | Bimla_vm | |
Priority | normal | Severity | trivial | Reproducibility | have not tried |
Status | closed | Resolution | fixed | |
Platform | | OS | 5 | OS Version | |
Product Version | | |
Target Version | | Fixed in Version | 25Q1 | |
Merge Request Status | |
Review Assigned To | |
OBNetwork customer | |
Support ticket | |
Regression level | QA functional test |
Regression date | |
Regression introduced in release | |
Regression introduced by commit | https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/58ab93e1fb4a6fecdfc58e6b88d0314219be2dda [^] |
Triggers an Emergency Pack | No |
|
Summary | 0053674: [23Q4] Search and delete scss files with dead code |
Description | Dead code has been find while reviewing Release notes in the QA cycle.
For now, the following files with dead code have been found:
- /org.openbravo.pos2/web-jspack/org.openbravo.pos2/src/components/ProductCategoryKeymap/ProductCategoryKeymap.scss
-/org.openbravo.pos2/web-jspack/org.openbravo.pos2/src/components/ProductKeymap/ProductKeymap.scss
Search for more dead code and delete the necessary files. |
Steps To Reproduce | Search for the following files and observe that only contains the copyright line:
- /org.openbravo.pos2/web-jspack/org.openbravo.pos2/src/components/ProductCategoryKeymap/ProductCategoryKeymap.scss
-/org.openbravo.pos2/web-jspack/org.openbravo.pos2/src/components/ProductKeymap/ProductKeymap.scss
|
Proposed Solution | Unnecessary code must be deleted.
Search for similar files and delete them if not mandatory. |
Additional Information | |
Tags | No tags attached. |
Relationships | |
Attached Files | |
|
Issue History |
Date Modified | Username | Field | Change |
2023-10-17 10:22 | andre_montenegro | New Issue | |
2023-10-17 10:22 | andre_montenegro | Assigned To | => Retail |
2023-10-17 10:22 | andre_montenegro | Regression level | => QA functional test |
2023-10-17 10:22 | andre_montenegro | Regression introduced by commit | => https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/58ab93e1fb4a6fecdfc58e6b88d0314219be2dda [^] |
2023-10-17 10:22 | andre_montenegro | Triggers an Emergency Pack | => No |
2024-09-30 12:38 | guillermogil | Status | new => acknowledged |
2024-09-30 15:35 | Bimla_vm | Assigned To | Retail => Bimla_vm |
2024-09-30 15:37 | Bimla_vm | Status | acknowledged => scheduled |
2024-10-03 10:34 | hgbot | Note Added: 0169931 | |
2024-10-03 10:36 | hgbot | Note Added: 0169932 | |
2024-10-03 10:37 | hgbot | Note Added: 0169933 | |
2024-10-03 10:38 | hgbot | Note Added: 0169934 | |
2024-10-03 10:38 | hgbot | Note Added: 0169935 | |
2024-10-03 10:39 | hgbot | Note Added: 0169937 | |
2024-10-03 10:40 | hgbot | Note Added: 0169938 | |
2024-10-03 10:40 | hgbot | Note Added: 0169939 | |
2024-10-03 10:40 | hgbot | Note Added: 0169940 | |
2024-10-21 07:40 | hgbot | Note Added: 0170611 | |
2024-10-21 07:40 | hgbot | Note Added: 0170612 | |
2024-10-21 07:40 | hgbot | Note Added: 0170613 | |
2024-10-21 07:40 | hgbot | Note Added: 0170614 | |
2024-10-21 07:41 | hgbot | Note Added: 0170615 | |
2024-10-21 07:41 | hgbot | Note Added: 0170616 | |
2024-10-21 07:41 | hgbot | Note Added: 0170617 | |
2024-10-21 07:41 | hgbot | Note Added: 0170618 | |
2024-10-21 07:42 | hgbot | Note Added: 0170619 | |
2024-10-21 07:42 | hgbot | Note Added: 0170620 | |
2024-10-21 07:42 | hgbot | Note Added: 0170621 | |
2024-10-21 07:42 | hgbot | Note Added: 0170622 | |
2024-10-21 07:43 | hgbot | Note Added: 0170623 | |
2024-10-21 07:43 | hgbot | Note Added: 0170624 | |
2024-10-21 07:43 | hgbot | Resolution | open => fixed |
2024-10-21 07:43 | hgbot | Status | scheduled => closed |
2024-10-21 07:43 | hgbot | Fixed in Version | => 25Q1 |
2024-10-21 07:43 | hgbot | Note Added: 0170625 | |
2024-10-21 07:43 | hgbot | Note Added: 0170626 | |
2024-10-21 07:50 | hgbot | Note Added: 0170629 | |
2024-10-21 07:51 | marvintm | Note Added: 0170630 | |
Notes |
|
(0169931)
|
hgbot
|
2024-10-03 10:34
|
|
|
|
(0169932)
|
hgbot
|
2024-10-03 10:36
|
|
|
|
(0169933)
|
hgbot
|
2024-10-03 10:37
|
|
|
|
(0169934)
|
hgbot
|
2024-10-03 10:38
|
|
|
|
(0169935)
|
hgbot
|
2024-10-03 10:38
|
|
|
|
(0169937)
|
hgbot
|
2024-10-03 10:39
|
|
|
|
(0169938)
|
hgbot
|
2024-10-03 10:40
|
|
|
|
(0169939)
|
hgbot
|
2024-10-03 10:40
|
|
|
|
(0169940)
|
hgbot
|
2024-10-03 10:40
|
|
|
|
(0170611)
|
hgbot
|
2024-10-21 07:40
|
|
|
|
(0170612)
|
hgbot
|
2024-10-21 07:40
|
|
|
|
(0170613)
|
hgbot
|
2024-10-21 07:40
|
|
|
|
(0170614)
|
hgbot
|
2024-10-21 07:40
|
|
|
|
(0170615)
|
hgbot
|
2024-10-21 07:41
|
|
|
|
(0170616)
|
hgbot
|
2024-10-21 07:41
|
|
|
|
(0170617)
|
hgbot
|
2024-10-21 07:41
|
|
|
|
(0170618)
|
hgbot
|
2024-10-21 07:41
|
|
|
|
(0170619)
|
hgbot
|
2024-10-21 07:42
|
|
|
|
(0170620)
|
hgbot
|
2024-10-21 07:42
|
|
|
|
(0170621)
|
hgbot
|
2024-10-21 07:42
|
|
|
|
(0170622)
|
hgbot
|
2024-10-21 07:42
|
|
|
|
(0170623)
|
hgbot
|
2024-10-21 07:43
|
|
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: bf5aaf58d22bda39848370f9ab1d2a384aada06b
Author: Bimla Mayavan <b.mayavan@external.orisha.com>
Date: 21-10-2024 05:43:10
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/bf5aaf58d22bda39848370f9ab1d2a384aada06b [^]
Related ISSUE-53674: Removed unwanted/empty scss files
---
M web-jspack/org.openbravo.core2/src/components/Clock/Clock.jsx
M web-jspack/org.openbravo.core2/src/components/Grid/DataGrid/BaseRowContent.jsx
M web-jspack/org.openbravo.core2/src/components/Grid/PopoverMenuTitle.jsx
M web-jspack/org.openbravo.core2/src/components/MultiButtonStandardDialog/MultiButtonBar.jsx
M web-jspack/org.openbravo.core2/src/components/MultiStepProcess/MultiStepProcess.jsx
M web-jspack/org.openbravo.core2/src/components/MultiStepProcess/MultiStepProcessExtraComponents/MultiStepProcessExtraComponents.jsx
M web-jspack/org.openbravo.core2/src/components/PropertyButton/PropertyButton.jsx
R web-jspack/org.openbravo.core2/src/components/Clock/Clock.scss
R web-jspack/org.openbravo.core2/src/components/Grid/DataGrid/BaseRowContent.scss
R web-jspack/org.openbravo.core2/src/components/Grid/PopoverMenuAction.scss
R web-jspack/org.openbravo.core2/src/components/Grid/PopoverMenuTitle.scss
R web-jspack/org.openbravo.core2/src/components/LoadingKeymap/LoadingKeymap.scss
R web-jspack/org.openbravo.core2/src/components/MultiButtonStandardDialog/MultiButtonBar.scss
R web-jspack/org.openbravo.core2/src/components/MultiStepProcess/MultiStepProcess.scss
R web-jspack/org.openbravo.core2/src/components/MultiStepProcess/MultiStepProcessExtraComponents/MultiStepProcessExtraComponents.scss
R web-jspack/org.openbravo.core2/src/components/MultiStepProcess/MultiStepProcessSubtitle/MultiStepProcessSubtitle.scss
R web-jspack/org.openbravo.core2/src/components/MultiStepProcess/MultiStepProcessWindow/MultiStepProcessWindow.scss
R web-jspack/org.openbravo.core2/src/components/PropertyButton/PropertyButton.scss
---
|
|
|
(0170624)
|
hgbot
|
2024-10-21 07:43
|
|
|
|
(0170625)
|
hgbot
|
2024-10-21 07:43
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 0da7e53ad47b154b2486cf26256149ea9201d588
Author: Bimla Mayavan <b.mayavan@external.orisha.com>
Date: 21-10-2024 05:43:26
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0da7e53ad47b154b2486cf26256149ea9201d588 [^]
Fixed ISSUE-53674: Removed unwanted/empty scss files
---
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/PostPrintAndCloseStep/PostPrintAndCloseStep.jsx
M web-jspack/org.openbravo.pos2/src/components/Cashup/SafeboxDrawerMenuButton/SafeboxDrawerMenuButton.jsx
M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerFormSelector/CustomerFormSelector.jsx
M web-jspack/org.openbravo.pos2/src/components/Exchange/ExchangeProductSelector/ExchangeOrderLineWrapper/ExchangeOrderLineWrapper.jsx
M web-jspack/org.openbravo.pos2/src/components/Exchange/ExchangeProductSelector/ExchangePriceWrapper/ExchangePriceWrapper.jsx
M web-jspack/org.openbravo.pos2/src/components/Exchange/ExchangeProductSelector/ExchangeQuantityInputRenderCellWrapper/ExchangeQuantityInputRenderCellWrapper.jsx
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/EditableLayout/EditableLayoutItem/EditableLayoutItem.jsx
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorLayout/KeymapEditorResolutionSelector/KeymapEditorResolutionSelector.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PrepaymentEditButton/PrepaymentEditButton.jsx
M web-jspack/org.openbravo.pos2/src/components/ProductCategoryKeymap/ProductCategoryKeymap.jsx
M web-jspack/org.openbravo.pos2/src/components/ProductKeymap/ProductKeymap.jsx
M web-jspack/org.openbravo.pos2/src/components/ProofOfPayment/ProofOfPaymentDetails/ProofOfPaymentDetailLine/ProofOfPaymentDetailLine.jsx
M web-jspack/org.openbravo.pos2/src/components/ProofOfPayment/ProofOfPaymentHeader/ProofOfPaymentFillConfigDialog/ProofOfPaymentFillConfigDialog.jsx
M web-jspack/org.openbravo.pos2/src/components/ProofOfPayment/ProofOfPaymentHeader/ProofOfPaymentPartConfigDialog/ProofOfPaymentPartConfigDialog.jsx
M web-jspack/org.openbravo.pos2/src/components/ReceiptDeliveryOptions/BookedReceiptDeliveryOptions/BookedReceiptDeliveryGiftReceiptLineSelector/BookedReceiptDeliveryGiftReceiptLineSelectorQtyInputCellWrapper/BookedReceiptDeliveryGiftReceiptLineSelectorQtyInputCellWrapper.jsx
M web-jspack/org.openbravo.pos2/src/components/SafeboxHistory/SafeboxHistorySteps/PrintSafeboxHistoryReportStep/PrintSafeboxHistoryReportStep.jsx
M web-jspack/org.openbravo.pos2/src/components/SafeboxHistory/SafeboxHistorySubtitles/SafeboxHistoryDateSubtitle/SafeboxHistoryDateSubtitle.jsx
M web-jspack/org.openbravo.pos2/src/components/SafeboxHistory/SafeboxHistorySubtitles/SafeboxHistoryDrawerSubtitle/SafeboxHistoryDrawerSubtitle.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketArea/TicketLinesWindow/TicketLinesWindow.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPButton/TicketBPButton.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLineCoupon/TicketLineCoupon.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePager/TicketLinePager.jsx
M web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListRemoteGrid/TicketListRemoteGridBPFilter.jsx
M web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListRemoteGrid/TicketListRemoteGridStoreFilter.jsx
M web-jspack/org.openbravo.pos2/src/components/VerifiedReturns/VerifiedReturnsGrid/QuantityInputRenderCellWrapper/QuantityInputRenderCellWrapper.jsx
M web-jspack/org.openbravo.pos2/src/components/VerifiedReturns/VerifiedReturnsGrid/RemainingQuantityWrapper/RemainingQuantityWrapper.jsx
M web-jspack/org.openbravo.pos2/src/components/VerifiedReturns/VerifiedReturnsGrid/TicketLineRenderCellWrapper/TicketLineRenderCellWrapper.jsx
R web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/PostPrintAndCloseStep/PostPrintAndCloseStep.scss
R web-jspack/org.openbravo.pos2/src/components/Cashup/SafeboxDrawerMenuButton/SafeboxDrawerMenuButton.scss
R web-jspack/org.openbravo.pos2/src/components/Customer/CustomerFormSelector/CustomerFormSelector.scss
R web-jspack/org.openbravo.pos2/src/components/Exchange/ExchangeProductSelector/ExchangeOrderLineWrapper/ExchangeOrderLineWrapper.scss
R web-jspack/org.openbravo.pos2/src/components/Exchange/ExchangeProductSelector/ExchangePriceWrapper/ExchangePriceWrapper.scss
R web-jspack/org.openbravo.pos2/src/components/Exchange/ExchangeProductSelector/ExchangeQuantityInputRenderCellWrapper/ExchangeQuantityInputRenderCellWrapper.scss
R web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/EditableLayout/EditableLayoutItem/EditableLayoutItem.scss
R web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorLayout/KeymapEditorResolutionSelector/KeymapEditorResolutionSelector.scss
R web-jspack/org.openbravo.pos2/src/components/Payments/PrepaymentEditButton/PrepaymentEditButton.scss
R web-jspack/org.openbravo.pos2/src/components/ProductCategoryKeymap/ProductCategoryKeymap.scss
R web-jspack/org.openbravo.pos2/src/components/ProductKeymap/ProductKeymap.scss
R web-jspack/org.openbravo.pos2/src/components/ProofOfPayment/ProofOfPaymentDetails/ProofOfPaymentDetailLine/ProofOfPaymentDetailLine.scss
R web-jspack/org.openbravo.pos2/src/components/ProofOfPayment/ProofOfPaymentHeader/ProofOfPaymentFillConfigDialog/ProofOfPaymentFillConfigDialog.scss
R web-jspack/org.openbravo.pos2/src/components/ProofOfPayment/ProofOfPaymentHeader/ProofOfPaymentPartConfigDialog/ProofOfPaymentPartConfigDialog.scss
R web-jspack/org.openbravo.pos2/src/components/ReceiptDeliveryOptions/BookedReceiptDeliveryOptions/BookedReceiptDeliveryGiftReceiptLineSelector/BookedReceiptDeliveryGiftReceiptLineSelectorQtyInputCellWrapper/BookedReceiptDeliveryGiftReceiptLineSelectorQtyInputCellWrapper.scss
R web-jspack/org.openbravo.pos2/src/components/SafeboxHistory/SafeboxHistorySteps/PrintSafeboxHistoryReportStep/PrintSafeboxHistoryReportStep.scss
R web-jspack/org.openbravo.pos2/src/components/SafeboxHistory/SafeboxHistorySubtitles/SafeboxHistoryDateSubtitle/SafeboxHistoryDateSubtitle.scss
R web-jspack/org.openbravo.pos2/src/components/SafeboxHistory/SafeboxHistorySubtitles/SafeboxHistoryDrawerSubtitle/SafeboxHistoryDrawerSubtitle.scss
R web-jspack/org.openbravo.pos2/src/components/Ticket/TicketArea/TicketLinesWindow/TicketLinesWindow.scss
R web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPButton/TicketBPButton.scss
R web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLineCoupon/TicketLineCoupon.scss
R web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLineNote/TicketLineNote.scss
R web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePager/TicketLinePager.scss
R web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListRemoteGrid/TicketListRemoteGridBPFilter.scss
R web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListRemoteGrid/TicketListRemoteGridStoreFilter.scss
R web-jspack/org.openbravo.pos2/src/components/VerifiedReturns/VerifiedReturnsGrid/QuantityInputRenderCellWrapper/QuantityInputRenderCellWrapper.scss
R web-jspack/org.openbravo.pos2/src/components/VerifiedReturns/VerifiedReturnsGrid/RemainingQuantityWrapper/RemainingQuantityWrapper.scss
R web-jspack/org.openbravo.pos2/src/components/VerifiedReturns/VerifiedReturnsGrid/TicketLineRenderCellWrapper/TicketLineRenderCellWrapper.scss
R web-jspack/org.openbravo.pos2/src/components/VerifiedReturns/VerifiedReturnsGrid/TicketLineRenderCellWrapper/VerifiedReturnsInfoGrid.scss
---
|
|
|
(0170626)
|
hgbot
|
2024-10-21 07:43
|
|
|
|
(0170629)
|
hgbot
|
2024-10-21 07:50
|
|
|
|
|
|