Openbravo Issue Tracking System - Openbravo Localizations
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053657Openbravo LocalizationsLocalization Italypublic2023-10-13 12:242023-11-06 18:00
Reporterngarcia 
Assigned Toifernandez 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Support ticket
OBNetwork customer
Regression introduced in release
Summary0053657: CodiceArticolo section is added with CodiceTipo property but without CodiceValore property if the product doesn't have UPC
DescriptionCodiceArticolo section is added with CodiceTipo property but without CodiceValore property if the product doesn't have UPC
Steps To ReproduceCreate an invoice for Italy:
Add a product without UPC defined
Add a product with UPC defined

Launch the Export Italy Invoices to a XML file background process

Check the XML attached to the invoice has the following lines:

<NumeroLinea>1</NumeroLinea>
<CodiceArticolo>
<CodiceTipo>EAN</CodiceTipo>
<CodiceValore>value</CodiceValore>
</CodiceArticolo>
...
<NumeroLinea>2</NumeroLinea>
<CodiceArticolo>
<CodiceTipo>EAN</CodiceTipo>
</CodiceArticolo>
...

This file is not accepted by the tax authorities:

The element 'Codice Articolo' has incomplete content. List of possible elements expected: 'Codice Valore'
Proposed SolutionCheck if the whole CodiceArticolo section should be removed from the line when a product doesn't have a UPC defined
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng CodiceArticulo.png (25,418) 2023-10-26 11:49
https://issues.openbravo.com/file_download.php?file_id=19097&type=bug
png

xml IT06026940012_0lg4l.xml (3,470) 2023-10-26 11:49
https://issues.openbravo.com/file_download.php?file_id=19098&type=bug
xml IT06026940012_0lg4l_sinObjetoCodiceArticolo.xml (3,380) 2023-10-26 11:49
https://issues.openbravo.com/file_download.php?file_id=19099&type=bug
Issue History
Date ModifiedUsernameFieldChange
2023-10-13 12:24ngarciaNew Issue
2023-10-13 12:24ngarciaAssigned To => psanjuan
2023-10-25 15:48psanjuanNote Added: 0156284
2023-10-26 11:48psanjuanNote Edited: 0156284bug_revision_view_page.php?bugnote_id=0156284#r27042
2023-10-26 11:48psanjuanNote Edited: 0156284bug_revision_view_page.php?bugnote_id=0156284#r27043
2023-10-26 11:49psanjuanFile Added: CodiceArticulo.png
2023-10-26 11:49psanjuanFile Added: IT06026940012_0lg4l.xml
2023-10-26 11:49psanjuanFile Added: IT06026940012_0lg4l_sinObjetoCodiceArticolo.xml
2023-10-26 11:52psanjuanAssigned Topsanjuan => Triage Omni OMS
2023-10-31 17:16hgbotNote Added: 0156570
2023-11-02 10:35ifernandezAssigned ToTriage Omni OMS => ifernandez
2023-11-06 18:00hgbotNote Added: 0156788
2023-11-06 18:00hgbotResolutionopen => fixed
2023-11-06 18:00hgbotStatusnew => closed
2023-11-06 18:00hgbotNote Added: 0156789

Notes
(0156284)
psanjuan   
2023-10-25 15:48   
(edited on: 2023-10-26 11:48)
The values accepted on the node CodiceTipo are the ones listed below:
TARIC,CPV, EAN, SSC, ...), all of them are "regulated" accorndingly.

TARIC - The TARIC Code (Integrated Tariff Rate System) is a system used in the EU to determine the taxes and duties applicable to the import or export of goods.
CPV - The common procurement vocabulary (CPV) establishes a single classification system for public procurement aimed at standardising the references used by contracting authorities and entities to describe procurement contracts
EAN - EAN stands for ‘European Article Number’.
SSC - Serial Shipping Container Code can be used by companies to identify a logistic unit, which can be any combination of trade items packaged together for storage and/ or transport purposes; for example a case, pallet or parcel.

If no EAN/UPC is defined for the product included in the e-invoice, the node <CodiceArticolo> will have to be empty, as it is not mandatory [0,n]

This last scenario is working. See image and XML attached
(0156570)
hgbot   
2023-10-31 17:16   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.italy.einvoice/-/merge_requests/36 [^]
(0156788)
hgbot   
2023-11-06 18:00   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.italy.einvoice/-/merge_requests/36 [^]
(0156789)
hgbot   
2023-11-06 18:00   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.italy.einvoice [^]
Changeset: f417585160b0cd28be72debbc96105585a647d79
Author: Íñigo Fernández <inigo.fernandez@openbravo.com>
Date: 06-11-2023 17:00:55
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.italy.einvoice/-/commit/f417585160b0cd28be72debbc96105585a647d79 [^]

Fixes ISSUE-53657: CodiceArticolo section is added with CodiceTipo property but without CodiceValore property if the product doesn't have UPC

---
M src-test/org/openbravo/localization/italy/einvoice/TestItalyXMLCreationFromJson.java
M src/org/openbravo/localization/italy/einvoice/xmlengine/document/ItalyCodiceArticolo.java
M src/org/openbravo/localization/italy/einvoice/xmlengine/document/ItalyDettaglioLinee.java
---