Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053628POS2POSpublic2023-10-10 04:142023-10-10 12:50
Reporterprakashmurugesan88 
Assigned Toprakashmurugesan88 
PrioritynormalSeveritycriticalReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version24Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053628: Cashup Process Fails if Coins and Bills >= 1000
DescriptionCashup Process Fails if Coins and Bills >= 1000

If Coins and Bills for a currency has value of >= 1000, the cashup process fails

Check image

Error in openbravo.log is:
2023-10-06 13:57:29,439 [Import Entry - 1] ERROR org.openbravo.retail.posterminal.ProcessCashClose - Cashup cannot be processed since error occurred in CashClose: Character , is neither a decimal digit number, decimal point, nor "e" notation exponential mark.
java.lang.NumberFormatException: Character , is neither a decimal digit number, decimal point, nor "e" notation exponential mark.
    at java.math.BigDecimal.<init>(BigDecimal.java:522) ~[?:?]
    at java.math.BigDecimal.<init>(BigDecimal.java:405) ~[?:?]
    at java.math.BigDecimal.<init>(BigDecimal.java:838) ~[?:?]
    at org.openbravo.pos2.UpdateCashupCountPerAmountHook.processCountPerAmountEntry(UpdateCashupCountPerAmountHook.java:73) ~[classes/:?]
    at org.openbravo.pos2.UpdateCashupCountPerAmountHook.exec(UpdateCashupCountPerAmountHook.java:59) ~[classes/:?]
    at org.openbravo.pos2.UpdateCashupCountPerAmountHook$Proxy$_$$_WeldClientProxy.exec(Unknown Source) ~[classes/:?]
    at org.openbravo.retail.posterminal.CashCloseProcessor.executeHooks(CashCloseProcessor.java:222) ~[classes/:?]
    at org.openbravo.retail.posterminal.CashCloseProcessor.processCashClose(CashCloseProcessor.java:197) ~[classes/:?]
    at org.openbravo.retail.posterminal.ProcessCashClose.doReconciliationAndInvoices(ProcessCashClose.java:518) [classes/:?]
    at org.openbravo.retail.posterminal.ProcessCashClose.saveRecord(ProcessCashClose.java:222) [classes/:?]
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:214) [classes/:?]
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:165) [classes/:?]
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:97) [classes/:?]
    at org.openbravo.mobile.core.process.MobileImportEntryProcessorRunnable.processEntry(MobileImportEntryProcessorRunnable.java:55) [classes/:?]
    at org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable.processEntry(CashUpImportEntryProcessor.java:80) [classes/:?]
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:430) [classes/:?]
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:347) [classes/:?]
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) [?:?]
    at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
    at java.lang.Thread.run(Thread.java:829) [?:?]



java.lang.NumberFormatException: Character , is neither a decimal digit number, decimal point, nor "e" notation exponential mark.
    at java.math.BigDecimal.<init>(BigDecimal.java:522) ~[?:?]




Steps To ReproduceSetup for a currency in Currency > Coins and Bills a bill of >=1000

Configure the payment method in touchpoint type has Count per Amount = 'Y'

In a totally new terminal, open till and do cashup

In openbravo.log, the cashup process will fail with above errors

The cashup will stay in obpos_app_cashup table with isprocessed=Y, and isprocessedbo=N: WRONG

But the cashup is not going to EWI: WRONG also

Then do a 2nd cashup (or subsequent cashups):

This 2nd cashup (or subsequent cashups) will go to EWI with error org.openbravo.base.exception.OBException: Previous cashup entries should be processed before processing the current cashup entry

This is NORMAL and OK since the previous cashup was not properly synchronized: this is expected behavior as per fix/mechanism introduced in Mantis
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0051404 scheduled gonzalo_fernandez If a payment method is configured with "Count per amount" in count payment in cash up, a EWI is generated 
Attached Filespng Screenshot+from+2023-10-07+06-29-37.png (59,942) 2023-10-10 12:50
https://issues.openbravo.com/file_download.php?file_id=19031&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2023-10-10 04:14prakashmurugesan88New Issue
2023-10-10 04:14prakashmurugesan88Assigned To => prakashmurugesan88
2023-10-10 04:14prakashmurugesan88File Added: Screenshot from 2023-10-07 06-29-37.png
2023-10-10 04:14prakashmurugesan88Triggers an Emergency Pack => No
2023-10-10 04:14prakashmurugesan88Statusnew => scheduled
2023-10-10 11:49hgbotNote Added: 0155728
2023-10-10 12:27hgbotResolutionopen => fixed
2023-10-10 12:27hgbotStatusscheduled => closed
2023-10-10 12:27hgbotFixed in Version => 24Q1
2023-10-10 12:27hgbotNote Added: 0155730
2023-10-10 12:27hgbotNote Added: 0155731
2023-10-10 12:49rafarodaFile Deleted: Screenshot from 2023-10-07 06-29-37.png
2023-10-10 12:50rafarodaFile Added: Screenshot+from+2023-10-07+06-29-37.png
2023-11-12 19:15rafarodaRelationship addedrelated to 0051404

Notes
(0155728)
hgbot   
2023-10-10 11:49   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2165 [^]
(0155730)
hgbot   
2023-10-10 12:27   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 4a23e39adec482f19478dac65690a4ce997923dc
Author: Prakash M <prakash@qualiantech.com>
Date: 10-10-2023 12:44:33
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/4a23e39adec482f19478dac65690a4ce997923dc [^]

Fixes ISSUE-53628: Include that key without the group separator
* Because of group separator instead of updating the quantity of existing countPerAmount
It creates new entry with another countPerAmount with group separator

---
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/SetCountedAmount.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/SetCountedAmount.js
---
(0155731)
hgbot   
2023-10-10 12:27   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2165 [^]