Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053618POS2POSpublic2023-10-09 09:322023-11-14 07:15
Reporterjorgewederago 
Assigned Tojorgewederago 
PriorityhighSeveritymajorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053618: Port and improve Number of Uses for Coupons
DescriptionIt is needed to port the number of uses functionality as well as to update the current approach
Steps To ReproduceN/A
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0053845 closed SABARINATH P [23Q4] Coupons marked as Single-Use allows multiple usages 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-10-09 09:32jorgewederagoNew Issue
2023-10-09 09:32jorgewederagoAssigned To => Retail
2023-10-09 09:32jorgewederagoTriggers an Emergency Pack => No
2023-10-09 09:34jorgewederagoStatusnew => acknowledged
2023-10-09 09:34jorgewederagoStatusacknowledged => scheduled
2023-10-11 02:28hgbotNote Added: 0155755
2023-10-17 03:24jorgewederagoAssigned ToRetail => jorgewederago
2023-10-30 03:01hgbotNote Added: 0156457
2023-10-30 03:01hgbotNote Added: 0156458
2023-10-31 06:35hgbotNote Added: 0156507
2023-10-31 06:52hgbotNote Added: 0156508
2023-11-03 11:36andre_montenegroRelationship addedrelated to 0053845
2023-11-09 09:25hgbotResolutionopen => fixed
2023-11-09 09:25hgbotStatusscheduled => closed
2023-11-09 09:25hgbotNote Added: 0156934
2023-11-09 09:25hgbotNote Added: 0156935
2023-11-09 09:25hgbotNote Added: 0156936
2023-11-09 09:26hgbotNote Added: 0156937
2023-11-09 09:26hgbotNote Added: 0156938
2023-11-09 09:26hgbotNote Added: 0156939
2023-11-09 09:26hgbotNote Added: 0156940
2023-11-09 09:26hgbotNote Added: 0156941
2023-11-09 09:26hgbotNote Added: 0156942
2023-11-09 09:26hgbotNote Added: 0156943
2023-11-09 09:26hgbotNote Added: 0156944
2023-11-10 07:59hgbotNote Added: 0156999
2023-11-10 08:31hgbotNote Added: 0157003
2023-11-10 09:06hgbotNote Added: 0157009
2023-11-10 23:09hgbotNote Added: 0157050
2023-11-10 23:10hgbotNote Added: 0157051
2023-11-14 07:15hgbotNote Added: 0157119

Notes
(0155755)
hgbot   
2023-10-11 02:28   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/merge_requests/23 [^]
(0156457)
hgbot   
2023-10-30 03:01   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/25 [^]
(0156458)
hgbot   
2023-10-30 03:01   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.burn.coupon/-/merge_requests/7 [^]
(0156507)
hgbot   
2023-10-31 06:35   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/103 [^]
(0156508)
hgbot   
2023-10-31 06:52   
Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/344 [^]
(0156934)
hgbot   
2023-11-09 09:25   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons [^]
Changeset: 1ffeb1bdfbb8e8029011e316291fe4959fbc46d7
Author: Jorge Wederago <jorge.wederago@openbravo.com>
Date: 09-11-2023 17:13:14
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/commit/1ffeb1bdfbb8e8029011e316291fe4959fbc46d7 [^]

Fixed FR-53618: Port and improve Number of Uses for Coupons
*New configuration for the type of the discount
*New subtab to handle different uses
*Remove previous oneUse column
*Adding script to change previous configuration to the new one

---
A build/classes/org/openbravo/retail/discounts/coupons/modulescript/ModuleScriptCouponUses.class
A src-db/database/model/tables/OBDISCP_USAGE.xml
A src-util/modulescript/src/org/openbravo/retail/discounts/coupons/modulescript/ModuleScriptCouponUses.java
A src/org/openbravo/retail/discounts/coupons/DISCPUtils.java
M src-db/database/model/tables/OBDISCP_COUPON.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src-db/database/sourcedata/AD_TAB.xml
M src-db/database/sourcedata/AD_TABLE.xml
M src/org/openbravo/retail/discounts/coupons/CouponAvailability.java
M src/org/openbravo/retail/discounts/coupons/CouponUsed.java
M src/org/openbravo/retail/discounts/coupons/PreOrderLoaderHookCoupons.java
M src/org/openbravo/retail/discounts/coupons/event/CouponEventHandler.java
M web-jspack/org.openbravo.retail.discounts.coupons/src/model/ticket/actions/SearchAndAddCouponToTicketActionPreparation.js
M web-jspack/org.openbravo.retail.discounts.coupons/src/model/ticket/coupons/user-actions/AddCoupon.js
M web-jspack/org.openbravo.retail.discounts.coupons/src/services/scan/handlers/CouponScanEventHandler.js
---
(0156935)
hgbot   
2023-11-09 09:25   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons [^]
Changeset: a999a61bde9cbfcdb6692cdd94ce2a1fcff60867
Author: Jorge Wederago <jorge.wederago@openbravo.com>
Date: 09-11-2023 17:23:02
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/commit/a999a61bde9cbfcdb6692cdd94ce2a1fcff60867 [^]

Fixed FR-53618: Merge branch 'fr/53618'

---
A build/classes/org/openbravo/retail/discounts/coupons/modulescript/ModuleScriptCouponUses.class
A src-db/database/model/tables/OBDISCP_USAGE.xml
A src-util/modulescript/src/org/openbravo/retail/discounts/coupons/modulescript/ModuleScriptCouponUses.java
A src/org/openbravo/retail/discounts/coupons/DISCPUtils.java
A web-jspack/org.openbravo.retail.discounts.coupons/src/model/ticket/actions/__test__/SearchAndAddCouponToTicketActionPreparation.test.js
A web-test/model/business-object/ticket/TicketCouponUtils.test.js
M src-db/database/model/tables/OBDISCP_COUPON.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src-db/database/sourcedata/AD_TAB.xml
M src-db/database/sourcedata/AD_TABLE.xml
M src/org/openbravo/retail/discounts/coupons/CouponAvailability.java
M src/org/openbravo/retail/discounts/coupons/CouponUsed.java
M src/org/openbravo/retail/discounts/coupons/OrderLoaderHookCoupons.java
M src/org/openbravo/retail/discounts/coupons/event/CouponEventHandler.java
M web-jspack/org.openbravo.retail.discounts.coupons/src/model/ticket/actions/SearchAndAddCouponToTicketActionPreparation.js
M web-jspack/org.openbravo.retail.discounts.coupons/src/model/ticket/coupons/user-actions/AddCoupon.js
M web-jspack/org.openbravo.retail.discounts.coupons/src/services/scan/handlers/CouponScanEventHandler.js
M web/org.openbravo.retail.discounts.coupons/js/utils/utils.js
R src/org/openbravo/retail/discounts/coupons/PreOrderLoaderHookCoupons.java
---
(0156936)
hgbot   
2023-11-09 09:25   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/merge_requests/23 [^]
(0156937)
hgbot   
2023-11-09 09:26   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: 69e8ad68552061be89a7c698ccd596bd2d4a5eb8
Author: Jorge Wederago <jorge.wederago@openbravo.com>
Date: 09-11-2023 08:20:41
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/69e8ad68552061be89a7c698ccd596bd2d4a5eb8 [^]

Related to FR-53618: Update test to match new definitions

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/terminals/WebPOSExtModulesLoyaltyTerminalHelper.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_coupons/I40243_ScanCouponsToAddRemoveFromTicket.java
---
(0156938)
hgbot   
2023-11-09 09:26   
Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/344 [^]
(0156939)
hgbot   
2023-11-09 09:26   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/103 [^]
(0156940)
hgbot   
2023-11-09 09:26   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata [^]
Changeset: 59ddbf0cb0cde855043d8a7d7f0f8c51e7ff22c2
Author: Jorge Wederago <jorge.wederago@openbravo.com>
Date: 09-11-2023 08:20:37
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/commit/59ddbf0cb0cde855043d8a7d7f0f8c51e7ff22c2 [^]

Related to FR-53618: Update coupons sampledata to match new coupons model

---
M referencedata/sampledata/The_White_Valley_Group/OBDISCP_COUPON.xml
---
(0156941)
hgbot   
2023-11-09 09:26   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.burn.coupon [^]
Changeset: c48726b6362c4653eb93c1cb480fb08c8a58d326
Author: Jorge Wederago <jorge.wederago@openbravo.com>
Date: 30-10-2023 10:59:53
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.burn.coupon/-/commit/c48726b6362c4653eb93c1cb480fb08c8a58d326 [^]

Related to FR-53618: Adapting the code to the new coupon model

---
M src/org/openbravo/loyalty/burn/coupon/util/GenerateCouponUtils.java
---
(0156942)
hgbot   
2023-11-09 09:26   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.burn.coupon/-/merge_requests/7 [^]
(0156943)
hgbot   
2023-11-09 09:26   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/25 [^]
(0156944)
hgbot   
2023-11-09 09:26   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf [^]
Changeset: e7b19c6569e20cc2b7ba2d65c7f014dcbff1d22c
Author: Jorge Wederago <jorge.wederago@openbravo.com>
Date: 09-11-2023 08:20:33
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/commit/e7b19c6569e20cc2b7ba2d65c7f014dcbff1d22c [^]

Related to FR-53618: Adapting the code to the new coupon model

---
M src/org/openbravo/retail/discounts/coupons/otf/OrderLoaderHookOTFCoupons.java
---
(0156999)
hgbot   
2023-11-10 07:59   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons [^]
Changeset: d0880575a923cc8f827442b89cdafcf6ba0f12b3
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 10-11-2023 07:59:35
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/commit/d0880575a923cc8f827442b89cdafcf6ba0f12b3 [^]

Related to ISSUE-53618: Added element as it was used by other modules

---
M src-db/database/sourcedata/AD_ELEMENT.xml
---
(0157003)
hgbot   
2023-11-10 08:31   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.codegenerator [^]
Changeset: d0e58fa8934e545173deddfc18194e8789c56ce1
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 10-11-2023 08:31:04
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.codegenerator/-/commit/d0e58fa8934e545173deddfc18194e8789c56ce1 [^]

Related to ISSUE-53618: Adapted module to new usage API

---
M src/org/openbravo/retail/discounts/coupons/codegenerator/CodeGenerator.java
---
(0157009)
hgbot   
2023-11-10 09:06   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.codegenerator [^]
Changeset: 1fcc9e150b01a7674daad26e83db25ffd2deb6f8
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 10-11-2023 09:06:38
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.codegenerator/-/commit/1fcc9e150b01a7674daad26e83db25ffd2deb6f8 [^]

Related to ISSUE-53618: Removed unused variable

---
M src/org/openbravo/retail/discounts/coupons/codegenerator/CodeGenerator.java
---
(0157050)
hgbot   
2023-11-10 23:09   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons [^]
Changeset: 2779e2f2fd7ff53a0c7f388f61951e11e5b0e01b
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 10-11-2023 23:09:27
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/commit/2779e2f2fd7ff53a0c7f388f61951e11e5b0e01b [^]

Related to ISSUE-53618: Removed unused element

---
M src-db/database/sourcedata/AD_ELEMENT.xml
---
(0157051)
hgbot   
2023-11-10 23:10   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.codegenerator [^]
Changeset: 371fcfbf0e206734bf06e81b9d81fa24dfeab803
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 10-11-2023 23:09:59
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.codegenerator/-/commit/371fcfbf0e206734bf06e81b9d81fa24dfeab803 [^]

Related to ISSUE-53618: Added referenced element

---
M src-db/database/sourcedata/AD_ELEMENT.xml
---
(0157119)
hgbot   
2023-11-14 07:15   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.codegenerator [^]
Changeset: 879f0c887f8c4428698b2848f562ed17f5282dfa
Author: Jorge Wederago <jorge.wederago@openbravo.com>
Date: 14-11-2023 15:15:03
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.codegenerator/-/commit/879f0c887f8c4428698b2848f562ed17f5282dfa [^]

Related to ISSUE-53618: Code updated to be compatible with the new API

---
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
M src/org/openbravo/retail/discounts/coupons/codegenerator/CodeGenerator.java
---