Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053611POS2POSpublic2023-10-06 11:312023-11-16 14:47
Reporterrafaroda 
Assigned Todcontrera 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version24Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053611: Create a new USER ACTION for accessing PAYMENTS AND MOVEMENTS in CASHUP process
DescriptionCreate a new USER ACTION for accessing PAYMENTS AND MOVEMENTS in CASHUP process

Today, the option PAYMENTS AND MOVEMENTS in CASHUP process is driven by the Preference "Hide count Information to cashier"
* If Preference "Hide count Information to cashier" = N, this option is displayed
* If Preference "Hide count Information to cashier" = Y, this option is hidden


Option PAYMENTS AND MOVEMENTS in CASHUP process should NOT be driven by Preference "Hide count Information to cashier" but rather by a USER ACTION for it

If the new User Action is configured for the role, the Option PAYMENTS AND MOVEMENTS in CASHUP process must be accessible, with the approvals if configured

If New User Action is NOT configured or configured Active = N, the option Option PAYMENTS AND MOVEMENTS in CASHUP process must not be accessible

Steps To ReproduceIn Live Builds https://livebuilds.openbravo.com/context/retail_pos2_modules_pgsql/web/pos/?terminal=VB-2 [^]

1) Create some tickets in POS 2 paying them in CASH
2) Start the cashup process and in the Step 1 for CASH you will see 3 dots
3) Click on the 3 dots to see the Payment and Movements: you will see the list of tickets done in Cash for this cashup session (see images attached)

Now go to backoffice and configure Preference "Hide count Information to cashier" = Y

Login and logout of POS
1) Create some tickets in POS 2 paying them in CASH
2) Start the cashup process and in the Step 1 for CASH you the 3 dots have disappeared
Proposed SolutionOption PAYMENTS AND MOVEMENTS in CASHUP process should NOT be driven by Preference "Hide count Information to cashier" but rather by a USER ACTION for it

If the new User Action is configured for the role, the Option PAYMENTS AND MOVEMENTS in CASHUP process must be accessible, with the approvals if configured

If New User Action is NOT configured or configured Active = N, the option Option PAYMENTS AND MOVEMENTS in CASHUP process must not be accessible
Additional Information
TagsNo tags attached.
Relationships
related to defect 0053000 closed Retail Setting the environment for a blind cash up it is possible to know the theoretical amount to count 
related to defect 0050137 closed sreehari Preference "Hide count Information to cashier" allow to see movement when closing the till 
Attached Filespng Screenshot from 2023-10-05 09-09-31.png (101,496) 2023-10-06 11:31
https://issues.openbravo.com/file_download.php?file_id=19019&type=bug
png

png Screenshot from 2023-10-05 09-09-42.png (93,478) 2023-10-06 11:32
https://issues.openbravo.com/file_download.php?file_id=19020&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2023-10-06 11:31rafarodaNew Issue
2023-10-06 11:31rafarodaAssigned To => Retail
2023-10-06 11:31rafarodaFile Added: Screenshot from 2023-10-05 09-09-31.png
2023-10-06 11:31rafarodaTriggers an Emergency Pack => No
2023-10-06 11:32rafarodaFile Added: Screenshot from 2023-10-05 09-09-42.png
2023-10-06 11:34rafarodaRelationship addedrelated to 0053000
2023-10-06 11:35rafarodaRelationship addedrelated to 0050137
2023-10-24 21:14dcontreraAssigned ToRetail => dcontrera
2023-10-24 21:38hgbotNote Added: 0156249
2023-10-27 07:55hgbotResolutionopen => fixed
2023-10-27 07:55hgbotStatusnew => closed
2023-10-27 07:55hgbotFixed in Version => 24Q1
2023-10-27 07:55hgbotNote Added: 0156431
2023-10-27 07:55hgbotNote Added: 0156432
2023-11-07 01:40dcontreraStatusclosed => new
2023-11-07 01:40dcontreraResolutionfixed => open
2023-11-07 01:40dcontreraFixed in Version24Q1 =>
2023-11-07 01:46hgbotNote Added: 0156799
2023-11-07 17:26hgbotNote Added: 0156879
2023-11-07 17:26hgbotResolutionopen => fixed
2023-11-07 17:26hgbotStatusnew => closed
2023-11-07 17:26hgbotFixed in Version => 24Q1
2023-11-07 17:26hgbotNote Added: 0156880
2023-11-07 17:26hgbotNote Added: 0156881
2023-11-09 15:00hgbotNote Added: 0156977
2023-11-15 19:14hgbotNote Added: 0157182
2023-11-16 10:51marvintmNote Added: 0157201
2023-11-16 10:51marvintmStatusclosed => new
2023-11-16 10:51marvintmResolutionfixed => open
2023-11-16 10:51marvintmFixed in Version24Q1 =>
2023-11-16 14:47hgbotResolutionopen => fixed
2023-11-16 14:47hgbotStatusnew => closed
2023-11-16 14:47hgbotFixed in Version => 24Q1
2023-11-16 14:47hgbotNote Added: 0157228
2023-11-16 14:47hgbotNote Added: 0157229

Notes
(0156249)
hgbot   
2023-10-24 21:38   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2202 [^]
(0156431)
hgbot   
2023-10-27 07:55   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 51444b645f5785990814dcfdd1e9c60e91013d15
Author: Dante Contrera <dante.contrera@smfconsulting.es>
Date: 27-10-2023 05:55:12
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/51444b645f5785990814dcfdd1e9c60e91013d15 [^]

Fixed ISSUE-53611: User action to manage access to Payments and Movements in Cashup process added.

---
A web-jspack/org.openbravo.pos2/src/model/cashup/actions/ShowCountInfo.js
A web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/cashup/ShowCountInfo.js
M src-db/database/sourcedata/OBC2_USER_ACTION.xml
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/CountDisplay/TransactionsPopoverButton.jsx
M web-jspack/org.openbravo.pos2/src/model/cashup/CashupExtension.js
M web-jspack/org.openbravo.pos2/src/ob-init.js
---
(0156432)
hgbot   
2023-10-27 07:55   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2202 [^]
(0156799)
hgbot   
2023-11-07 01:46   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2226 [^]
(0156879)
hgbot   
2023-11-07 17:26   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2226 [^]
(0156880)
hgbot   
2023-11-07 17:26   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 64236fde63cbee80374059f8dea5939a2aeea397
Author: dante.contrera <dante.contrera@smfconsulting.es>
Date: 07-11-2023 16:26:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/64236fde63cbee80374059f8dea5939a2aeea397 [^]

Fixed ISSUE-53611: Show the Payments and Movementes button for all payments.

---
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/CountDisplay/CountDisplay.jsx
---
(0156881)
hgbot   
2023-11-07 17:26   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: f7cd6c738c78cd4ca417a01576caeded74a3a867
Author: dante.contrera <dante.contrera@smfconsulting.es>
Date: 07-11-2023 16:26:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/f7cd6c738c78cd4ca417a01576caeded74a3a867 [^]

Fixed ISSUE-53611: Jest test removed.

---
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/CountDisplay/__test__/CountDisplay.test.jsx
---
(0156977)
hgbot   
2023-11-09 15:00   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: e5cbd59594607e33a281e62c70798426657a21f3
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 09-11-2023 15:00:29
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/e5cbd59594607e33a281e62c70798426657a21f3 [^]

Related to ISSUE-53611: Reverted the previous change, as it was incorrectly forcing some properties to be shown even if the preference was enabled.

---
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/CountDisplay/CountDisplay.jsx
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/CountDisplay/__test__/CountDisplay.test.jsx
---
(0157182)
hgbot   
2023-11-15 19:14   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2238 [^]
(0157201)
marvintm   
2023-11-16 10:51   
There is still a problem with this issue, so reopening it until we fix it
(0157228)
hgbot   
2023-11-16 14:47   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 0e11628bca4b814a8750e6302e00cadcfa5c5dbe
Author: Dante Contrera <dante.contrera@smfconsulting.es>
Date: 16-11-2023 13:47:48
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0e11628bca4b814a8750e6302e00cadcfa5c5dbe [^]

Fixed ISSUE-53611: Now the Payments and Movements option and the related contextual menu will be shown in the Cashup window even if the sensitive columns are hidden

---
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/CountDisplay/CountDisplay.jsx
---
(0157229)
hgbot   
2023-11-16 14:47   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2238 [^]