Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053553POS2POSpublic2023-09-26 15:482023-10-11 13:35
Reporterguilleaer 
Assigned ToRajesh_18 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053553: Wrong managmente of address1 and address2 from POS2 and enyoPOS
DescriptionCurrently in enyoPOS & POS2 when an OB address is edited the form shows just one field (let's call it addressName), however in the backoffice the address is conformed by 2 fields Address1 and Address2.

Problem:
When a customer address is edited in POS (POS2/EnyoPOS) the field which is edited (addressName) is built concatenating address1 and address2 (both from back office) but when it is sent back to backoffice the content of addressName is stored on the column address1 of the database storing a wrong value
Steps To ReproduceHaving in backoffice
Address1; Estafeta
Address2: 25

In POS/enyoPOS open the customer address edit form and check that the value of addressName is "Estafeta 25" (Concatenation of address 1 and address 2).

If this field is edited (new value is "Estafeta 26") then the backoffice assumes that addressName matches with address1 so we create a problem

Result in backoffice
Address1 -> Estafeta 16 (concat of add1 and add2)
Address2 -> 25 (remains as it is)

Next time that address is loaded in POS/enyoPOS the content of the field addressName will be "Estafeta 16 25"

What we should do?
Proposed SolutionAdd a new field to the form in POS2/enyoPOS which will not be mandatory with label "Apartment, suite, floor, etc". It will match with the address2 field of the backoffice
Update the field of the form to Address. It must be mandatory
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-09-26 15:48guilleaerNew Issue
2023-09-26 15:48guilleaerAssigned To => Retail
2023-09-26 15:48guilleaerTriggers an Emergency Pack => No
2023-09-26 16:56dbazNote Added: 0155264
2023-09-26 17:39guilleaerProposed Solution updated
2023-09-26 17:43guilleaerProposed Solution updated
2023-09-27 12:00Rajesh_18Assigned ToRetail => Rajesh_18
2023-09-27 12:00Rajesh_18Statusnew => acknowledged
2023-09-28 07:06Rajesh_18Statusacknowledged => scheduled
2023-10-03 06:38hgbotNote Added: 0155411
2023-10-03 06:51hgbotNote Added: 0155412
2023-10-06 12:04hgbotNote Added: 0155633
2023-10-06 12:04hgbotNote Added: 0155634
2023-10-06 12:05hgbotNote Added: 0155635
2023-10-06 12:05hgbotResolutionopen => fixed
2023-10-06 12:05hgbotStatusscheduled => closed
2023-10-06 12:05hgbotFixed in Version => RR24Q1
2023-10-06 12:05hgbotNote Added: 0155636
2023-10-06 12:31hgbotNote Added: 0155638
2023-10-06 13:33hgbotNote Added: 0155642
2023-10-07 11:39hgbotNote Added: 0155648
2023-10-08 11:34hgbotNote Added: 0155649
2023-10-09 10:35hgbotNote Added: 0155660
2023-10-09 10:35hgbotNote Added: 0155661
2023-10-11 13:35hgbotNote Added: 0155784

Notes
(0155264)
dbaz   
2023-09-26 16:56   
Option a) but with a change of the labels displayed in the POS form.

Label of Address 1 (mandatory): Address
Label of Address 2 (optional): Apartment, suite, floor, etc.

https://baymard.com/blog/address-line-2 [^]
https://ux.shopify.com/designing-address-forms-for-everyone-everywhere-f481f6baf513 [^]
https://uxdesign.cc/best-practices-for-address-form-design-7d32bf7b7ff3 [^]
https://uxplanet.org/address-field-design-best-practices-a80390caaee0 [^]
https://www.uxmatters.com/mt/archives/2008/06/international-address-fields-in-web-forms.php [^]
(0155411)
hgbot   
2023-10-03 06:38   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2133 [^]
(0155412)
hgbot   
2023-10-03 06:51   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1370 [^]
(0155633)
hgbot   
2023-10-06 12:04   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: e782598d43a2323cfe53a98b4ddef513d3598b53
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 06-10-2023 09:26:38
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/e782598d43a2323cfe53a98b4ddef513d3598b53 [^]

Related ISSUE-53553: Added new Field Address line2 for customer

---
M referencedata/standard/CRM_Connector_for_Openbravo_Customers.xml
M src-db/database/sourcedata/AD_DATASET.xml
M web-jspack/org.openbravo.pos2/src/services/crm/OBCRMUtils.js
---
(0155634)
hgbot   
2023-10-06 12:04   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2133 [^]
(0155635)
hgbot   
2023-10-06 12:05   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1370 [^]
(0155636)
hgbot   
2023-10-06 12:05   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 9aaf6d94d3ca2d0fb674e727fe345914a171f171
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 06-10-2023 10:04:35
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/9aaf6d94d3ca2d0fb674e727fe345914a171f171 [^]

Fixes ISSUE-53553: Added new Field Address line2 for customer

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/posterminal/CustomerAddrLoader.java
M src/org/openbravo/retail/posterminal/master/BPLocationProperties.java
M web/org.openbravo.retail.posterminal/js/components/bplocation.js
M web/org.openbravo.retail.posterminal/js/components/businesspartner_selector.js
M web/org.openbravo.retail.posterminal/js/model/bplocation.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customeraddress/customeraddrdetailview.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customeraddress/editcreatecustomeraddress.js
---
(0155638)
hgbot   
2023-10-06 12:31   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: d6d66771c2cca54f1156803b2f6803b38c74d769
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 06-10-2023 12:30:55
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/d6d66771c2cca54f1156803b2f6803b38c74d769 [^]

Related to ISSUE-53553: Wrong StringUtils import

---
M src/org/openbravo/retail/posterminal/CustomerAddrLoader.java
---
(0155642)
hgbot   
2023-10-06 13:33   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: d5347248bb81c07f728d6fcb03fd27d4d9be3d9f
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 06-10-2023 13:33:10
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/d5347248bb81c07f728d6fcb03fd27d4d9be3d9f [^]

Related to ISSUE-53553: Change address2 label to fit with specification

---
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0155648)
hgbot   
2023-10-07 11:39   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata/-/merge_requests/58 [^]
(0155649)
hgbot   
2023-10-08 11:34   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: 94cc1614aefb0cf9cdb60907cc306fd74054021a
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 07-10-2023 12:02:21
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/94cc1614aefb0cf9cdb60907cc306fd74054021a [^]

Related to ISSUE-53553: Fix I38686_VerifyFullCustomerAddressIsVisibleInPOS test

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/customer/I38686_VerifyFullCustomerAddressIsVisibleInPOS.java
---
(0155660)
hgbot   
2023-10-09 10:35   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata [^]
Changeset: a20e3e9ba36cf9edd3755c1f615f9194e2ab5351
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 07-10-2023 11:37:34
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata/-/commit/a20e3e9ba36cf9edd3755c1f615f9194e2ab5351 [^]

Related to ISSUE-53553: Add crm address property

---
M referencedata/sampledata/The_White_Valley_Group/C_EXTBP_CONFIG_PROPERTY.xml
---
(0155661)
hgbot   
2023-10-09 10:35   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata/-/merge_requests/58 [^]
(0155784)
hgbot   
2023-10-11 13:35   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 872a27e4bbf1cb32d5dec92be3326ce6d2df650d
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 11-10-2023 13:35:14
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/872a27e4bbf1cb32d5dec92be3326ce6d2df650d [^]

Related to ISSUE-53553: Change address2 message to use uppercases

---
M src-db/database/sourcedata/AD_MESSAGE.xml
---