Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053531Openbravo ERP04. Warehouse managementpublic2023-09-22 15:302023-10-06 11:31
ReporterAtulOpenbravo 
Assigned ToAtulOpenbravo 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR24Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053531: [RM-7152] - Add unique identifier in good movements API
Description[SFS / ECOM] - Add unique identifier in good movements API

https://openbravo.atlassian.net/browse/RM-7152 [^]
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-09-22 15:30AtulOpenbravoNew Issue
2023-09-22 15:30AtulOpenbravoAssigned To => Triage Omni WMS
2023-09-22 15:30AtulOpenbravoOBNetwork customer => No
2023-09-22 15:30AtulOpenbravoModules => Core
2023-09-22 15:30AtulOpenbravoTriggers an Emergency Pack => No
2023-09-22 15:38AtulOpenbravoStatusnew => scheduled
2023-09-22 15:38AtulOpenbravoAssigned ToTriage Omni WMS => AtulOpenbravo
2023-09-22 15:44hgbotMerge Request Status => open
2023-09-22 15:44hgbotNote Added: 0155187
2023-09-22 17:45hgbotNote Added: 0155189
2023-09-26 22:13hgbotNote Added: 0155275
2023-09-28 10:09hgbotMerge Request Statusopen => approved
2023-09-29 07:47hgbotResolutionopen => fixed
2023-09-29 07:47hgbotStatusscheduled => closed
2023-09-29 07:47hgbotNote Added: 0155367
2023-09-29 07:47hgbotFixed in Version => PR23Q4
2023-09-29 07:47hgbotNote Added: 0155368
2023-09-29 08:51hgbotNote Added: 0155372
2023-09-29 08:51hgbotNote Added: 0155373
2023-09-29 08:51hgbotNote Added: 0155374
2023-09-29 08:51hgbotNote Added: 0155375
2023-09-29 08:51hgbotNote Added: 0155376
2023-09-29 08:51hgbotNote Added: 0155377
2023-09-29 08:51hgbotNote Added: 0155378
2023-10-02 12:08mtaalStatusclosed => new
2023-10-02 12:08mtaalResolutionfixed => open
2023-10-02 12:08mtaalFixed in VersionPR23Q4 =>
2023-10-02 12:08hgbotResolutionopen => fixed
2023-10-02 12:08hgbotStatusnew => closed
2023-10-02 12:08hgbotFixed in Version => PR23Q4
2023-10-02 12:08hgbotNote Added: 0155400
2023-10-02 12:09hgbotNote Added: 0155401
2023-10-02 12:10hgbotNote Added: 0155402
2023-10-02 12:15mtaalStatusclosed => new
2023-10-02 12:15mtaalResolutionfixed => open
2023-10-02 12:15mtaalFixed in VersionPR23Q4 =>
2023-10-03 06:12AtulOpenbravoStatusnew => scheduled
2023-10-03 06:15hgbotNote Added: 0155410
2023-10-03 11:45hgbotNote Added: 0155417
2023-10-03 11:45hgbotNote Added: 0155418
2023-10-03 11:46hgbotNote Added: 0155419
2023-10-03 11:46hgbotNote Added: 0155420
2023-10-04 11:08hgbotNote Added: 0155488
2023-10-04 11:42hgbotNote Added: 0155491
2023-10-04 11:42hgbotNote Added: 0155492
2023-10-04 12:07hgbotNote Added: 0155496
2023-10-04 12:07hgbotNote Added: 0155497
2023-10-04 13:11hgbotNote Added: 0155498
2023-10-04 13:13hgbotNote Added: 0155499
2023-10-06 11:29hgbotNote Added: 0155622
2023-10-06 11:29hgbotNote Added: 0155623
2023-10-06 11:30hgbotNote Added: 0155624
2023-10-06 11:30hgbotNote Added: 0155625
2023-10-06 11:30hgbotNote Added: 0155626
2023-10-06 11:30hgbotNote Added: 0155627
2023-10-06 11:30hgbotNote Added: 0155628
2023-10-06 11:30hgbotNote Added: 0155629
2023-10-06 11:30hgbotNote Added: 0155630
2023-10-06 11:31hgbotNote Added: 0155631
2023-10-06 11:31hgbotResolutionopen => fixed
2023-10-06 11:31hgbotStatusscheduled => closed
2023-10-06 11:31hgbotFixed in Version => PR24Q1
2023-10-06 11:31hgbotNote Added: 0155632

Notes
(0155187)
hgbot   
2023-09-22 15:44   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1005 [^]
(0155189)
hgbot   
2023-09-22 17:45   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/189 [^]
(0155275)
hgbot   
2023-09-26 22:13   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/merge_requests/47 [^]
(0155367)
hgbot   
2023-09-29 07:47   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1005 [^]
(0155368)
hgbot   
2023-09-29 07:47   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: baa99bc15832a7de8d25254758811b90520470a0
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 28-09-2023 21:03:34
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/baa99bc15832a7de8d25254758811b90520470a0 [^]

Fixes BUG-0053531: [RM-7152] -Add unique identifier in good
movements API

**Add event handler inorder to make sure document no is not
repeated in particular organization.
**Add message showing information that Goods Movement with
document no already exists in the particular organization.

---
A src/org/openbravo/event/GoodsMovementEventHandler.java
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0155372)
hgbot   
2023-09-29 08:51   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^]
Changeset: 3f333680b8f70f7c1e0b477995d7e2bbdd81400a
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 22-09-2023 21:12:40
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/3f333680b8f70f7c1e0b477995d7e2bbdd81400a [^]

Related To BUG-0053531: [RM-7152] - Add unique identifier in good
movements API

**Add documentNo property in Import Entity for Goods Movement.
**Add documentNo property in Export Entity for Goods Movement,
add export filter for document No, add export filter parameter
for documentNo property.

---
M src-db/database/sourcedata/API_EXPORT_FILTER.xml
M src-db/database/sourcedata/API_EXPORT_FILTER_PARAM.xml
M src-db/database/sourcedata/OBEI_PROP_MAP_INSTANCE.xml
---
(0155373)
hgbot   
2023-09-29 08:51   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^]
Changeset: 47b118f3bfe1dc00caef695ba57bef1922c918d8
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 29-09-2023 02:27:44
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/47b118f3bfe1dc00caef695ba57bef1922c918d8 [^]

Related to BUG-0053531: [RM-7152] - Add unique identifier in good
movements API

**Add postman collection for Goods Movement by DocumentNo Export
Service, add proper document no in the example.

---
M examples/Openbravo API.postman_collection.json
M src-db/database/sourcedata/API_EXPORT_FILTER_PARAM.xml
---
(0155374)
hgbot   
2023-09-29 08:51   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/189 [^]
(0155375)
hgbot   
2023-09-29 08:51   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/merge_requests/47 [^]
(0155378)
hgbot   
2023-09-29 08:51   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests [^]
Changeset: e5725f83bc01fb9d3785772d3937d732e32af370
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 29-09-2023 11:21:47
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/commit/e5725f83bc01fb9d3785772d3937d732e32af370 [^]

Related to BUG-0053531: [RM-7152] - Add unique identifier in good
movements API

**Update java doc with correct comments

---
M src-test/org/openbravo/api/tests/export/ApiExportGoodsMovementFilters.java
---
(0155377)
hgbot   
2023-09-29 08:51   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests [^]
Changeset: 0bac1f990f8325e4fa56f466c84fef07690d581d
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 29-09-2023 01:59:29
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/commit/0bac1f990f8325e4fa56f466c84fef07690d581d [^]

Related to BUG-0053531: [RM-7152] - Add unique identifier in good
movements API

**Fix test failures

---
M src-test/data/export/filter/goodsmovement/GoodsMvmtByDocumentNo.json
M src-test/org/openbravo/api/tests/util/ApiTestConstants.java
---
(0155376)
hgbot   
2023-09-29 08:51   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests [^]
Changeset: 0a30d43432bf92e67dc60b3c72b555c23383bea8
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 27-09-2023 01:44:46
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/commit/0a30d43432bf92e67dc60b3c72b555c23383bea8 [^]

Related to BUG-0053531: [RM-7152] - Add unique identifier in good
movements API

**Add tests for documentNo export filter

---
A src-test/data/export/filter/goodsmovement/GoodsMvmtByDocumentNo.json
M src-test/org/openbravo/api/tests/export/ApiExportGoodsMovementFilters.java
M src-test/org/openbravo/api/tests/util/ApiTestConstants.java
---
(0155400)
hgbot   
2023-10-02 12:08   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: d5fbb05d191d10656291529ac4436efe26d43a74
Author: Martin Taal <martin.taal@openbravo.com>
Date: 02-10-2023 10:08:39
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/d5fbb05d191d10656291529ac4436efe26d43a74 [^]

Revert "Fixes BUG-0053531: [RM-7152] -Add unique identifier in good"

This reverts commit baa99bc15832a7de8d25254758811b90520470a0
---
M src-db/database/sourcedata/AD_MESSAGE.xml
R src/org/openbravo/event/GoodsMovementEventHandler.java
---
(0155401)
hgbot   
2023-10-02 12:09   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^]
Changeset: 5980a12a1bf31764feb55a455fde7c281285e91e
Author: Martin Taal <martin.taal@openbravo.com>
Date: 02-10-2023 10:09:57
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/5980a12a1bf31764feb55a455fde7c281285e91e [^]

Revert "Related to BUG-0053531: [RM-7152] - Add unique identifier in good"

This reverts commit 47b118f3bfe1dc00caef695ba57bef1922c918d8
---
M examples/Openbravo API.postman_collection.json
M src-db/database/sourcedata/API_EXPORT_FILTER_PARAM.xml
---
(0155402)
hgbot   
2023-10-02 12:10   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests [^]
Changeset: 530006c85f658c3cb81554254b94f0be06ffe43c
Author: Martin Taal <martin.taal@openbravo.com>
Date: 02-10-2023 10:10:20
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/commit/530006c85f658c3cb81554254b94f0be06ffe43c [^]

Revert "Related to BUG-0053531: [RM-7152] - Add unique identifier in good"

This reverts commit e5725f83bc01fb9d3785772d3937d732e32af370
---
M src-test/org/openbravo/api/tests/export/ApiExportGoodsMovementFilters.java
---
(0155410)
hgbot   
2023-10-03 06:15   
Merge Request created: https://gitlab.com/openbravo/product/mods/org.openbravo.distributionorder/-/merge_requests/53 [^]
(0155417)
hgbot   
2023-10-03 11:45   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1010 [^]
(0155418)
hgbot   
2023-10-03 11:45   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/merge_requests/177 [^]
(0155419)
hgbot   
2023-10-03 11:46   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/191 [^]
(0155420)
hgbot   
2023-10-03 11:46   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/merge_requests/48 [^]
(0155488)
hgbot   
2023-10-04 11:08   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^]
Changeset: 1db998f8c1bfc7d98e497de5568dec95a28327f7
Author: Sandra Huguet <sandra.huguet@openbravo.com>
Date: 04-10-2023 10:55:44
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/1db998f8c1bfc7d98e497de5568dec95a28327f7 [^]

Revert "Related To BUG-0053531: [RM-7152] - Add unique identifier in good"

This reverts commit 3f333680b8f70f7c1e0b477995d7e2bbdd81400a.

---
M src-db/database/sourcedata/API_EXPORT_FILTER.xml
M src-db/database/sourcedata/API_EXPORT_FILTER_PARAM.xml
M src-db/database/sourcedata/OBEI_PROP_MAP_INSTANCE.xml
---
(0155491)
hgbot   
2023-10-04 11:42   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests [^]
Changeset: 53b539fc484c415554c3f08b4c4db123f8f7d483
Author: Sandra Huguet <sandra.huguet@openbravo.com>
Date: 04-10-2023 11:42:00
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/commit/53b539fc484c415554c3f08b4c4db123f8f7d483 [^]

Revert "Related to BUG-0053531: [RM-7152] - Add unique identifier in good"

This reverts commit 0bac1f990f8325e4fa56f466c84fef07690d581d.

---
M src-test/data/export/filter/goodsmovement/GoodsMvmtByDocumentNo.json
M src-test/org/openbravo/api/tests/util/ApiTestConstants.java
---
(0155492)
hgbot   
2023-10-04 11:42   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests [^]
Changeset: d9deebbf611cfab2e8f4f0eacb83bf66eb86db14
Author: Sandra Huguet <sandra.huguet@openbravo.com>
Date: 04-10-2023 11:42:13
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/commit/d9deebbf611cfab2e8f4f0eacb83bf66eb86db14 [^]

Revert "Related to BUG-0053531: [RM-7152] - Add unique identifier in good"

This reverts commit 0a30d43432bf92e67dc60b3c72b555c23383bea8.

---
M src-test/org/openbravo/api/tests/export/ApiExportGoodsMovementFilters.java
M src-test/org/openbravo/api/tests/util/ApiTestConstants.java
R src-test/data/export/filter/goodsmovement/GoodsMvmtByDocumentNo.json
---
(0155496)
hgbot   
2023-10-04 12:07   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/191 [^]
(0155497)
hgbot   
2023-10-04 12:07   
Merge request closed: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/merge_requests/48 [^]
(0155498)
hgbot   
2023-10-04 13:11   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/merge_requests/50 [^]
(0155499)
hgbot   
2023-10-04 13:13   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/193 [^]
(0155622)
hgbot   
2023-10-06 11:29   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^]
Changeset: c4de9ffae0dc50be8bb476ce82c2013fbf08114a
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 06-10-2023 09:29:41
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/c4de9ffae0dc50be8bb476ce82c2013fbf08114a [^]

Related to BUG-0053531: [RM-7152] - Add unique identifier in good
movements API

**Add documentNo property in Import Entity for Goods Movement.
**Add documentNo property in Export Entity for Goods Movement,
add export filter for document No, add export filter parameter
for documentNo property.

---
M examples/Openbravo API.postman_collection.json
M src-db/database/sourcedata/API_EXPORT_FILTER.xml
M src-db/database/sourcedata/API_EXPORT_FILTER_PARAM.xml
M src-db/database/sourcedata/OBEI_PROP_MAP_INSTANCE.xml
---
(0155623)
hgbot   
2023-10-06 11:29   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/193 [^]
(0155624)
hgbot   
2023-10-06 11:30   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests [^]
Changeset: 6ec772a9a86d896d1306c8c7096e1ac659c3dc24
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 06-10-2023 09:30:01
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/commit/6ec772a9a86d896d1306c8c7096e1ac659c3dc24 [^]

Related to BUG-0053531: [RM-7152] - Add unique identifier in good
movements API

**Add tests for documentNo export filter

---
A src-test/data/export/filter/goodsmovement/GoodsMvmtByDocumentNo.json
M src-test/org/openbravo/api/tests/export/ApiExportGoodsMovementFilters.java
M src-test/org/openbravo/api/tests/util/ApiTestConstants.java
---
(0155625)
hgbot   
2023-10-06 11:30   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/merge_requests/50 [^]
(0155626)
hgbot   
2023-10-06 11:30   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations [^]
Changeset: 2ecffd2bbd025336e64e86e69c23aac86c44f446
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 06-10-2023 02:30:39
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/commit/2ecffd2bbd025336e64e86e69c23aac86c44f446 [^]

Related to BUG-0053531: [RM-7152] - Add unique identifier in good
movements API

**Fix ci failures by avoiding duplicate documentno in movements

---
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/utils/AWOTestUtils.java
---
(0155627)
hgbot   
2023-10-06 11:30   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/merge_requests/177 [^]
(0155628)
hgbot   
2023-10-06 11:30   
Repository: https://gitlab.com/openbravo/product/mods/org.openbravo.distributionorder [^]
Changeset: 88ce74375d22f90751a4bd83526c4b6065f963d6
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 03-10-2023 17:19:07
URL: https://gitlab.com/openbravo/product/mods/org.openbravo.distributionorder/-/commit/88ce74375d22f90751a4bd83526c4b6065f963d6 [^]

Related to BUG-0053531: [RM-7152] - Add unique identifier in good
movements API

**When cloning movements in revert DO flow, same document number
cannot be used due to unique constraint implemented that does
not allow same document number to the movements in same org,
hence R* text is prefixed in document no to the reverted
movement.

---
M src/org/openbravo/distributionorder/erpCommon/utility/ProcessDistributionOrderUtil.java
---
(0155629)
hgbot   
2023-10-06 11:30   
Repository: https://gitlab.com/openbravo/product/mods/org.openbravo.distributionorder [^]
Changeset: 7b9518f9a0728629cf39390fc7906710e1ffc580
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 03-10-2023 17:19:07
URL: https://gitlab.com/openbravo/product/mods/org.openbravo.distributionorder/-/commit/7b9518f9a0728629cf39390fc7906710e1ffc580 [^]

Related to BUG-0053531: Code review improvements

**Remove document no length check logic as it seems irrelevant
**Get new document no from DocumentNo_M_Movement document sequence
if it is empty then go for adding reverse suffix *R* to the mvmt
document no which is being reversed.
**Set description as the REVERT + old document name.

---
M src/org/openbravo/distributionorder/erpCommon/utility/ProcessDistributionOrderUtil.java
---
(0155630)
hgbot   
2023-10-06 11:30   
Merge request merged: https://gitlab.com/openbravo/product/mods/org.openbravo.distributionorder/-/merge_requests/53 [^]
(0155631)
hgbot   
2023-10-06 11:31   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1010 [^]
(0155632)
hgbot   
2023-10-06 11:31   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 6872ffeeaa01a9455d013534b52e9c69dd677504
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 05-10-2023 10:59:29
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/6872ffeeaa01a9455d013534b52e9c69dd677504 [^]

Fixes BUG-0053531: [RM-7152] - Add unique identifier in good
movements API

**Add event handler inorder to make sure document no is not
repeated in particular organization.
**Add message showing information that Goods Movement with
document no already exists in the particular organization.

---
A src/org/openbravo/event/GoodsMovementEventHandler.java
M src-db/database/sourcedata/AD_MESSAGE.xml
---