Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0005352Openbravo ERP07. Sales managementpublic2008-10-01 10:292008-12-13 20:30
rafaroda 
Hennadzi 
lowtrivialalways
closedfixed 
20Ubuntu 7.10
pi 
 
Core
No
0005352: Malformed ORDER BY clause in some reports
The following reports (Java files) form a malformed ORDER BY clause:
1) ReportDimensionalAnalysesPDF.java
2) ReportInvoiceCustomerDimensionalAnalyses.java
3) ReportInvoiceCustomerDimensionalAnalysesJR.java
4) ReportInvoiceCustomerDimensionalPDF.java
5) ReportInvoiceVendorDimensionalAnalysesJR.java
6) ReportMaterialDimensionalAnalysesJR.java
7) ReportPurchaseDimensionalAnalysesJR.java
8) ReportRefundInvoiceCustomerDimensionalAnalyses.java
9) ReportRefundSalesDimensionalAnalyses.java
10) ReportRefundSalesDimensionalAnalysesPDF.java
11) ReportSalesDimensionalAnalyzeJR.java
12) ReportSalesOrderDimensionalPDF.java
13) ReportShipmentDimensionalAnalyzeJR.java
For 11) ReportSalesDimensionalAnalyzeJR.java:
* Put a break point in the line 'String strHaving = "";' in order to evaluate 'strOrderby' variable at this point.
* Go to 'Sales Management || Analysis Tools || Sales Dimensional Report':
A1) Select 1 dimension (Product) and 'Standard' check-box: strOrderby = ORDER BY NIVEL1 (Correct)
B1) Select 1 dimension (Product) and 'By Ascending Amount' check-box: strOrderby = ORDER BY AMOUNT ASC (Correct)
C1) Select 1 dimension (Product) and 'By Descending Amount' check-box: strOrderby = ORDER BY AMOUNT DESC (Correct)
A2) Select 2 dimensions (Product Group and Product) and 'Standard' check-box: strOrderby = ORDER BY NIVEL1,NIVEL1,NIVEL2 (Wrong: NIVEL1 is repeated)
B2) Select 2 dimensions (Product Group and Product) and 'By Ascending Amount' check-box: strOrderby = ORDER BY NIVEL1,NIVEL1,AMOUNT ASC (Wrong: NIVEL1 is repeated)
C2) Select 2 dimensions (Product Group and Product) and 'By Descending Amount' check-box: strOrderby = ORDER BY NIVEL1,NIVEL1,AMOUNT DESC (Wrong: NIVEL1 is repeated)

Since the only problem here is that the SQL is malformed (the report does not crash and the data are shown correctly) this defect will not be backported.
Patch attached for ReportSalesDimensionalAnalyzeJR.java.
No tags attached.
diff patch-ReportSalesDimensionalAnalyzeJR.diff (754) 2008-10-01 10:29
https://issues.openbravo.com/file_download.php?file_id=299&type=bug
Issue History
2008-10-01 10:29rafarodaNew Issue
2008-10-01 10:29rafarodaAssigned To => Hennadzi
2008-10-01 10:29rafarodasf_bug_id0 => 2139916
2008-10-01 10:29rafarodaFile Added: patch-ReportSalesDimensionalAnalyzeJR.diff
2008-10-01 10:29rafarodaRegression testing => No
2008-10-01 10:29rafarodaStatusnew => scheduled
2008-10-01 10:29rafarodafix_in_branch => trunk
2008-10-01 12:58svnbotCheckin
2008-10-01 12:58svnbotNote Added: 0009299
2008-10-01 12:58svnbotStatusscheduled => resolved
2008-10-01 12:58svnbotResolutionopen => fixed
2008-10-01 12:58svnbotsvn_revision => 8120
2008-12-13 20:30psarobeStatusresolved => closed

Notes
(0009299)
svnbot   
2008-10-01 12:58   
Repository: openbravo
Revision: 8120
Author: hennadzi
Date: 2008-10-01 12:57:57 +0200 (Wed, 01 Oct 2008)

fixed bug 0005352: Malformed ORDER BY clause in some reports

---
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportDimensionalAnalysesPDF.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalyses.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalysesJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalPDF.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceVendorDimensionalAnalysesJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportMaterialDimensionalAnalysesJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportPurchaseDimensionalAnalysesJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportRefundInvoiceCustomerDimensionalAnalyses.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalyses.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalysesPDF.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportSalesDimensionalAnalyzeJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderDimensionalPDF.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportShipmentDimensionalAnalyzeJR.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=8120&sc=1 [^]