Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053473POS2POSpublic2023-09-18 14:142023-09-29 14:13
Reporterranjith_qualiantech_com 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053473: Cashup properties was missed in the mitigation process (Validating draft ticket in backoffice)
DescriptionNew mitigation process added in the issue https://issues.openbravo.com/view.php?id=52864. [^] When the ticket is processed in backoffice, but not removed from POS State, then ticket will be removed from state and Cashup will be updated from backoffice during reload POS application.
In the above process, When updating Cashup from backoffice, few properties like totalStartings, usedInCurrentTrx, and few more are missed
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0052864 closed ranjith_qualiantech_com POS2 Cashup should be retrieved from backend if POS is working with a duplicated ticket ID 
related to defect 0053425 closed ranjith_qualiantech_com Retail Modules POS draft tickets should be validated in backoffice when completing/deleting the ticket 
depends on backport 005348323Q3.1 closed ranjith_qualiantech_com POS2 Cashup properties was missed in the mitigation process (Validating draft ticket in backoffice) 
depends on backport 005348423Q2.4 closed ranjith_qualiantech_com POS2 Cashup properties was missed in the mitigation process (Validating draft ticket in backoffice) 
Attached Filesdiff 53473_21Q4_posterminal.diff (19,298) 2023-09-29 14:12
https://issues.openbravo.com/file_download.php?file_id=19002&type=bug
diff 53473_22Q2_posterminal.diff (19,839) 2023-09-29 14:13
https://issues.openbravo.com/file_download.php?file_id=19003&type=bug
diff 53473_22Q4_posterminal.diff (22,405) 2023-09-29 14:13
https://issues.openbravo.com/file_download.php?file_id=19004&type=bug
Issue History
Date ModifiedUsernameFieldChange
2023-09-18 14:14ranjith_qualiantech_comNew Issue
2023-09-18 14:14ranjith_qualiantech_comAssigned To => ranjith_qualiantech_com
2023-09-18 14:14ranjith_qualiantech_comTriggers an Emergency Pack => No
2023-09-18 14:16ranjith_qualiantech_comRelationship addedrelated to 0052864
2023-09-18 14:16ranjith_qualiantech_comRelationship addedrelated to 0053425
2023-09-19 02:39ranjith_qualiantech_comStatusnew => scheduled
2023-09-22 13:38hgbotNote Added: 0155181
2023-09-22 13:38hgbotNote Added: 0155182
2023-09-26 09:46hgbotNote Added: 0155232
2023-09-26 09:46hgbotNote Added: 0155233
2023-09-26 14:32hgbotNote Added: 0155245
2023-09-26 14:32hgbotResolutionopen => fixed
2023-09-26 14:32hgbotStatusscheduled => closed
2023-09-26 14:32hgbotFixed in Version => RR23Q4
2023-09-26 14:32hgbotNote Added: 0155246
2023-09-26 14:32hgbotNote Added: 0155247
2023-09-26 14:32hgbotNote Added: 0155248
2023-09-26 14:32hgbotNote Added: 0155249
2023-09-26 14:32hgbotNote Added: 0155250
2023-09-26 14:32hgbotNote Added: 0155251
2023-09-26 14:32hgbotNote Added: 0155252
2023-09-26 15:15hgbotNote Added: 0155256
2023-09-29 14:12malsasuaFile Added: 53473_21Q4_posterminal.diff
2023-09-29 14:13malsasuaFile Added: 53473_22Q2_posterminal.diff
2023-09-29 14:13malsasuaFile Added: 53473_22Q4_posterminal.diff

Notes
(0155181)
hgbot   
2023-09-22 13:38   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1357 [^]
(0155182)
hgbot   
2023-09-22 13:38   
Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/328 [^]
(0155232)
hgbot   
2023-09-26 09:46   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/98 [^]
(0155233)
hgbot   
2023-09-26 09:46   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2115 [^]
(0155245)
hgbot   
2023-09-26 14:32   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1357 [^]
(0155246)
hgbot   
2023-09-26 14:32   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 599e9a528761640db733f17f8828aa29d6e80ec4
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 26-09-2023 15:11:53
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/599e9a528761640db733f17f8828aa29d6e80ec4 [^]

Fixed ISSUE-53473: Added Cashup properties when creating cashup from backend
* When cashup loaded from backoffice, following cashup properties should be updated
  * Cashup totalStartings
  * Cashup PaymentMethod's cashManagementsInfo
  * Cashup documentNo sequence info

---
M src/org/openbravo/retail/posterminal/UpdateCashup.java
M src/org/openbravo/retail/posterminal/master/Cashup.java
M src/org/openbravo/retail/posterminal/term/Payments.java
M web-test/model/business-object/cashup/Cashup-initCashup-StateAction-fromBackend.test.js
M web-test/model/business-object/cashup/test-data/cashupAfterLoadCashupFromBackend.js
M web-test/model/business-object/cashup/test-data/cashupAfterLoadCashupFromBackendWithoutPayments.js
M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/CashupUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/PaymentMethodUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/actions/InitCashup.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/TicketUtils.js
---
(0155247)
hgbot   
2023-09-26 14:32   
Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/328 [^]
(0155248)
hgbot   
2023-09-26 14:32   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/98 [^]
(0155249)
hgbot   
2023-09-26 14:32   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: fd562c50ed8fc78eec29b6027746aa199becb543
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 26-09-2023 13:04:41
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/fd562c50ed8fc78eec29b6027746aa199becb543 [^]

Related to ISSUE-53473: TotalStartings should be updatd based on Currency Rate

---
M web/org.openbravo.retail.sessions/js/hook/ProcessCashManagements.js
---
(0155250)
hgbot   
2023-09-26 14:32   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: b257f9a54a4c1a8b60a60f80b9c957b1cda62131
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 26-09-2023 12:32:30
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/b257f9a54a4c1a8b60a60f80b9c957b1cda62131 [^]

Verifies ISSUE-53473: Updated tests for validating Cashup after cache clear

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/openstoretill/I40490_VerifyTillDifferenceNotDeletedWhenCacheIsCleared.java
---
(0155251)
hgbot   
2023-09-26 14:32   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: c4efe2598900f37e7bbb3febc36a50b1a737edd7
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 26-09-2023 12:32:43
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/c4efe2598900f37e7bbb3febc36a50b1a737edd7 [^]

Related to ISSUE-53473: TotalStartings should be updatd based on Currency Rate

---
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/SetInitialCountCashup.js
---
(0155252)
hgbot   
2023-09-26 14:32   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2115 [^]
(0155256)
hgbot   
2023-09-26 15:15   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: b89dcd4c985208c7909b9e33ffbf2ade0b9d082f
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 26-09-2023 18:44:02
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/b89dcd4c985208c7909b9e33ffbf2ade0b9d082f [^]

Related to ISSUE-53473: Updated Cashup jest test for validating totalStartings
* Cashup totalStartings should be updated based on payment method conversion rate

---
M web-test/model/business-object/cashup/test-data/cashupAfterComplete.js
M web-test/model/business-object/cashup/test-data/messagesAfterCompleteCashupSharedPayments.js
---