Openbravo Issue Tracking System - Retail Modules
View Issue Details
0053465Retail ModulesRetail APIpublic2023-09-05 17:122023-09-19 06:10
nicola_uva 
sreehari 
urgentmajoralways
closedfixed 
5
 
RR23Q3.1RR23Q3.1 
Production - Confirmed Stable
2022-09-19
RR22Q4
https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/923/diffs?commit_id=1ab8340a5080191cca30fff9486c360e44b6c549 [^]
No
0053465: ExternalOrderLoader API: C&R doesn't work
C&R is not working anymore using the external order loader API.
1. Import Retail API collection in postman https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api/-/blob/master/examples/Retail%20API.postman_collection.json?ref_type=heads [^]
2. Execute the request "Import Order - Simple ticket with 2 lines"
3. Execute the request "Import Order - Order cancel and replace" (with the id of replacedorder done in point 2)
4.In Openbravo.log is present following error

2023-09-05 16:22:08,435 [Import Entry - 4] ERROR org.openbravo.retail.posterminal.POSDataSynchronizationErrorHandler - An error happened when processing a record:
org.openbravo.base.exception.OBException: CancelAndReplaceUtils.cancelAndReplaceOrder:
        at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:578) ~[classes/:?]
        at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:214) [classes/:?]
        at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:165) [classes/:?]
        at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:97) [classes/:?]
        at org.openbravo.mobile.core.process.MobileImportEntryProcessorRunnable.processEntry(MobileImportEntryProcessorRunnable.java:55) [classes/:?]
        at org.openbravo.retail.posterminal.importprocess.OrderImportEntryProcessor$OrderLoaderRunnable.processEntry(OrderImportEntryProcessor.java:64) [classes/:?]
        at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:430) [classes/:?]
        at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:347) [classes/:?]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) [?:?]
        at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
        at java.lang.Thread.run(Thread.java:829) [?:?]
Caused by: java.lang.NullPointerException
        at org.openbravo.retail.posterminal.POSUtils.setDefaultPaymentType(POSUtils.java:579) ~[classes/:?]
        at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:566) ~[classes/:?]
No tags attached.
blocks defect 0053390 closed sreehari ExternalOrderLoader API: C&R doesn't work 
Issue History
2023-09-15 14:00sreehariTypedefect => backport
2023-09-15 14:00sreehariTarget Version => RR23Q3.1
2023-09-18 07:19hgbotNote Added: 0154925
2023-09-19 06:10hgbotResolutionopen => fixed
2023-09-19 06:10hgbotStatusscheduled => closed
2023-09-19 06:10hgbotNote Added: 0154965
2023-09-19 06:10hgbotFixed in Version => RR23Q3.1
2023-09-19 06:10hgbotNote Added: 0154966

Notes
(0154925)
hgbot   
2023-09-18 07:19   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1347 [^]
(0154965)
hgbot   
2023-09-19 06:10   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1347 [^]
(0154966)
hgbot   
2023-09-19 06:10   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 87cc61264591f2549a5d553c10e75d44bd982fd9
Author: Sreehari Venkataraman <sreehari@qualiantech.com>
Date: 16-09-2023 12:28:15
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/87cc61264591f2549a5d553c10e75d44bd982fd9 [^]

Fixes ISSUE-53465: Changed cancelled order to Replacedorder

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---