0053465: ExternalOrderLoader API: C&R doesn't work - Openbravo Issue Tracking System

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0053465

Retail Modules

Retail API

public

2023-09-05 17:12

2023-09-19 06:10

Reporter

nicola_uva

Assigned To

sreehari

Priority

urgent

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

RR23Q3.1

Fixed in Version

RR23Q3.1

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Production - Confirmed Stable

Regression date

2022-09-19

Regression introduced in release

RR22Q4

Regression introduced by commit

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/923/diffs?commit_id=1ab8340a5080191cca30fff9486c360e44b6c549 [^]

Triggers an Emergency Pack

Summary

0053465: ExternalOrderLoader API: C&R doesn't work

Description

C&R is not working anymore using the external order loader API.

Steps To Reproduce

1. Import Retail API collection in postman https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api/-/blob/master/examples/Retail%20API.postman_collection.json?ref_type=heads [^]
2. Execute the request "Import Order - Simple ticket with 2 lines"
3. Execute the request "Import Order - Order cancel and replace" (with the id of replacedorder done in point 2)
4.In Openbravo.log is present following error

2023-09-05 16:22:08,435 [Import Entry - 4] ERROR org.openbravo.retail.posterminal.POSDataSynchronizationErrorHandler - An error happened when processing a record:
org.openbravo.base.exception.OBException: CancelAndReplaceUtils.cancelAndReplaceOrder:
        at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:578) ~[classes/:?]
        at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:214) [classes/:?]
        at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:165) [classes/:?]
        at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:97) [classes/:?]
        at org.openbravo.mobile.core.process.MobileImportEntryProcessorRunnable.processEntry(MobileImportEntryProcessorRunnable.java:55) [classes/:?]
        at org.openbravo.retail.posterminal.importprocess.OrderImportEntryProcessor$OrderLoaderRunnable.processEntry(OrderImportEntryProcessor.java:64) [classes/:?]
        at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:430) [classes/:?]
        at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:347) [classes/:?]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) [?:?]
        at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
        at java.lang.Thread.run(Thread.java:829) [?:?]
Caused by: java.lang.NullPointerException
        at org.openbravo.retail.posterminal.POSUtils.setDefaultPaymentType(POSUtils.java:579) ~[classes/:?]
        at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:566) ~[classes/:?]

Proposed Solution

Additional Information