Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053460POS2POSpublic2023-09-14 18:332023-10-31 14:27
Reporterrafaroda 
Assigned Tosreehari 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version24Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053460: In POS 2 the checkbox Allow Open Drawer is NOT working as expected (as in ENYO POS 1)
DescriptionIn POS 2 the checkbox Allow Open Drawer is NOT working as expected (as in ENYO POS 1)

In ENYO POS 1:
* In Touchpoint Type > Payment Method: when ALLOW OPEN DRAWER = Y, the Drawer opens at the end of the transaction of sale

In REACT POS 2:
* In Touchpoint Type > Payment Method: when ALLOW OPEN DRAWER = Y, the Drawer does NOT open at the end of the transaction

Steps To Reproduce1) In Live Builds, first go to touchpoint VB-2 https://livebuilds.openbravo.com/context/retail_pos2_modules_pgsql/?tabId=FF80818132F311740132F3233778004B&recordId=D8916CD7C5574FEF9C3FF2511D52C5F7 [^] and put it a Hardware manager URL http://localhost:8090/printer [^]

2) Then go to Touchpoint Type VB POS Terminal Type > Payment Method Credit card and you will see that ALLOW OPEN DRAWER = Y https://livebuilds.openbravo.com/context/retail_pos2_modules_pgsql/?tabId=4D9F5E9CC0014A96861CEFB64BBF013B&recordId=A7846E0520E74A0B87C09A1477690F8C [^]

3) Then go to POS, refresh master data https://livebuilds.openbravo.com/context/retail_pos2_modules_pgsql/web/pos/?terminal=VB-2 [^]
* Verify that HWM Drawer is closed
* Create a ticket
* Add some product
* Pay for it with CREDIT CARD and finalize it: Verify that HWM Drawer does NOT open in POS 2 (in this same situation in POS 1 Enyo yes it was opened)
Proposed SolutionThe HWM Drawer should have opened at the end of the transaction with Allow Open Drawer = Y in POS 2 (in the same way it was doing in POS 1)
Additional Information
TagsNo tags attached.
Relationships
related to defect 0053818 closed sreehari Drawer does not open when paying with Cash 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-09-14 18:33rafarodaNew Issue
2023-09-14 18:33rafarodaAssigned To => Retail
2023-09-14 18:33rafarodaOBNetwork customer => Gold
2023-09-14 18:33rafarodaTriggers an Emergency Pack => No
2023-09-18 08:23sreehariAssigned ToRetail => sreehari
2023-09-19 13:30sreehariStatusnew => scheduled
2023-09-20 07:18hgbotMerge Request Status => open
2023-09-20 07:18hgbotNote Added: 0155011
2023-09-25 12:58rafarodaSummaryOpen drawer Before Closing Ticket conflicts with Auto Close Paid Order => In POS 2 the checkbox Allow Open Drawer is NOT working as expected (as in ENYO POS 1)
2023-09-25 12:58rafarodaDescription Updatedbug_revision_view_page.php?rev_id=26878#r26878
2023-09-25 12:58rafarodaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=26880#r26880
2023-09-25 12:58rafarodaProposed Solution updated
2023-10-05 08:31hgbotMerge Request Statusopen => approved
2023-10-05 08:31hgbotNote Added: 0155547
2023-10-05 08:31hgbotResolutionopen => fixed
2023-10-05 08:31hgbotStatusscheduled => closed
2023-10-05 08:31hgbotFixed in Version => 24Q1
2023-10-05 08:31hgbotNote Added: 0155548
2023-10-31 14:27rafarodaNote Added: 0156545
2023-10-31 14:27rafarodaRelationship addedrelated to 0053818

Notes
(0155011)
hgbot   
2023-09-20 07:18   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2099 [^]
(0155547)
hgbot   
2023-10-05 08:31   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2099 [^]
(0155548)
hgbot   
2023-10-05 08:31   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: b38c7689ac99ac4aa39e506351bdf8b97a3c1237
Author: Sreehari Venkataraman <sreehari@qualiantech.com>
Date: 05-10-2023 05:52:56
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/b38c7689ac99ac4aa39e506351bdf8b97a3c1237 [^]

Fixes ISSUE-53460: Modified allowOpenDrawer logic to enable opendrawer action
*Handled in both cased where auto close is enabled and when done button is clicked
*Modified Jest Cases for openDrawer

---
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentKeypad/PaymentKeypad.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentKeypad/__test__/PaymentKeypad.test.jsx
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AddPayment.js
---
(0156545)
rafaroda   
2023-10-31 14:27   
Created regression 0053818