Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0053423 | Openbravo ERP | A. Platform | public | 2023-09-08 13:03 | 2023-09-13 10:11 |
|
| Reporter | alostale | |
| Assigned To | alostale | |
| Priority | normal | Severity | major | Reproducibility | random |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | PR23Q4 | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0053423: cannot open any BO windows |
| Description | Under certain circumstances, if a given race condition occurs, it is possible that no BO window can be opened.
Workaround: This race condition occurs during initialization, and gets cached. So if it occurs, it will continue in this incorrect status until Tomcat is restarted.
The problem is in BaseComponent.getContextUrl[1] method, that can be invoked concurrently although it sets and mutates an static shared variable. If there are two concurrent requests accessing this method one of them could return a corrupted value, if the one that received the corrupted value was serving the application component, which is later part of generated js file and therefore cached, this value will be incorrect causing failures when composing the url to retrieve views.
[1] https://gitlab.com/openbravo/product/openbravo/-/blob/release/23Q3/modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/BaseComponent.java?ref_type=heads#L90 [^]
|
| Steps To Reproduce | It occurs very rarely:
1. Restart Tomcat
2. Open several BO applications at the same time
3. Try to open any window:
ERROR
* it keeps in loading forever
* http request to generate its view results in a 404 because the url is incorrectly built |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2023-09-08 13:03 | alostale | New Issue | |
| 2023-09-08 13:03 | alostale | Assigned To | => Triage Platform Base |
| 2023-09-08 13:03 | alostale | Modules | => Core |
| 2023-09-08 13:03 | alostale | Triggers an Emergency Pack | => No |
| 2023-09-08 13:03 | alostale | Assigned To | Triage Platform Base => alostale |
| 2023-09-08 13:17 | hgbot | Note Added: 0154636 | |
| 2023-09-13 08:21 | hgbot | Note Added: 0154760 | |
| 2023-09-13 09:22 | hgbot | Note Added: 0154763 | |
| 2023-09-13 09:22 | hgbot | Note Added: 0154764 | |
| 2023-09-13 09:22 | hgbot | Note Added: 0154765 | |
| 2023-09-13 09:22 | hgbot | Resolution | open => fixed |
| 2023-09-13 09:22 | hgbot | Status | new => closed |
| 2023-09-13 09:22 | hgbot | Fixed in Version | => PR23Q4 |
| 2023-09-13 09:22 | hgbot | Note Added: 0154766 | |
| 2023-09-13 10:11 | hgbot | Note Added: 0154768 | |
|
Notes |
|
|
(0154636)
|
|
hgbot
|
|
2023-09-08 13:17
|
|
|
|
|
(0154760)
|
|
hgbot
|
|
2023-09-13 08:21
|
|
|
|
|
(0154763)
|
|
hgbot
|
|
2023-09-13 09:22
|
|
|
|
|
(0154764)
|
|
hgbot
|
|
2023-09-13 09:22
|
|
|
|
|
(0154765)
|
|
hgbot
|
|
2023-09-13 09:22
|
|
|
|
|
(0154766)
|
|
hgbot
|
|
2023-09-13 09:22
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 291e8810367f91ddee726efada674f7e3bf674e0
Author: Asier Lostalé <asier.lostale@openbravo.com>
Date: 13-09-2023 08:13:56
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/291e8810367f91ddee726efada674f7e3bf674e0 [^]
fixes BUG-53423: cannot open any BO window due to incorrect ctx initialization
BaseComponent.getContextUrl method can be concurrently invoked, as it mutated a
static contextUrl variable it could be served in a corrupted (partial) state. If
this occurred while generating application component, no view could later be
opened.
This fix includes:
* Transformations on contextUrl variable are done in a temporary variable, to
be cached only when completelly computed.
* It is set in a synchronized method: although this has no real effect, it
makes it more explicit.
In addition:
* contextUrl private variable is only exposed through its getter, its contents
were not directly got but transformed every time. Now this transformation is
also persisted so it is executed only once.
* setContextUrl method is now private as it was not publicly used.
---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/BaseComponent.java
---
|
|
|
|
(0154768)
|
|
hgbot
|
|
2023-09-13 10:11
|
|
|