Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0053414 | Retail Modules | Web POS | public | 2023-09-07 13:36 | 2023-09-14 11:15 |
|
| Reporter | AugustoMauch | |
| Assigned To | AugustoMauch | |
| Priority | normal | Severity | major | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | RR23Q4 | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0053414: If a master data refresh fails, the next time the user logs in, the refresh should be repeated |
| Description | The following case is theoretically possible:
- When the user logs in, conditions are met so that the full/incremental master data refresh takes place
- Something goes wrong during that master data refresh, the process ends in error when only some of the models have been updated, user is logged out
- Next time the user logs in, conditions to do a full/incremental master data refresh are not met, so user logs in in the application having potentially inconsistent data due to the failed refresh.
We can be sure that of the reasons that trigger a refresh will still be met the next time the user logs in if the previous refreshed failed, i.e. the master data refresh timeout. But we cannot be sure about others (i.e. there are several ways to do forced updates).
The current implementations already tries to force the masterdata to be refreshed in case the latest one failed [1], but that mechanism will not be triggered
To prevent this problem, we have to ensure that regardless of other conditions are met, if a previous master data refreshed failed, the next time the user logs in the master data refresh is restarted if the browser failed or if the tab was closed before reaching that line.
[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/blob/master/web/org.openbravo.mobile.core/app/model/masterdata/MasterdataController.js#L140 [^] |
| Steps To Reproduce | - To be done |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2023-09-07 13:36 | AugustoMauch | New Issue | |
| 2023-09-07 13:36 | AugustoMauch | Assigned To | => AugustoMauch |
| 2023-09-07 13:36 | AugustoMauch | Triggers an Emergency Pack | => No |
| 2023-09-07 13:36 | AugustoMauch | Status | new => scheduled |
| 2023-09-11 09:05 | AugustoMauch | Description Updated | bug_revision_view_page.php?rev_id=26797#r26797 |
| 2023-09-11 17:38 | hgbot | Note Added: 0154687 | |
| 2023-09-11 17:39 | hgbot | Note Added: 0154688 | |
| 2023-09-14 09:16 | hgbot | Note Added: 0154829 | |
| 2023-09-14 09:16 | hgbot | Note Added: 0154830 | |
| 2023-09-14 11:15 | hgbot | Resolution | open => fixed |
| 2023-09-14 11:15 | hgbot | Status | scheduled => closed |
| 2023-09-14 11:15 | hgbot | Note Added: 0154838 | |
| 2023-09-14 11:15 | hgbot | Fixed in Version | => RR23Q4 |
| 2023-09-14 11:15 | hgbot | Note Added: 0154839 | |
|
Notes |
|
|
(0154687)
|
|
hgbot
|
|
2023-09-11 17:38
|
|
|
|
|
(0154688)
|
|
hgbot
|
|
2023-09-11 17:39
|
|
|
|
|
(0154829)
|
|
hgbot
|
|
2023-09-14 09:16
|
|
|
|
|
(0154830)
|
|
hgbot
|
|
2023-09-14 09:16
|
|
|
|
|
(0154838)
|
|
hgbot
|
|
2023-09-14 11:15
|
|
|
|
|
(0154839)
|
|
hgbot
|
|
2023-09-14 11:15
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 9cd130a864e561132b095e5794a949c71025b194
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 14-09-2023 08:01:36
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/9cd130a864e561132b095e5794a949c71025b194 [^]
Fixes ISSUE-53414: Masterdata refresh must be restarted if previous attempt did not finish with success
A new check has been added to ensure that regardless of the reason why a master data refresh was triggered, if it fails, the
next time the user logs in a new master data refresh of the same kind (full / incremental) will be triggered.
There was already a mechanism in place to try to address this case, but it was only being triggered when the master data refresh
finishes having failed for some models. If the process does not finish (i.e. the browser crashes in the process, or the user closes
the tab), then potentially the next the user logs in, he could be permitted to log in with inconsistent data
---
M web-test/model/masterdata/MasterdataHooks.test.js
M web/org.openbravo.mobile.core/app/model/masterdata/MasterdataController.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
|
|