Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053392POS2Fashionpublic2023-09-05 18:172023-12-12 11:32
Reporterdbaz 
Assigned ToSABARINATH P 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053392: "Follow-up Files" grid should use new multiselection grid
Description"Follow-up Files" grid should use new multiselection grid. Actually it is used old implementation, where the new header is not shown.
Steps To ReproduceDefine in backoffice a new "Services Provider" available for the Organization where do you want to test.

Add a new services type product (f.e. Warranty (Deferred)) the flag "Requires Follow-up File"

Add a new sale with a product including this service (f.e. GPS Mini).

Go to Follow-up Files window.

Notice that if you multiselect, the UI is not the same than if you do multiselection in Orders window.

In order to text quickly multiselection in Orders window, just in this file
modules/org.openbravo.pos2/web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListRemoteGrid/TicketListRemoteGridPopover.config.json

keep the verified returns as:

  "componentList": [
    {
      "id": "1",
      "component": "OBPOS2_AddVerifiedReturnsPopoverButton",
      "layout": {
        "colStart": 1,
        "colSpan": 1,
        "rowStart": 1,
        "rowSpan": 1
      },
      "properties": {
        "multirowSupported": true
      }
    },
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng Wrong multi-selection.png (68,782) 2023-09-05 18:18
https://issues.openbravo.com/file_download.php?file_id=18932&type=bug
png

png Proper multi-selection.png (209,771) 2023-09-05 18:30
https://issues.openbravo.com/file_download.php?file_id=18933&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2023-09-05 18:17dbazNew Issue
2023-09-05 18:17dbazAssigned To => Retail
2023-09-05 18:17dbazTriggers an Emergency Pack => No
2023-09-05 18:18dbazFile Added: Wrong multi-selection.png
2023-09-05 18:30dbazFile Added: Proper multi-selection.png
2023-09-08 11:11SABARINATH PAssigned ToRetail => SABARINATH P
2023-09-08 11:11SABARINATH PStatusnew => acknowledged
2023-09-11 14:06SABARINATH PStatusacknowledged => scheduled
2023-09-15 07:08hgbotNote Added: 0154877
2023-12-04 15:37hgbotResolutionopen => fixed
2023-12-04 15:37hgbotStatusscheduled => closed
2023-12-04 15:37hgbotNote Added: 0157939
2023-12-04 15:37hgbotNote Added: 0157940
2023-12-12 10:14hgbotNote Added: 0158072
2023-12-12 11:32hgbotNote Added: 0158090
2023-12-12 11:32hgbotNote Added: 0158091
2023-12-12 11:32hgbotNote Added: 0158092
2023-12-12 11:32hgbotNote Added: 0158093

Notes
(0154877)
hgbot   
2023-09-15 07:08   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider/-/merge_requests/45 [^]
(0157939)
hgbot   
2023-12-04 15:37   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider [^]
Changeset: 841f2d1a8df641aae08bfe0c27f8dac2f5a64848
Author: sabarinath palanisamy <sabarinath.palanisamy.ext@openbravo.com>
Date: 04-12-2023 14:37:48
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider/-/commit/841f2d1a8df641aae08bfe0c27f8dac2f5a64848 [^]

fixes ISSUE-53392: 'Follow-up files' grid should use the new multiselection grid

---
M web-jspack/org.openbravo.pos2.service.provider/src/components/FollowUpServiceWindow/FollowUpServiceGridListViewColumn.config.json
M web-jspack/org.openbravo.pos2.service.provider/src/components/FollowUpServiceWindow/FollowUpServiceWindow.jsx
---
(0157940)
hgbot   
2023-12-04 15:37   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider/-/merge_requests/45 [^]
(0158072)
hgbot   
2023-12-12 10:14   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider/-/merge_requests/49 [^]
(0158090)
hgbot   
2023-12-12 11:32   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider/-/merge_requests/49 [^]
(0158091)
hgbot   
2023-12-12 11:32   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider [^]
Changeset: db55963440be68c98013b4c48a748dd5012ad7e3
Author: Prakash Murugesan <prakash.murugesan.ext@openbravo.com>
Date: 11-12-2023 18:06:58
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider/-/commit/db55963440be68c98013b4c48a748dd5012ad7e3 [^]

Related to ISSUE-53392: Moved context menu implementation to filterable grid actions props
* Currently in Follow-up Files context menus are created statically in rows and grid header
* But it should use actions props in filterable grid where context menus are generated dynamically based on config
* Similarly Multi Selection Headers and its context definitions are also generated dynamically based on multirowSupported
property in the config

---
A web-jspack/org.openbravo.pos2.service.provider/src/components/FollowUpServiceWindow/FollowUpRowPopoverFlagAsActionButton.jsx
A web-jspack/org.openbravo.pos2.service.provider/src/components/FollowUpServiceWindow/FollowUpRowPopoverPrintReportButton.jsx
A web-jspack/org.openbravo.pos2.service.provider/src/components/FollowUpServiceWindow/FollowUpRowPopoverVoidCloseButton.jsx
A web-jspack/org.openbravo.pos2.service.provider/src/components/FollowUpServiceWindow/FollowUpServiceGridPopover.config.json
M web-jspack/org.openbravo.pos2.service.provider/src/components/FollowUpServiceWindow/FollowUpServiceUtils.js
M web-jspack/org.openbravo.pos2.service.provider/src/components/FollowUpServiceWindow/FollowUpServiceWindow.jsx
M web-jspack/org.openbravo.pos2.service.provider/src/ob-init.js
---
(0158092)
hgbot   
2023-12-12 11:32   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider [^]
Changeset: 3dfcc6b4c40a91393d1f1bc024c7e7f8e6b4a000
Author: Prakash Murugesan <prakash.murugesan.ext@openbravo.com>
Date: 11-12-2023 18:22:25
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider/-/commit/3dfcc6b4c40a91393d1f1bc024c7e7f8e6b4a000 [^]

Related to ISSUE-53392: Removed static context menu implementation in FollowUp-Files

---
M web-jspack/org.openbravo.pos2.service.provider/src/components/FollowUpServiceWindow/FollowUpServiceWindow.jsx
---
(0158093)
hgbot   
2023-12-12 11:32   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider [^]
Changeset: 35ff338adac2cc16fe44081814448f764c1662cb
Author: Prakash Murugesan <prakash.murugesan.ext@openbravo.com>
Date: 12-12-2023 12:11:14
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider/-/commit/35ff338adac2cc16fe44081814448f764c1662cb [^]

Fixes ISSUE-53392: Added jest test for the new components

---
A web-jspack/org.openbravo.pos2.service.provider/src/components/FollowUpServiceWindow/__test__/FollowUpRowPopoverFlagAsActionButton.test.jsx
A web-jspack/org.openbravo.pos2.service.provider/src/components/FollowUpServiceWindow/__test__/FollowUpRowPopoverPrintReportButton.test.jsx
A web-jspack/org.openbravo.pos2.service.provider/src/components/FollowUpServiceWindow/__test__/FollowUpRowPopoverVoidCloseButton.test.jsx
M web-jspack/org.openbravo.pos2.service.provider/src/components/FollowUpServiceWindow/FollowUpRowPopoverFlagAsActionButton.jsx
M web-jspack/org.openbravo.pos2.service.provider/src/components/FollowUpServiceWindow/FollowUpRowPopoverPrintReportButton.jsx
M web-jspack/org.openbravo.pos2.service.provider/src/components/FollowUpServiceWindow/FollowUpRowPopoverVoidCloseButton.jsx
---