Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053390Retail ModulesRetail APIpublic2023-09-05 17:122023-09-18 06:34
Reporternicola_uva 
Assigned Tosreehari 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR23Q4 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2022-09-19
Regression introduced in releaseRR22Q4
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/923/diffs?commit_id=1ab8340a5080191cca30fff9486c360e44b6c549 [^]
Triggers an Emergency PackNo
Summary0053390: ExternalOrderLoader API: C&R doesn't work
DescriptionC&R is not working anymore using the external order loader API.
Steps To Reproduce1. Import Retail API collection in postman https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api/-/blob/master/examples/Retail%20API.postman_collection.json?ref_type=heads [^]
2. Execute the request "Import Order - Simple ticket with 2 lines"
3. Execute the request "Import Order - Order cancel and replace" (with the id of replacedorder done in point 2)
4.In Openbravo.log is present following error

2023-09-05 16:22:08,435 [Import Entry - 4] ERROR org.openbravo.retail.posterminal.POSDataSynchronizationErrorHandler - An error happened when processing a record:
org.openbravo.base.exception.OBException: CancelAndReplaceUtils.cancelAndReplaceOrder:
        at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:578) ~[classes/:?]
        at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:214) [classes/:?]
        at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:165) [classes/:?]
        at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:97) [classes/:?]
        at org.openbravo.mobile.core.process.MobileImportEntryProcessorRunnable.processEntry(MobileImportEntryProcessorRunnable.java:55) [classes/:?]
        at org.openbravo.retail.posterminal.importprocess.OrderImportEntryProcessor$OrderLoaderRunnable.processEntry(OrderImportEntryProcessor.java:64) [classes/:?]
        at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:430) [classes/:?]
        at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:347) [classes/:?]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) [?:?]
        at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
        at java.lang.Thread.run(Thread.java:829) [?:?]
Caused by: java.lang.NullPointerException
        at org.openbravo.retail.posterminal.POSUtils.setDefaultPaymentType(POSUtils.java:579) ~[classes/:?]
        at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:566) ~[classes/:?]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0053465RR23Q3.1 closed sreehari ExternalOrderLoader API: C&R doesn't work 
depends on backport 0053466RR23Q2.4 closed sreehari ExternalOrderLoader API: C&R doesn't work 
caused by defect 0049849 closed ranjith_qualiantech_com When doing a cancel and replace the payment method is changed to correspond to a default payment method 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-09-05 17:12nicola_uvaNew Issue
2023-09-05 17:12nicola_uvaAssigned To => Retail
2023-09-05 17:12nicola_uvaTriggers an Emergency Pack => No
2023-09-06 11:27sreehariAssigned ToRetail => sreehari
2023-09-12 11:44sreehariStatusnew => scheduled
2023-09-14 08:44sreehariRelationship addedcaused by 0049849
2023-09-14 10:53sreehariRegression level => Production - Confirmed Stable
2023-09-14 10:53sreehariRegression date => 2022-09-19
2023-09-14 10:53sreehariRegression introduced in release => RR22Q4
2023-09-14 10:53sreehariRegression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/923/diffs?commit_id=1ab8340a5080191cca30fff9486c360e44b6c549 [^]
2023-09-15 14:00sreehariStatusscheduled => acknowledged
2023-09-15 14:00sreehariStatusacknowledged => scheduled
2023-09-16 07:19hgbotNote Added: 0154908
2023-09-18 06:34hgbotResolutionopen => fixed
2023-09-18 06:34hgbotStatusscheduled => closed
2023-09-18 06:34hgbotFixed in Version => RR23Q4
2023-09-18 06:34hgbotNote Added: 0154922
2023-09-18 06:34hgbotNote Added: 0154923

Notes
(0154908)
hgbot   
2023-09-16 07:19   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1343 [^]
(0154922)
hgbot   
2023-09-18 06:34   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: b3ac613e6f9b6318c913c2e909e6c4ce9ecde9ca
Author: Sreehari Venkataraman <sreehari@qualiantech.com>
Date: 18-09-2023 04:34:13
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/b3ac613e6f9b6318c913c2e909e6c4ce9ecde9ca [^]

Fixes ISSUE-53390: Changed Cancelled order to Replacedorder
*During CR replacedorder is sent both from pos & external order loader
*So validating payments through Replacedorder

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0154923)
hgbot   
2023-09-18 06:34   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1343 [^]