Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053283POS2Corepublic2023-08-24 10:382023-09-04 09:57
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q4 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053283: Approval for Manager
DescriptionIt would be nice to support a new configuration option for the user action approvals to force managers to require approval also.

With this option it will be required approval to use the user action for the configured role but at the same time it provides privileges to approve other roles for that same user action.
Steps To Reproduce.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0053341 new Triage Platform Base Some messages in approval dialog are not completely seen in portrait mode 
related to defect 0055174 closed caristu The master data of supervisors without self approval is not loaded 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-08-24 10:38caristuNew Issue
2023-08-24 10:38caristuAssigned To => caristu
2023-08-24 10:38caristuTriggers an Emergency Pack => No
2023-08-24 10:39hgbotNote Added: 0153893
2023-08-31 08:04caristuRelationship addedrelated to 0053341
2023-09-04 09:57hgbotResolutionopen => fixed
2023-09-04 09:57hgbotStatusnew => closed
2023-09-04 09:57hgbotNote Added: 0154389
2023-09-04 09:57hgbotFixed in Version => 23Q4
2023-09-04 09:57hgbotNote Added: 0154390
2024-04-11 16:32caristuRelationship addedrelated to 0055174

Notes
(0153893)
hgbot   
2023-08-24 10:39   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1212 [^]
(0154389)
hgbot   
2023-09-04 09:57   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1212 [^]
(0154390)
hgbot   
2023-09-04 09:57   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: c271f0f1599928e11ee86a08ac0d22cbc97942ee
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 04-09-2023 09:57:09
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/c271f0f1599928e11ee86a08ac0d22cbc97942ee [^]

fixes FR-53283: Approval for Manager

---
A src-test/org/openbravo/core2/utility/CheckApprovalTest.java
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src-test/org/openbravo/core2/StandaloneTestSuite.java
M src/org/openbravo/core2/login/GrantedUserActionsProvider.java
M src/org/openbravo/core2/utility/CheckApproval.java
M web-jspack/org.openbravo.core2/src/components/ReasonAndApprovalDialog/__test__/ReasonAndApprovalDialog.test.jsx
M web-jspack/org.openbravo.core2/src/core/security/ApprovalChecker.js
M web-jspack/org.openbravo.core2/src/core/security/OfflineApprovals.js
M web-jspack/org.openbravo.core2/src/core/security/__mock__/userActionAccessMockData.js
M web-jspack/org.openbravo.core2/src/core/security/__test__/ApprovalChecker.test.js
M web-jspack/org.openbravo.core2/src/core/security/__test__/OfflineApprovals.test.js
M web-jspack/org.openbravo.core2/src/core/user-action/UserAction.js
M web-jspack/org.openbravo.core2/src/core/user-action/__test__/UserAction.test.js
---