Openbravo Issue Tracking System - POS2
View Issue Details
0053236POS2POSpublic2023-08-18 11:372024-11-20 08:53
Daria_Sh 
ranjith_qualiantech_com 
normalminorhave not tried
closedfixed 
5
 
 
No
0053236: Incorrect 'Current Balance' is shown when the Order is paid by Gift Certificate and Reversed
When I pay for an Order using a Gift Certificate and then reverse it, I notice that the current balance of this Gift Certificate ('Gift Card Instance' window in Backoffice) increases by the total order amount.

Create a Gift Certificate:
1.Log in to POS2:
-username: vallblanca
-password: openbravo
2.Go to Main menu -> Restaurant -> Gift Cards / Credit Notes / Gift Certificates
3.Click the 'Create Gift Certificate' button
4.Enter the following values:
- Gift Card Category: Commercial
- Expiration Date: A date in the future
- Amount: 50
Push 'Create' button
Go to Backoffice (username and password - openbravo) -> 'Gift Card Instance' window -> Write down the 'Search Key' of the created Certificate (will be used in POS as Card ID)
1.Go to POS2
2.Push 'VBS Customer' button → select 'Arturo Montoro'
3.Add 'Headlamp ultralight' product to the Order → Click'Pay' button
4.Select the 'Gift Cards/Certificates' payment method → Specify Gift Certificate Card ID
5.Click'Search' button → Push shown 'Gift Certificate'→ Pick 'Done' button
6.Go to 'Orders' → Open created Order by clicking on it
7.Push 'Review Payments' button → Click the rounded arrow beside '18.90 €' in the 'Payments' area → Click 'OK' in the confirmation pop-up
8.Select 'Cash' payment method → Push 'Done'
9.Go to Backoffice → 'Gift Card Instance' window 
10.Select Gift Certificate used to pay Order
11.Pay attention to the Gift Certificate 'Current Balance'

Actual result: The Current Balance of this Gift Certificate is increased by the total Order amount (68.90 EUR)
Expected result: The Current Balance of this Gift Certificate is 50.00 (as it was at the beginning)
No tags attached.
jpg Screenshot_2.jpg (211,166) 2023-08-18 11:37
https://issues.openbravo.com/file_download.php?file_id=18881&type=bug
jpg
Issue History
2023-08-18 11:37Daria_ShNew Issue
2023-08-18 11:37Daria_ShAssigned To => Retail
2023-08-18 11:37Daria_ShFile Added: Screenshot_2.jpg
2023-08-18 11:37Daria_ShTriggers an Emergency Pack => No
2023-09-12 09:58ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2023-10-03 13:59ranjith_qualiantech_comStatusnew => scheduled
2023-10-04 11:12ranjith_qualiantech_comNote Added: 0155489
2023-10-04 11:12ranjith_qualiantech_comStatusscheduled => closed
2023-10-04 11:12ranjith_qualiantech_comResolutionopen => unable to reproduce
2024-10-28 13:50Daria_ShNote Added: 0171050
2024-10-28 13:50Daria_ShStatusclosed => new
2024-10-28 13:50Daria_ShResolutionunable to reproduce => open
2024-10-29 11:17Daria_ShSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=28688#r28688
2024-10-29 11:18Daria_ShNote Edited: 0171050bug_revision_view_page.php?bugnote_id=0171050#r28690
2024-11-04 07:27ranjith_qualiantech_comStatusnew => scheduled
2024-11-05 07:57hgbotNote Added: 0171359
2024-11-20 08:53hgbotResolutionopen => fixed
2024-11-20 08:53hgbotStatusscheduled => closed
2024-11-20 08:53hgbotNote Added: 0172296
2024-11-20 08:53hgbotNote Added: 0172297

Notes
(0155489)
ranjith_qualiantech_com   
2023-10-04 11:12   
Not able to reproduce. Confirmed with Reporter.
(0171050)
Daria_Sh   
2024-10-28 13:50   
(edited on: 2024-10-29 11:18)
The issue is reproducible in the [24q4] and livebuilds

(0171359)
hgbot   
2024-11-05 07:57   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/394 [^]
(0172296)
hgbot   
2024-11-20 08:53   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: d1eb4b6c81789a485743425068356c0c713679ab
Author: Ranjith S R <r.rangaraju@external.orisha.com>
Date: 20-11-2024 07:53:35
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/d1eb4b6c81789a485743425068356c0c713679ab [^]

Fixed ISSUE-53236: GiftCard Transaction should not be created for Reverse Payment

---
M src/org/openbravo/retail/giftcards/hooks/GiftCardHookUtils.java
---
(0172297)
hgbot   
2024-11-20 08:53   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/394 [^]