Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053170Openbravo ERPZ. Otherspublic2023-08-06 13:322024-03-04 18:42
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR24Q2 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053170: Review and remove modulescripts only required for updates from <16Q1 - omni - part3
DescriptionIssue 51068 blocks upgrades from versions older than 16Q1.

Any modulescript running on upgrades from <16Q1 is no longer needed and can be removed if it is marked as NOT running also during install.source

Many (very) old modulescripts when created before being able to declare executeOnInstall=false.
Those old ones need be reviewed one-by-one if they can be safely skipped during install and then be removed as obsolete
Steps To Reproduce51068 change ensures that old version (before update) is at least 16Q1 (x.x.28207)
Any buildvalidation defined with ExecutionLimits end-version before that (and moduleId of a module contained in backoffice repo) => is candidated to be removed.

Directly possible to remove it is also has executeOnInstall=false already.
If not it must be reviewed first is that flag applies to them also.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0053029 new shuehner Review and remove modulescripts only required for updates from <16Q1 - omni - part2 
depends on feature request 0051068PR23Q1 closed shuehner Block direct upgrades from version older than 16Q1 to latest version 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-08-06 13:32shuehnerNew Issue
2023-08-06 13:32shuehnerAssigned To => shuehner
2023-08-06 13:32shuehnerModules => Core
2023-08-06 13:32shuehnerTriggers an Emergency Pack => No
2023-08-06 13:32shuehnerIssue generated from0053029
2023-08-06 13:32shuehnerRelationship addeddepends on 0051068
2023-08-06 13:32shuehnerRelationship addedrelated to 0053029
2023-08-06 13:59hgbotNote Added: 0153261
2024-03-04 18:42hgbotNote Added: 0161637
2024-03-04 18:42hgbotResolutionopen => fixed
2024-03-04 18:42hgbotStatusnew => closed
2024-03-04 18:42hgbotFixed in Version => PR24Q2
2024-03-04 18:42hgbotNote Added: 0161638
2024-03-04 18:42hgbotNote Added: 0161639

Notes
(0153261)
hgbot   
2023-08-06 13:59   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/963 [^]
(0161638)
hgbot   
2024-03-04 18:42   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 0159293cb57de9f25b8636fd12e8ca7d916eb502
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 04-03-2024 12:14:36
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/0159293cb57de9f25b8636fd12e8ca7d916eb502 [^]

Fixes ISSUE-53170: Delete obsolete modulescript CreateAccountingConfiguration

This modulescript only ran on updates from before 16Q1

Issue 51068 blocks updates from <16Q1 causing it to never run on
updates anymore.

It also ran during install.source but that is not needed:
- It inserts rows into C_ACCTSCHEMA_TABLE and C_PERIODCONTROL
  - 3 sampledata ship entries in those tables
  - backoffice F&B, backoffice QA and AWO_QA
  - Re-exporting all three does not show changes done in the table
- It removes rows from AD_TABLE_ACCESS
  - No sampledata ships rows in that table
- It modifies rows in C_DOCTYPE table
  - backoffice F&B shows no changes to it on re-exporting
  - backoffice QA and AWO_QA show only unrelated changes to it on re-exporting

Remove it as obsolete.

---
R modules/org.openbravo.advpaymentmngt/build/classes/org/openbravo/advpaymentmngt/modulescript/CreateAccountingConfiguration.class
R modules/org.openbravo.advpaymentmngt/build/classes/org/openbravo/advpaymentmngt/modulescript/CreateAccountingConfigurationData.class
R modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/org/openbravo/advpaymentmngt/modulescript/CreateAccountingConfiguration.java
R modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/org/openbravo/advpaymentmngt/modulescript/CreateAccountingConfiguration_data.xsql
R modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/src/org/openbravo/advpaymentmngt/modulescript/CreateAccountingConfigurationData.java
---
(0161637)
hgbot   
2024-03-04 18:42   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 092528c38133865543982eabcd172a11902df2d6
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 04-03-2024 12:14:36
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/092528c38133865543982eabcd172a11902df2d6 [^]

Related to ISSUE-53170: Delete 3 obsolete modulescripts related to c_acctschema_table

CreateCostAdjustmentAcctConf and CreateLandedCostAcctConf only ran on
updates from <14Q2
CreateLandedCostCostAcctConf only ran on updates from <15Q1

Issue 51068 blocks updates from <16Q1 causing it to never run on
updates anymore.

All three ran during install.source but that is not needed:
- They insert rows into C_ACCTSCHEMA_TABLE
- 3 sampledata ship entries in that table
  - backoffice F&B, backoffice QA and AWO_QA
- Re-exporting all three does not show changes done in the table

Remove them as obsolete.

---
R src-util/modulescript/build/classes/org/openbravo/modulescript/CreateCostAdjustmentAcctConf.class
R src-util/modulescript/build/classes/org/openbravo/modulescript/CreateCostAdjustmentAcctConfData.class
R src-util/modulescript/build/classes/org/openbravo/modulescript/CreateLandedCostAcctConf.class
R src-util/modulescript/build/classes/org/openbravo/modulescript/CreateLandedCostAcctConfData.class
R src-util/modulescript/build/classes/org/openbravo/modulescript/CreateLandedCostCostAcctConf.class
R src-util/modulescript/src/org/openbravo/modulescript/CreateCostAdjustmentAcctConf.java
R src-util/modulescript/src/org/openbravo/modulescript/CreateCostAdjustmentAcctConf_data.xsql
R src-util/modulescript/src/org/openbravo/modulescript/CreateLandedCostAcctConf.java
R src-util/modulescript/src/org/openbravo/modulescript/CreateLandedCostAcctConf_data.xsql
R src-util/modulescript/src/org/openbravo/modulescript/CreateLandedCostCostAcctConf.java
---
(0161639)
hgbot   
2024-03-04 18:42   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/963 [^]