Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053142Retail ModulesWeb POSpublic2023-08-02 14:172023-08-30 13:44
Reportersofidossant 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product VersionRR22Q2 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerOBPS
Support ticket69270
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053142: Error with Credit note after adding the changes from issue 49409
DescriptionIf I add the changes from the issue https://issues.openbravo.com/view.php?id=49409 [^] and obviously have the changes from the issue https://issues.openbravo.com/view.php?id=37541, [^] I have the following error:


806685b3f246cc1e98997849eec0e7c5.js:205824 Uncaught TypeError: Cannot read properties of undefined (reading 'id')
    at giftcardPopup (806685b3f246cc1e98997849eec0e7c5.js:205824:54)
    at 806685b3f246cc1e98997849eec0e7c5.js:205882:7
    at G.d.callbackExecutor (806685b3f246cc1e98997849eec0e7c5.js:36984:7)
    at 806685b3f246cc1e98997849eec0e7c5.js:174586:23
    at G.d.callbackExecutor (806685b3f246cc1e98997849eec0e7c5.js:36984:7)
    at G.d.executeHooks (806685b3f246cc1e98997849eec0e7c5.js:36973:10)
    at 806685b3f246cc1e98997849eec0e7c5.js:83144:31
    at OB.UTIL.PrepaymentUtils.managePrepaymentChange (806685b3f246cc1e98997849eec0e7c5.js:91924:9)
    at G.d.addPayment (806685b3f246cc1e98997849eec0e7c5.js:83139:31)
    at G.d.addPayment (806685b3f246cc1e98997849eec0e7c5.js:116082:27)
Steps To Reproduce1 - Have the changes of the issues applied to the related issues.
2 - Open the webpos.
3 - Add a positive ticket and a non-generic customer.
4 - Add a negative ticket (with an amount greater than the positive one) and a customer
5. Pay open tickets and select the two previous ones.
6. Select the Avoir option and you will see the error in the console when giving pay total
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0049409 closed jorgewederago Pay open Tickets: Allow mixing positive and negative transaction 
related to defect 0037541 closed ranjith_qualiantech_com [SER-QA] The Credit Note printed is not the one actually redeemed, when paying with someone else's Credit Note 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-08-02 14:17sofidossantNew Issue
2023-08-02 14:17sofidossantAssigned To => Retail
2023-08-02 14:17sofidossantOBNetwork customer => OBPS
2023-08-02 14:17sofidossantSupport ticket => 69270
2023-08-02 14:17sofidossantTriggers an Emergency Pack => No
2023-08-07 14:11ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2023-08-08 13:34ranjith_qualiantech_comStatusnew => scheduled
2023-08-16 07:12hgbotMerge Request Status => open
2023-08-16 07:12hgbotNote Added: 0153492
2023-08-29 06:40hgbotMerge Request Statusopen => approved
2023-08-29 06:40hgbotResolutionopen => fixed
2023-08-29 06:40hgbotStatusscheduled => closed
2023-08-29 06:40hgbotNote Added: 0154073
2023-08-29 06:40hgbotNote Added: 0154074
2023-08-30 01:41rafarodaRelationship addedrelated to 0049409
2023-08-30 01:42rafarodaRelationship addedrelated to 0037541
2023-08-30 13:44hgbotNote Added: 0154203

Notes
(0153492)
hgbot   
2023-08-16 07:12   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/258 [^]
(0154073)
hgbot   
2023-08-29 06:40   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 2788c6388d8328f1c899f91676734a337a3c6a9f
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 28-08-2023 11:54:15
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/2788c6388d8328f1c899f91676734a337a3c6a9f [^]

Fixed ISSUE-53142: CreditNote created in PayOpenTickets for negative orders
* When completing negative ticket in PayOpenTickets,
  credit note should be created for negative ticket business partner

---
M web/org.openbravo.retail.giftcards/js/hooks/preaddpaymenthook.js
---
(0154074)
hgbot   
2023-08-29 06:40   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/258 [^]
(0154203)
hgbot   
2023-08-30 13:44   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 51a30f611a08bd20c40b76181b950da4bb259fee
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 30-08-2023 17:14:02
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/51a30f611a08bd20c40b76181b950da4bb259fee [^]

Related to ISSUE-53142: CreditNote searchKey should be created with negative orderId

---
M web/org.openbravo.retail.giftcards/js/hooks/preaddpaymenthook.js
---