Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053139Retail ModulesWeb POSpublic2023-08-02 13:322023-08-09 09:12
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR23Q4 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053139: A message should be logged when SynchronizationBuffer.internalFlush gives after reaching max amount of retries
DescriptionIn issue [1] a mechanism was introduced to retry flushing the synchronization buffer if any of its endpoints was already busy. It retries until either synchronizing them all, or reaching a maximum amount of retries.

It will be very useful to log a message in the terminal log if the maximum amount of retries was reached.

[1] https://issues.openbravo.com/view.php?id=53100 [^]
Steps To ReproduceSame as in [1] with a delay on the backend big enough (i.e. 8 seconds) to reach the maximum number of retries. Notice that no info is written in the terminal log even though the SynchronizationBuffer gave up.

[1] https://issues.openbravo.com/view.php?id=53100 [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0053100 closed AugustoMauch SynchronizationBuffer.internalFlush does not flush all messages if some endpoints where currently syncing other messages 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-08-02 13:32AugustoMauchNew Issue
2023-08-02 13:32AugustoMauchAssigned To => AugustoMauch
2023-08-02 13:32AugustoMauchOBNetwork customer => No
2023-08-02 13:32AugustoMauchTriggers an Emergency Pack => No
2023-08-02 13:34hgbotMerge Request Status => open
2023-08-02 13:34hgbotNote Added: 0153113
2023-08-02 14:01AugustoMauchRelationship addedrelated to 0053100
2023-08-02 14:01AugustoMauchStatusnew => scheduled
2023-08-03 14:57hgbotMerge Request Statusopen => approved
2023-08-09 09:12hgbotResolutionopen => fixed
2023-08-09 09:12hgbotStatusscheduled => closed
2023-08-09 09:12hgbotFixed in Version => RR23Q4
2023-08-09 09:12hgbotNote Added: 0153383
2023-08-09 09:12hgbotNote Added: 0153384

Notes
(0153113)
hgbot   
2023-08-02 13:34   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/586 [^]
(0153383)
hgbot   
2023-08-09 09:12   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: a238db50b5d10909296023bbf61ff0dfb561f636
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 09-08-2023 06:47:36
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/a238db50b5d10909296023bbf61ff0dfb561f636 [^]

Fixes ISSUE-53139: Show a message if the max number of retries is reached on SynchronizationBuffer.internalFlush

The message will include information about the number of attempts done and also the endpoints that were busy

---
M web/org.openbravo.mobile.core/app/model/synchronization-buffer/SynchronizationBuffer.js
---
(0153384)
hgbot   
2023-08-09 09:12   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/586 [^]