Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053118POS2Corepublic2023-08-01 14:442023-09-14 12:35
Reporteryogaskarnik 
Assigned Tojarmendariz 
PrioritynormalSeveritytrivialReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q4 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053118: UserAction does not return launch parameters when the action is canceled
DescriptionThe user can click on the Verified returns apply button more than once and the reason popup is opened twice.

Steps To ReproduceConfiguration:
1. Go to the User action reason window and configure a default reason.

1. Go to POS2,
2. Create a verified Return by clicking on Apply button the reason popup should appear.
3. Select a reason and click on OK button and click on Apply button again.
4. Notice that you can click on the Apply button more than once and the after the return ticket is added the reason popup appears again.
Proposed SolutionThe user action is canceled the launch parameters are not returned or added to the onAfter options


https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/72a94fc065e5b6ce885700988023f45a756647db/web-jspack/org.openbravo.core2/src/core/user-action/getUserAction.js#L35 [^]
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng return-reason.png (110,373) 2023-08-02 13:10
https://issues.openbravo.com/file_download.php?file_id=18836&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2023-08-01 14:44yogaskarnikNew Issue
2023-08-01 14:44yogaskarnikAssigned To => Triage Platform Base
2023-08-01 14:44yogaskarnikTriggers an Emergency Pack => No
2023-08-02 13:10yogaskarnikFile Added: return-reason.png
2023-08-02 13:11yogaskarnikSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=26573#r26573
2023-08-31 14:27hgbotNote Added: 0154252
2023-08-31 14:39jarmendarizAssigned ToTriage Platform Base => jarmendariz
2023-08-31 14:39jarmendarizStatusnew => scheduled
2023-09-08 14:13hgbotNote Added: 0154641
2023-09-14 12:35hgbotResolutionopen => fixed
2023-09-14 12:35hgbotStatusscheduled => closed
2023-09-14 12:35hgbotFixed in Version => 23Q4
2023-09-14 12:35hgbotNote Added: 0154841
2023-09-14 12:35hgbotNote Added: 0154842
2023-09-14 12:35hgbotNote Added: 0154843
2023-09-14 12:35hgbotNote Added: 0154844

Notes
(0154252)
hgbot   
2023-08-31 14:27   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2057 [^]
(0154641)
hgbot   
2023-09-08 14:13   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1244 [^]
(0154841)
hgbot   
2023-09-14 12:35   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 85ed5c9f5bb15d2a782e70c5bc26c1ca5c0c6e69
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 14-09-2023 11:20:46
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/85ed5c9f5bb15d2a782e70c5bc26c1ca5c0c6e69 [^]

Fixed ISSUE-53118: Adding enabled state to apply button in verified returns dialog to avoid tapping it accidentally when reason dialog is closed

---
M web-jspack/org.openbravo.pos2/src/components/VerifiedReturns/VerifiedReturnsForm/VerifiedReturnsForm.jsx
---
(0154842)
hgbot   
2023-09-14 12:35   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2057 [^]
(0154843)
hgbot   
2023-09-14 12:35   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 1136c53c8b0b892bab65d2ffd6571914d65b9065
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 14-09-2023 11:44:01
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/1136c53c8b0b892bab65d2ffd6571914d65b9065 [^]

Related to ISSUE-53118: Extended getUserAction return function to return the output of user action's launch function

---
M web-jspack/org.openbravo.core2/src/core/user-action/__mock__/UserActionLauncher.jsx
M web-jspack/org.openbravo.core2/src/core/user-action/__test__/GetUserAction.test.jsx
M web-jspack/org.openbravo.core2/src/core/user-action/getUserAction.js
---
(0154844)
hgbot   
2023-09-14 12:35   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1244 [^]